OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 11:40
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 124

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 26 Feb 2022
2:23 pm

gustafn

switch from xo::db::sql to acs::dc interface

Options
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-procs.tcl
Friday 25 Feb 2022
3:01 pm

gernst

Make the initial population of the request-monitor counters more robust

Options
    • -5
    • +9
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
2:09 pm

gustafn

simplify logic

Options
    • -4
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
2:04 pm

antoniop

Fix variable name

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
1:56 pm

gustafn

switch from xo::db::sql to acs::dc interface

Options
    • -2
    • +3
    /openacs-4/packages/chat/chat.info
    • -3
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -1
    • +1
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
    • -2
    • +3
    /openacs-4/packages/dotlrn-xowiki/dotlrn-xowiki.info
    • -7
    • +7
    /openacs-4/packages/dotlrn-xowiki/tcl/xowiki-applet-procs.tcl
    • -2
    • +3
    /openacs-4/packages/xooauth/xooauth.info
    • -1
    • +1
    /openacs-4/packages/xooauth/tcl/package-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
10:48 am

antoniop

Basic test of the proctoring upload endpoint

Options
    • -0
    • +92
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
Thursday 24 Feb 2022
10:41 am

antoniop

Switch to a select widget to keep a more predictable vertical size in case of many time presets

Options
    • -34
    • +21
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
Wednesday 23 Feb 2022
7:40 pm

gustafn

Prefer "::acs::dc call ..." over "::xo::db::sql::..."

Use the common new acs interface rather than the xotcl-core variant.

Goal should be on the medium time range to replace all of the

"::xo::db::sql::*" interface.

Options
    • -123
    • +136
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
    • -15
    • +15
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
7:24 pm

gustafn

Align names used in utility db functions in Oracle and PostgreSQL

Over the years, the names used in the function for PostgreSQL and

Oracle drifted away, which is a problem when using call-by-name

convention for stored procedures. Furthermore, recent Oracle versions

do not allow attributes named "table" (for table_name). So the longer

version is now used uniformily. Fortunately, nsf allow abbreviation

for named parameters (like Tcl does), such one can use both

"-table_name" and "-table".

Bumped version number to 5.10.1d7.

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -6
    • +6
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
    • -0
    • +312
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
    • -158
    • +157
    /openacs-4/packages/acs-kernel/sql/postgresql/utilities-create.sql
    • -0
    • +167
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
7:24 pm

gustafn

file upgrade-5.10.1d6-5.10.1d7.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
5:30 pm

antoniop

Notify new revisions on a proctoring artifact on the object's websocket, in a way that the users list, already designed to refresh in case on messages, will display new information when the revision is proceeding

Options
    • -4
    • +14
    /openacs-4/packages/proctoring-support/www/review.tcl
5:01 pm

antoniop

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
4:15 pm

antoniop

Generate the fullscreen preview element in javascript and make it a child of the body, so that it can expand to the full page also when the include itself would be rendered in a smaller container

Options
    • -3
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
4:07 pm

antoniop

Implement a pre-selection filter for timeframes, which can be extended using downstream specific logics

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +7
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -1
    • +37
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -0
    • +25
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +21
    /openacs-4/packages/proctoring-support/tcl/proctoring-callback-procs.tcl
3:18 pm

gustafn

make sure, the dependencies are aligned (drop of xo::site_node)

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
3:12 pm

gustafn

remove call of xo::site_node

Options
    • -4
    • +5
    /openacs-4/packages/acs-admin/tcl/site-wide-procs.tcl
Tuesday 22 Feb 2022
6:25 pm

gustafn

make sure not to swallow error conditions, as the previous changes did.

This change will report an error in the systemlog when called on invalid objects/data

Options
    • -2
    • +10
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
3:30 pm

antoniop

Various changes on the proctoring artifacts users list:

- display some statistics on the collected artifacts for each user: count, number of reviewed, number of flagged, plus a colored progress bar indicating the review status, orange when in progress, red when completed with flags and green when everything is ok

- switched to a template::list to avoid too much handcrafting

- removed the red delete button from the top of the page, redundant, since we have the bulk actions on the list

- refined the behavior of the bulk-action delete button: it will be disabled when nothing is selected

- now we always trigger a reload when new artifacts are received for this object, but we cap it to 60 seconds

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +5
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -102
    • +75
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -20
    • +89
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
2:10 pm

antoniop

Store the string "false", not the boolean false

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/www/review.tcl
12:24 pm

gustafn

Improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
12:24 pm

gustafn

Fine-tuning the new db function interface

#

# Check, wether we have to regenerate the database function interface.

#

# - During initial setup, there are no db-functions, so nothing has to

# be done.

#

# - During regular startup of the server, the generation of the stub

# interface happens in the *init procs (hopefully this is always

# sufficient, but seems so)

#

# - During reloads of acs-db-*-procs, the base classes are interface

# objects are recreated and cleaned up from all prior definitons,

# which means that in this situations, we have to regeneate the

# interface.

#

# - One might call manually the regeneration, when database functions

# have been altered and no restart is desired.

#

Options
    • -10
    • +41
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
10:01 am

antoniop

Use a full join so that in case of (normally minimal) unalignment between camera and desktop, we still display every artifact

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
10:00 am

gustafn

avoid dead operations

Options
    • -3
    • +6
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
9:51 am

antoniop

Keep making sure permission exists

Options
    • -1
    • +2
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
Monday 21 Feb 2022
9:35 pm

gustafn

Reform of site-nodes-procs

- made XOTcl2 based implementation of site-nodes usable during

initial bootstrap

- made new site-node cache implementation working for Oracle

- now, the same code works during bootstrap, for PostgreSQL and Oracle

and independent of xotcl-core being installed or not.

- removed old and broken nsv-based site-node cache

- reduced need of .xql files (removed query for delete.delete_site_node)

- moved deprecated calls to deprecated-procs.tcl

This change make the code much clearer and eases maintenance and debugging.

Options
    • -327
    • +499
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -6
    • +0
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs-oracle.xql
    • -6
    • +0
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs-postgresql.xql
    • -1587
    • +777
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
9:27 pm

gustafn

Update of SQL function calling interface to make it usable during initial bootstrap

- add sanity checks and produce error messages,

when function args are incorrect.

- do not throw errors in case it is called before the

table acs_function_args was created (during boot)

- added preliminary "list" call to acs::dc

- added first *-init.tcl to be called after loading

the *-proc.tcl files.

- removed all references to the ::xo::* namespace

Options
    • -0
    • +9
    /openacs-4/packages/acs-tcl/tcl/00-acs-tcl-init.tcl
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/20-memoize-init.tcl
    • -3
    • +29
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -7
    • +50
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
9:27 pm

gustafn

file 00-acs-tcl-init.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-acs-tcl-init.tcl
9:13 pm

gustafn

Make parameter::get_from_package_key usable during inital boot

This change makes parameter::get_from_package_key usable during

initial boot, i.e. before the table apm_parameters is created.

In these cases, the function returns just the default value.

Options
    • -55
    • +71
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
9:11 pm

gustafn

Support memory units as default of the cache sizes

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
8:42 pm

gustafn

update questionable test slightly

Options
    • -11
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl