• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

Make inclass-exam more foolproof

In case, the randomization is NOT suited for a real exam, do not allow

the user to publish this exam. In cases, where creating exams with

randomization=always are ok, pass "p.realexam=0" to the create

link (and call the entry maybe "training exam")

    • -1
    • +12
    /openacs-4/packages/xowf/lib/inclass-exam.wf
file upgrade-5.10.1d2-5.10.1d3.sql was initially added on branch oacs-5-10.

stick to the original names with the "-" since this is also the naming convention outside of OpenACS (e.g. "scram-sha-256")

    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
Set ad_include_contract's local variables in a way that they are hinted as private by the "__" prefix: this reduces the chance of conflicting with popular variable names to pass to an include such as "context"

Change caching of driver keys

There seems to be a bug in "db_driverkey", when OpenACS connects to

multiple databases [1]. The situation with "db_driverkey" is

complicated by the fact that this function is sometimes called with a

database name in its argument "dbn", and sometimes with a database

handle. This is something to look at in the future.

The new version removes the per-thread caching, which was introduced

to reduce the high number of mutex locks caused in busy machines. The

new version is better by a factor of 2 than older versions, but relies

on NaviServer.

[1] https://openacs.org/forums/message-view?message_id=5537865

file upgrade-5.10.1d1-5.10.1d2.sql was initially added on branch oacs-5-10.

Complete reform introduced in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20210928124647

- add datamodel change to the creation script

- refactor algorithm names in a way that the new procs will comply with acs-tcl.naming__proc_naming automated test

    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
Fix typo affecting only a fresh installation of the chat package...

revert regression introduced on Aug 07 and factor out common code

file upgrade-5.10.0-5.10.1d1.sql was initially added on branch oacs-5-10.

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
Add missing argument expansion and comply with automated test

Test for ad_register_proc exposing a bug due to missing argument expansion

file request-processor-procs.tcl was initially added on branch oacs-5-10.

Improved spelling

let the per_thread_cache behave like the per_connection_cache when the NaviServer configuration valriable "cachingmode" is set to none

reduce deprecated calls

    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/list.tcl
file news.page was initially added on branch oacs-5-10.

file table-of-contents.page was initially added on branch oacs-5-10.

file sitemapindex.xml.page was initially added on branch oacs-5-10.

file sitemap.xml.page was initially added on branch oacs-5-10.

file podcast.page was initially added on branch oacs-5-10.

file book.page was initially added on branch oacs-5-10.

file news-item.form.page was initially added on branch oacs-5-10.

file link.page was initially added on branch oacs-5-10.

file index.page was initially added on branch oacs-5-10.

file ical.page was initially added on branch oacs-5-10.

file contributors.page was initially added on branch oacs-5-10.

file categories-portlet.page was initially added on branch oacs-5-10.