OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 17
Total Committers: 146
Last Commit: 10:50
Commits this week: 17
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Aug 2021
11:55 am

gustafn

more cleanup for setting of potentially unencoded return_url

Options
    • -2
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/menu-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Saturday 07 Aug 2021
11:48 am

gustafn

minor cleanup for returnurls

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/flush-url-statistics.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:46 am

gustafn

don't hard-code "Learner" as role

Options
    • -1
    • +5
    /openacs-4/packages/xooauth/tcl/lti-procs.tcl
11:43 am

gustafn

streamline returnredirect commands

make sure, the provided URL is always properly encoded

Options
    • -4
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -6
    • +8
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -8
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Friday 06 Aug 2021
1:31 pm

antoniop

Fix typo in datamodel creation, make it atomic

Options
    • -2
    • +5
    /openacs-4/packages/proctoring-support/sql/postgresql/proctoring-support-create.sql
6:40 am

gustafn

ad_return_url: experimental change to produce per default a proper encoded result

Background: before this change, ad_return_url encoded always the query

variables but not the URL path. This mixed result is complex to handle

to achieve ex-post a proper encoding. The function has a flag

"-urlencode", which is nowhere used in OpenACS. Other functions like

e.g. export_vars, or pretty_link return per default as well the

encoded URL. "ad_return_url" has a new flag "-path_encode=false" to

obtain the previous behavior (similar to the other mentioned

functions).

Options
    • -8
    • +19
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
Thursday 05 Aug 2021
7:36 pm

gustafn

break overlong lines and improve comments

Options
    • -75
    • +107
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
4:30 pm

gustafn

bugfix: don't call get_non_empty_file_formfields in render_answers when in export mode

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Tuesday 03 Aug 2021
9:28 pm

gustafn

improve spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:22 pm

gustafn

provide a compatibility function for ns_parsehostport for earlier versions of NaviServer

Options
    • -3
    • +18
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
9:10 pm

gustafn

make spelling more consistent

Options
    • -6
    • +6
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
9:00 pm

gustafn

prefer variable resolver over method calls for unset

Options
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
8:58 pm

gustafn

minor refactoring to correct old-style widgetSpecs; prefer variable resolver over method calls for unset

Options
    • -21
    • +30
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
7:26 pm

gustafn

support editor=none in arbitrary form-field specs

Options
    • -9
    • +17
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
1:43 pm

gustafn

added composite question per default to the "New" pull-down menu, added message keys for German

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -1
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
1:40 pm

gustafn

make sure that the query variable "show" is only passed non-empty, otherwise the page-contract of admin/message-list.tcl will fail

Options
    • -9
    • +9
    /openacs-4/packages/acs-lang/www/admin/edit-localized-message.tcl
Monday 02 Aug 2021
11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -4
    • +2
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/shared/1pixel.tcl
    • -6
    • +3
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -9
    • +5
    /openacs-4/packages/acs-tcl/tcl/pdf-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl
    • -12
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -7
    • +4
    /openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl
11:23 pm

gustafn

prefer usage of "xo::write_tmp_file" over "xo::write_file" for writing tmp files

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +8
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
11:16 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -5
    • +6
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
    • -2
    • +1
    /openacs-4/packages/xotcl-core/www/show-class-graph.tcl
    • -9
    • +7
    /openacs-4/packages/xotcl-core/www/show-object.tcl
11:12 pm

gustafn

added function xo::write_tmp_file

The new function uses an atomic call to create a temporary file and

is therefore lass prone to attacks.

bumped verison number to 5.10.0d41

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -0
    • +8
    /openacs-4/packages/xotcl-core/tcl/utilities-procs.tcl
11:09 pm

gustafn

reinstantiate accidentially deleted code

Options
    • -0
    • +9
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:00 pm

gustafn

fix header generation

since the headers are set in a loop, "ns_set put" is incorrect

since it is additive. "ns_set update" is correct.

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
7:38 pm

gustafn

make using page-filter "object_id" backwards compatible by allowing it to be used also during update scripts

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-reload.tcl
    • -5
    • +20
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
7:36 pm

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
7:04 pm

gustafn

improve log message

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
4:45 pm

antoniop

Do not urlencode the return URL in every case, but only when this falls back to the current URL from the connection context, normally coming from "ns_conn url" which will return it "raw", as in not encoded for any purpose

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Sunday 01 Aug 2021
6:54 pm

gustafn

add comments with class names to ease navigation in the source file

Options
    • -2
    • +169
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Friday 30 Jul 2021
3:43 pm

antoniop

URLencode the return URL, or the server might complain for invalid characters (e.g. unencoded umlaut characters)

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Thursday 29 Jul 2021
7:27 pm

gustafn

whitespace change

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
7:27 pm

gustafn

Remove hard-coded styling with the "style" element to get a more consistent appearance

(many thanks to Monika Andergassen for looking into this).

Options
    • -7
    • +2
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/table-widget-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/yui-procs.tcl
    • -8
    • +8
    /openacs-4/packages/xowiki/www/admin/list.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/www/resources/xowiki-yui-specific.css