OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 09:27
Commits this week: 18
Total Lines of Code (LoC): 7,560,948
Net change in LoC this week: 127

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 Jun 2019
12:15 pm

gustafn

replace hardcoded /tmp by API function [ad_tmpdir]

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/email-image-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/openacs-kernel-procs.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation-portlet/tcl/test/tclwebtest-procs.tcl
    • -1
    • +1
    /openacs-4/packages/file-storage/tcl/test/tclwebtest-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/http-client-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/syndicate-procs.tcl
12:14 pm

gustafn

template::reset_request_vars must be executed for all requests in the cleanup

this is already happening via "ns_ictl trace freeconn", but we keep

for the time being this as a reminder, when merging with different versions, etc.

Options
    • -2
    • +8
    /openacs-4/packages/acs-templating/tcl/acs-integration-procs.tcl
Sunday 16 Jun 2019
10:07 pm

gustafn

don't hardcode /tmp/

Options
    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
9:58 pm

gustafn

simplify file delivery modes

Options
    • -8
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
8:51 pm

gustafn

don't start accidentially thread via monitoring

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/running.tcl
3:12 pm

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
3:11 pm

gustafn

replace deprecated function ad_var_type_check_number_p which was used improperly

Options
    • -9
    • +18
    /openacs-4/packages/acs-lang/www/admin/set-system-timezone.tcl
2:50 pm

gustafn

replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

Options
    • -3
    • +5
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl
2:33 pm

gustafn

replace deprecated ad_var_type_check_number_p by "string is double -strict "

Options
    • -5
    • +5
    /openacs-4/packages/evaluation/www/admin/evaluations/evaluate-students-2.tcl
    • -4
    • +4
    /openacs-4/packages/evaluation/www/admin/evaluations/evaluate-students.tcl
    • -3
    • +3
    /openacs-4/packages/evaluation/www/admin/evaluations/grades-sheet-parse.tcl
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/evaluations/one-evaluation-edit.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation/www/admin/grades/distribution-edit-2.tcl
2:22 pm

gustafn

Mark value checking functions from before ad_page_contract as deprecated

(see also issue #3407)

A 16 years old comment says:

This is some old security crud from before we had ad_page_contract

check_for_form_variable_naughtiness

ad_var_type_check_integer_p

ad_var_type_check_safefilename_p

ad_var_type_check_dirname_p

ad_var_type_check_number_p

ad_var_type_check_word_p

ad_var_type_check_nocheck_p

ad_var_type_check_noquote_p

ad_var_type_check_integerlist_p

Options
    • -12
    • +18
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
2:01 pm

gustafn

fix seplling errors

Options
    • -2
    • +2
    /openacs-4/packages/assessment/assessment.info
    • -9
    • +9
    /openacs-4/packages/assessment/catalog/assessment.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/assessment/www/index-oracle.xql
    • -1
    • +1
    /openacs-4/packages/assessment/www/index-postgresql.xql
    • -2
    • +2
    /openacs-4/packages/assessment/www/index.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/index.xql
1:49 pm

gustafn

fix spelling errors

Options
    • -3
    • +3
    /openacs-4/packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml
    • -5
    • +5
    /openacs-4/packages/evaluation/www/admin/evaluations/evaluate-students-2.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation/www/admin/evaluations/grades-sheet-explanation.adp
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/evaluations/one-evaluation-edit.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
1:40 pm

gustafn

whitespace changes

Options
    • -2
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
1:38 pm

gustafn

avoid usage of ad_var_type_check_integer_p

(use Tcl idiom "string is integer -strict" instead)

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
1:33 pm

gustafn

fix typos in message catalog and bump version number to force reload

Options
    • -2
    • +2
    /openacs-4/packages/evaluation/evaluation.info
    • -2
    • +2
    /openacs-4/packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/evaluation/catalog/evaluation.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/evaluation/catalog/evaluation.pt_BR.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/tasks/task-add-edit.tcl
1:25 pm

gustafn

whitespace changes

Options
    • -190
    • +191
    /openacs-4/packages/evaluation/www/admin/evaluations/grades-sheet-parse.tcl
1:20 pm

gustafn

avoid usage of ad_var_type_check_integer_p

Options
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/evaluations/grades-sheet-parse.tcl
Friday 14 Jun 2019
6:45 pm

antoniop

Use a HTML-quote safe idiom to indent categories in the widget

Options
    • -1
    • +1
    /openacs-4/packages/categories/tcl/widget-procs.tcl
12:50 pm

gustafn

improve documentation and make clear that strong dependency

of request monitor on bgdelivery does not exist anymore

Options
    • -5
    • +10
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
12:46 pm

gustafn

use ns_asynclogfile instead of bgdelivery when available

Options
    • -10
    • +46
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
12:44 pm

gustafn

added ns_asynclogfile to icanuse features

Options
    • -1
    • +10
    /openacs-4/packages/acs-tcl/tcl/00-canisue-procs.tcl
11:26 am

gustafn

document optional channel closing during subscribe operations

Options
    • -5
    • +13
    /openacs-4/packages/acs-subsite/www/shared/ajax/chat.tcl
Thursday 13 Jun 2019
1:05 pm

gustafn

output warnings when workflow constructs are created shadowing potentially global commands

Options
    • -3
    • +23
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:03 am

antoniop

Make sure connection channel is available (e.g. not detached) before returning content, as more recent Naviserver versions would return an error

Options
    • -2
    • +4
    /openacs-4/packages/acs-subsite/www/shared/ajax/chat.tcl
8:54 am

mischa

Fix proc 'before-ns_log' (ns_log can be invoked with multiple args)

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcltrace-procs.tcl
8:51 am

mischa

Fix proc 'before-ns_log' (ns_log can be invoked with multiple args)

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcltrace-procs.tcl
Tuesday 11 Jun 2019
9:00 pm

gustafn

improve code documentation and honor existing settings

Options
    • -7
    • +33
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
8:58 pm

gustafn

add missing ad_script_abort

Options
    • -1
    • +2
    /openacs-4/packages/file-storage/www/view/index.vuh
8:57 pm

gustafn

whitespace changes

Options
    • -4
    • +9
    /openacs-4/packages/dotlrn/tcl/dotlrn-init.tcl
8:56 pm

gustafn

improve spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl