OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jan
1:50 pm

antoniop

Cleanup long deactivated code

Options
    • -1
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/index-postgresql.xql
    • -13
    • +1
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
1:33 pm

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/resources/core.js
1:32 pm

antoniop

Improve documentation

Options
    • -0
    • +8
    /openacs-4/packages/acs-subsite/www/resources/core.js
1:28 pm

antoniop

Cleanuo commented code

Options
    • -9
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
1:28 pm

antoniop

Whitespace cleanup

Options
    • -2
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
1:25 pm

antoniop

Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

Options
    • -1603
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
    • -1
    • +4
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
    • -0
    • +1609
    /openacs-4/packages/acs-templating/www/resources/calendar.js
1:25 pm

antoniop

file calendar.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/www/resources/calendar.js
1:25 pm

antoniop

Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

Options
    • -0
    • +3
    /openacs-4/packages/dotlrn-ecommerce/lib/section.tcl
    • -1
    • +4
    /openacs-4/packages/expense-tracking/www/admin/addedit-expense.tcl
    • -0
    • +1
    /openacs-4/packages/invoices/lib/invoice-items-list.adp
    • -0
    • +1
    /openacs-4/packages/invoices/lib/offer-items-list.adp
    • -0
    • +4
    /openacs-4/packages/invoices/www/invoice-ae.tcl
    • -0
    • +3
    /openacs-4/packages/invoices/www/invoice-cancellation.tcl
    • -0
    • +3
    /openacs-4/packages/invoices/www/invoice-credit.tcl
    • -0
    • +2
    /openacs-4/packages/invoices/www/invoice-customer-reports.adp
    • -0
    • +2
    /openacs-4/packages/invoices/www/invoice-list.adp
    • -0
    • +3
    /openacs-4/packages/invoices/www/offer-ae.tcl
    • -0
    • +1
    /openacs-4/packages/invoices/www/offer-first-reports.adp
    • -0
    • +1
    /openacs-4/packages/invoices/www/offer-projects-reports.adp
    • -0
    • +2
    /openacs-4/packages/invoices-portlet/www/invoices-list-portlet.adp
    • -0
    • +1
    /openacs-4/packages/project-manager/lib/projects.adp
    • -0
    • +3
    /openacs-4/packages/project-manager/templates/project-ae.tcl
  16. … 3 more files in changeset.
12:44 pm

antoniop

Cleanup commented code

Options
    • -11
    • +1
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
Tuesday 23 Jan
4:04 pm

antoniop

Fix the idiom used to cut the query parameters from the URL

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/resources/core.js
2:20 pm

antoniop

Revert to an approach that will not change the [self] object, which has unexpected consequences

Options
    • -2
    • +9
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
1:13 pm

antoniop

Replace custom calendar widget implementation with native HTML5 fields

Options
    • -6
    • +2
    /openacs-4/packages/dotlrn-catalog/www/dt-admin/course-add-edit.tcl
    • -6
    • +7
    /openacs-4/packages/dotlrn-ecommerce/www/applications.tcl
1:10 pm

antoniop

Replace custom calendar widget implementation with native HTML5 fields

Options
    • -6
    • +2
    /openacs-4/packages/assessment/www/asm-admin/admin-request.tcl
1:07 pm

antoniop

Handle null dates

Options
    • -3
    • +4
    /openacs-4/packages/acs-subsite/www/resources/core.js
11:40 am

antoniop

Replace custom calendar widget implementation with native HTML5 fields

Options
    • -15
    • +3
    /openacs-4/packages/dotlrn/www/admin/term-edit.tcl
    • -23
    • +3
    /openacs-4/packages/dotlrn/www/admin/term-new.tcl
8:39 am

antoniop

Modernize idioms

Options
    • -21
    • +11
    /openacs-4/packages/acs-subsite/www/resources/core.js
8:26 am

antoniop

Cleanup acs_CopyText and inline the only usage found in the codebase with a modern replacement

The function was using deprecated idioms, see https://developer.mozilla.org/en-US/docs/Web/API/document/execCommand, and "PrivilegeManager" and the "netscape" property, both long discontinued.

On modern browsers, under the correct conditions, the function can be reimplemented via a oneliner (see https://developer.mozilla.org/en-US/docs/Web/API/Clipboard)

Options
    • -36
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
8:26 am

antoniop

Cleanup acs_CopyText and inline the only usage found in the codebase with a modern replacement

The function was using deprecated idioms, see https://developer.mozilla.org/en-US/docs/Web/API/document/execCommand, and "PrivilegeManager" and the "netscape" property, both long discontinued.

On modern browsers, under the correct conditions, the function can be reimplemented via a oneliner (see https://developer.mozilla.org/en-US/docs/Web/API/Clipboard)

Options
    • -2
    • +2
    /openacs-4/packages/simulation/www/citybuild/object-edit.tcl
Monday 22 Jan
7:18 pm

gustafn

provide link to nsstats on startup page on fresh installations (when available)

Options
    • -0
    • +4
    /openacs-4/packages/acs-subsite/www/index.adp
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/index.tcl
6:53 pm

gustafn

fixed vertical placement of login link

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.adp
6:34 pm

gustafn

fix for containarized applications: don't use configured location unless host-name-map is in place

containeraized applications with the hostnode map will still have a problem, but these are

less frequent. For these, a solution is still pending.

Options
    • -8
    • +21
    /openacs-4/packages/acs-subsite/www/admin/index.tcl
5:55 pm

antoniop

Shorten idiom

Options
    • -6
    • +3
    /openacs-4/packages/acs-subsite/www/resources/core.js
5:50 pm

antoniop

Modernize idioms via optional chaining

Options
    • -6
    • +5
    /openacs-4/packages/acs-subsite/www/resources/core.js
5:36 pm

antoniop

Prefer string interpolation via template literals

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/resources/core.js
5:33 pm

antoniop

Cleanup trivial acs_initHtmlArea and inline its only usages in the codebase

Options
    • -7
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
5:33 pm

antoniop

Cleanup trivial acs_initHtmlArea and inline its only usages in the codebase

Options
    • -2
    • +2
    /openacs-4/packages/theme-ges/www/theme-ges-blank-master.tcl.txt
    • -2
    • +2
    /openacs-4/packages/theme-selva/www/selva-blank-master.tcl
    • -2
    • +2
    /openacs-4/packages/theme-selva/www/doc/selva-blank-master.tcl
5:23 pm

gustafn

clear diry editor buffer

Options
    • -6
    • +8
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
5:13 pm

antoniop

Cleanup trivial api, nowadays replaceable with a simple oneliner and inline the only usage found upstream

Options
    • -9
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/session-delete.tcl
5:06 pm

antoniop

Use modern javascript and browser features to simplify the code

Options
    • -16
    • +10
    /openacs-4/packages/acs-subsite/www/resources/core.js
3:52 pm

antoniop

Use a better idiom to revert changes on the object, that e.g. will handle the same arrays and variables

Options
    • -4
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl