OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 146
Last Commit: 14 Nov
Commits this week: 10
Total Lines of Code (LoC): 7,560,821
Net change in LoC this week: 22

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Feb 2023
5:15 pm

antoniop

Increase proc coverage

Options
    • -1
    • +92
    /openacs-4/packages/acs-lang/tcl/test/locale-procs.tcl
4:25 pm

antoniop

Cleanup private interface lang::system::timezone_support_p: ref-timezones has been made a dependency of acs-lang long ago

Options
    • -33
    • +2
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
    • -83
    • +73
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/change-locale-include.tcl
    • -3
    • +0
    /openacs-4/packages/acs-lang/www/admin/index.adp
    • -2
    • +1
    /openacs-4/packages/acs-lang/www/admin/index.tcl
    • -6
    • +0
    /openacs-4/packages/acs-lang/www/admin/set-system-timezone.tcl
4:09 pm

antoniop

Allow to specify a user for lang::user::language, default to the package default locale when a locale for user+package is not found

Options
    • -3
    • +4
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
    • -4
    • +10
    /openacs-4/packages/acs-lang/tcl/locale-procs.xql
4:08 pm

antoniop

Increase proc coverage

This test will fail because of two reasons:

- when using package-level locales and a package default locale is specified, but no user+package locale, the expected behavior should be that the default from the package is used, but this is not the case

- lang::user::language does not allow to specify a user id

Options
    • -0
    • +101
    /openacs-4/packages/acs-lang/tcl/test/locale-procs.tcl
4:08 pm

antoniop

file locale-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-lang/tcl/test/locale-procs.tcl
2:49 pm

antoniop

Increase proc coverage

Options
    • -5
    • +104
    /openacs-4/packages/acs-lang/tcl/test/lang-catalog-procs.tcl
1:54 pm

antoniop

Increase proc coverage

Options
    • -0
    • +46
    /openacs-4/packages/acs-lang/tcl/test/lang-catalog-procs.tcl
1:54 pm

antoniop

file lang-catalog-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-lang/tcl/test/lang-catalog-procs.tcl
1:47 pm

antoniop

Export the catalog via the api to normalize quoting

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/acs-lang.info
    • -5
    • +5
    /openacs-4/packages/acs-lang/catalog/acs-lang.en_US.ISO-8859-1.xml
1:35 pm

antoniop

Set the (default) theme package on the subsite upon installation in a way that theme parameters are actually set on the subsite, go back to be stricter when checking for unmodified themes

Options
    • -0
    • +7
    /openacs-4/packages/acs-subsite/tcl/apm-callback-procs.tcl
    • -6
    • +5
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
9:57 am

gustafn

bump version number of bootstrap icons to 1.10.3

Options
    • -2
    • +2
    /openacs-4/packages/bootstrap-icons/bootstrap-icons.info
    • -2
    • +2
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
9:48 am

gustafn

bump version number of CKeditor to 4.20.1

Options
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
Tuesday 07 Feb 2023
6:50 pm

gustafn

Cluster reform

- Support for dynamic cluster nodes:

Previous versions of OpenACS required to know the IP addresses of

the cluster nodes in advance, which is a show-stopper for many cloud

applications.

The new functionality allows arbitrary nodes to register as client

nodes at the canonical server, provided that these know a shared

secret. All messages of the intra-cluster talk are now

cryptographically signed using this shared secret.

In the current version, the shared secret key has to be specified in

the NaviServer configuration file (ClusterSecret). Later versions

will support the use of other measures such as generated keys, kept

as files.

Also in the new version it is still possible to use static peer

addresses (which do not have to register during startup).

- Support for multiple protocols for intra-cluster talk

Previous version of OpenACS required the communication of the

intra-cluster talk over HTTP. With these changes, multiple protocols

are supported. Most prominently HTTPS can be used, which is required

by some organization for all web communication, especially for cloud

applications. Other protocols might be added later (e.g. UDP).

- Nodes (such as the canonical server) can be specified via URL

locations. These location specifier have the following advantages

over classical IP address and port.

* support different protocols (http, https, udp)

* support of IP addresses or DNS names

* when DNS names map to multiple IP addresses

(e.g. multiple IPv4 and/or multiple IPv6 addresses)

the new parameter PreferredLocationRegexp can be use

to select the wanted. When this regexp does not match

any of the addresses, the first address is used.

* ports are now optional (except UDP)

* for location specifier: https://openacs.org

- Support for cluster communication statistics

(requires xotcl-request-monitor)

These statistics show the amount of intra-server

communication. The following statistics are collected

per node:

- number of broadcast operations

- number of send operations (active flushes)

- number of receive operation (passive flushes)

For N cluster nodes, the send operations are

basically the number of broadcast operations times

the number of nodes minus one.

These statistics can also be used prior to cluster

enabling, to obtain the number of potential broadcast

operations.

Kernel Parameters

CanonicalServer : location of the canonical server

ClusterAuthorizedIP : obsolete

ClusterEnabledP : unchanged

ClusterPeerIP : obsolete

EnableLoggingP : unchanged

PreferredLocationRegexp : new

DynamicClusterPeers : new, no not edit

Differences between old and new value for "CanonicalServer":

old:

- specify IP address with port

- example: 137.208.116.31:443

new:

- specify URL location

- support different protocols (http, https, udp)

- support of IP address or domain name

- when domain name maps to different IP addresses

(e.g. multiple IPv4 and/or multiple IPv6 addresses)

PreferredLocationRegexp can be use to select the wanted.

When the provided regexp does not match any of

the addresses, take the first address.

- port is optional

- example: https://openacs.org

Sample setup

Old:

CanonicalServer : 137.208.116.31:443

ClusterAuthorizedIP : 137.208.116.31

ClusterPeerIP : 137.208.116.31:443 137.208.116.31:8443

ClusterEnabledP : 1

EnableLoggingP : 1

New:

CanonicalServer : https://openacs.org

PreferredLocationRegexp : https://

ClusterEnabledP : 1

EnableLoggingP : 1

#

# Cluster secret for intra-cluster communications in NaviServer

# configuration file. Clustering will not be enabled if no value is

# provided.

#

ns_section ns/server/$server/acs {

# ...

ns_param ClusterSecret "please change me"

}

#-----------------------------------------------------------------------

# Support for munin statistics

#

# 1) install munin plugins for naviserver (munin-plugins-ns.git)

# 2) add link to the munin plugins (replace "openacs" by the name

# of your server in the munin configuration)

# /etc/munin/plugins/naviserver_openacs_count_cluster -> /usr/share/munin/plugins/naviserver_count

# 3) in the plugin plugin configuration (e.g., etc/munin/plugin-conf.d/naviserver)

# add a section like the following (again, replace "openacs" by the server name you used)

#

# [naviserver_openacs_count_cluster]

# env.title Cluster

# env.vars cluster:broadcast cluster:sent cluster:received

#

# 4) restart munin

Options
    • -5
    • +6
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -26
    • +44
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -245
    • +639
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
    • -95
    • +25
    /openacs-4/packages/acs-tcl/tcl/server-cluster-procs.tcl
6:28 pm

gustafn

make util::join_location usabel for udp and smtp

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:27 pm

gustafn

silence warning about query names in the log file

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
6:00 pm

antoniop

Increase coverage of page contract filters

Options
    • -5
    • +167
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
5:57 pm

antoniop

Deprecate usphone page filter, as a more generic alternative exists that does not assume the US as target audience

Options
    • -3
    • +8
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
4:50 pm

hectorr

Whitespace changes

Options
    • -29
    • +21
    /openacs-4/packages/dotlrn/www/community-edit.tcl
    • -19
    • +19
    /openacs-4/packages/dotlrn/dotlrn.info
3:09 pm

antoniop

Improve proc coverage

Options
    • -0
    • +88
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
2:36 pm

antoniop

Deprecate ad_decorate_top, superseded by modern templating features

Options
    • -4
    • +9
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
2:32 pm

antoniop

Deprecate ad_package_admin_home, limited, inaccurate and superseded by site node api

Options
    • -4
    • +12
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
2:21 pm

antoniop

Deprecate ad_db_select_widget, superseded by modern template system features

Options
    • -2
    • +9
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
2:15 pm

antoniop

Deprecate ad_dateentrywidget, with hardcoded values, superseded by modern features

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -2
    • +9
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
    • -4
    • +2
    /openacs-4/packages/assessment/www/doc/display_types.adp
    • -2
    • +1
    /openacs-4/packages/assessment/www/doc/display_types.html
1:46 pm

antoniop

Deprecate trivial wrappers for ad_html_text_convert

Options
    • -3
    • +11
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -3
    • +3
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
    • -1
    • +1
    /openacs-4/packages/general-comments/tcl/test/general-comments-procs.tcl
12:49 pm

antoniop

Remove leftover call tpo deprecated api

Options
    • -5
    • +1
    /openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl
12:47 pm

antoniop

Deprecate acs_privacy:: api and inline the few usages in the dotlrn packages

See https://openacs.org/forums/message-view?message_id=5672076

Options
    • -3
    • +3
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -5
    • +29
    /openacs-4/packages/acs-tcl/tcl/acs-private-data-procs.tcl
    • -5
    • +4
    /openacs-4/packages/dotlrn/dotlrn.info
    • -5
    • +5
    /openacs-4/packages/dotlrn/tcl/dotlrn-security-procs.tcl
    • -5
    • +1
    /openacs-4/packages/forums-portlet/www/forums-portlet.tcl
Monday 06 Feb 2023
6:11 pm

antoniop

Deprecate old api

Options
    • -2
    • +12
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
6:00 pm

antoniop

Increase proc coverage

Options
    • -1
    • +241
    /openacs-4/packages/acs-subsite/tcl/test/subsite-procs.tcl
4:01 pm

antoniop

Fix regression shown by test

Options
    • -4
    • +8
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
4:00 pm

antoniop

Increate proc coverage

Options
    • -0
    • +65
    /openacs-4/packages/acs-subsite/tcl/test/subsite-procs.tcl