• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use naviserver api to parse URL variables

Final phasing out of acs_named_objects

- remove table creation

- update documentation

- provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream).

Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable.

From an excerpt of the Changelog file:

.....

2004-03-31 jeffd

......

* packages/categories/tcl/category-trees-procs-oracle.xql:

* packages/categories/tcl/category-trees-procs-postgresql.xql:

acs_named_objects superflous now that title is in

acs_objects. need to fix the rest of the occurances though

......

This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in sql. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time.

    • -78
    • +6
    /openacs-4/packages/categories/www/doc/o.adp
    • -88
    • +10
    /openacs-4/packages/categories/www/doc/o.html
file upgrade-1.1.5d3-1.1.5d4.sql was initially added on branch oacs-5-10.

Phase out usage of obsolete acs_named_objects table

Whitespace cleanup

Cleanup var, break overlong line

Rework of category UI:

- phase out usage of acs_named_objects, use object title instead

- rework pagination using builtin template::list features

- reduce hardcoded styling and markup

- rework strange database idioms

- remove divergency between oracle and postgres codebase

include "topic-assignment.wf" in list of displayed workflow types

prefer using API over query in package for common data model

Use built-in "ns_parsequery" instead of manual parsing of query parameters

Use built-in "ns_parsequery" instead of manual parsing of query parameters

Use built-in "ns_parsequery" instead of manual parsing of query parameters.

Note, that this change might alter query processing, since previously

query parameter without explicit values were treated as boolean values

(like in HTML), now these are treated like "x=" before. The new version is

about 10x faster.

Furthermore, new tests of the regression tests were added for query parameter

processing.

file api-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/api-test-procs.tcl
fixed description of test file

Formatting change

Refactor of category mapping UI:

- remove reference to obsolete and unmaintained acs_named_objects, which was preventing the UI to work in practice

- rework pagination and other idioms to long standing template::list best practices

- reduce hardcoded styling

Whitespace changes

Use the new 'url' input type

Add new 'url' input type to 'ad_form'

Whitespace changes

Refactoring of the upload-size-limit admin page of the file-storage. Sets a default value of 2GB when no maxinput is found in the config file, and uses the new 'number' ad_form widget. Bump version for the widget dependency

Make sure that in case of errors that are also detected as timeouts, we do not reschedule the failed picture twice

perform conditional updates of context_id, fetch now storage_type as well to streamline code in the future

Fix typo

fix typo

extend regression test: provide tests of the basic life-cycle steps of the inclass-exam

fix typo

added new regression test

file cookie-consent-test-procs.tcl was initially added on branch oacs-5-10.

improve test coverage