• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix var name

Creating a user without a username is possible if the authority is local, include the test authority among those for which we generate a username, as it is also local as in "hosted locally"

Fixes acs-authentication.auth_use_email_for_login_p automated test

reduce public footprint

whitespace changes: break overlong lines

bug fix: do not swallow errors in "aa_run_with_teardown" when -rollback s activated

reduce public footprint

remove dependency of general-comments on acs-mail-lite

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
reduce public footprint

adjust to recent changes

Adjust page contract to reality. 'name_weight' can be the string 'exact'

Add IDs to the different forms

Change input widget to 'number' and use a maximum value for 'messages_time_window' that can be validated in the browser. Bump version number, and add dependency to the 'acs-templating' version providing with the new 'number' widget

    • -1
    • +2
    /openacs-4/packages/chat/www/room-edit.tcl
Bump version number, so packages making use of the new input type 'template::widget::number' can depend on this particular version

Add 'template::widget::number', a widget for the form input type 'number'

reduce public footprint

Whitespace changes

    • -1
    • +1
    /openacs-4/packages/search/search.info
    • -70
    • +68
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
Avoid trailing whitespace on info file creation

reduce public footprint

replace low-level cr_fs_path by higher level interface content::revision::get_cr_file_path

    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
improve navigation when multiple packages are selected

fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate

By adding an "ad_try", we can see that the intention to create

a user with no username failed. Probably this was working at some time,

not sure, if it still should.

This is could be a general problem with "aa_run_with_teardown" to

terminate too early in such cases.

fix typo

adjust luminosity calculation to the 2020 standard for UHDTV and HDR

remove spurious parens

improve spelling

    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
calculate total points based on points and not on minutes

    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Handle potential race condition in search observer queue maintenance

In some cases, when e.g. objects are quicky deleted after updates, the

object might be already be deleted when being tried to trigger a

DELETE operation in the search queue. as a consequence, one can sometimes

observer errors like the one below. The new code double-checks now,

if the object for the DELETE operation still exists.

ERROR: insert or update on table "search_observer_queue" violates foreign key constraint "search_observer_queue_object_id_fk"

: DETAIL: Key (object_id)=(497509146) is not present in table "acs_objects".

: CONTEXT: SQL statement "insert into search_observer_queue (

    • -2
    • +2
    /openacs-4/packages/search/search.info
file upgrade-5.10.0d3-5.10.0d4.sql was initially added on branch oacs-5-10.

whitespace changes: break overlong lines

    • -12
    • +20
    /openacs-4/packages/search/tcl/search-procs.tcl
whitespace changes