OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 30 May 2018
4:55 pm

antoniop

As username variable is not used, don't rely on side effects to check for user existance. Indentation changes.

Options
    • -8
    • +12
    /openacs-4/packages/notifications/www/request-notification.tcl
    • -2
    • +2
    /openacs-4/packages/notifications/www/request-notification.xql
4:43 pm

antoniop

Employ new user cache also for portrait information

Options
    • -3
    • +7
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
4:11 pm

antoniop

Reduce divergencies between oracle and postgres codebase... this file was for some reason deleted in 2001, but sql in it is portable

Options
    • -18
    • +0
    /openacs-4/packages/acs-admin/www/users/registration-history-oracle.xql
    • -19
    • +0
    /openacs-4/packages/acs-admin/www/users/registration-history-postgresql.xql
    • -0
    • +16
    /openacs-4/packages/acs-admin/www/users/registration-history.xql
2:16 pm

antoniop

Use more API

Note that now we assume email and user_id will be from parties that actually belong to the system

Options
    • -3
    • +6
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs.tcl
    • -23
    • +0
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs.xql
2:00 pm

antoniop

Remove (again) this almost 20 years old program

Options
    • -73
    • +0
    /openacs-4/packages/acs-admin/www/users/sessions-registered-summary.tcl
1:50 pm

antoniop

Use more api

Options
    • -6
    • +6
    /openacs-4/packages/acs-subsite/www/members/user-new.tcl
Tuesday 29 May 2018
8:28 pm

antoniop

Make clearer what is going on here (a lot, apparently)

Options
    • -14
    • +66
    /openacs-4/packages/assessment/www/asm-admin/admin-request.tcl
8:06 pm

antoniop

Remove unused query and put last remaining inline to avoid xql file. Reduce joining

Options
    • -1
    • +12
    /openacs-4/packages/assessment/www/asm-admin/request-notification.tcl
    • -26
    • +0
    /openacs-4/packages/assessment/www/asm-admin/request-notification.xql
7:54 pm

antoniop

Don't pass fine tcl variables through the database for random reasons, improve code legibility, reduce divergency between oracle and postgres codebase, exploit multi-user permission checking on postgres

Options
    • -40
    • +3
    /openacs-4/packages/assessment/www/asm-admin/send-mail-oracle.xql
    • -48
    • +6
    /openacs-4/packages/assessment/www/asm-admin/send-mail-postgresql.xql
    • -14
    • +33
    /openacs-4/packages/assessment/www/asm-admin/send-mail.tcl
    • -0
    • +22
    /openacs-4/packages/assessment/www/asm-admin/send-mail.xql
7:21 pm

antoniop

Beautify code, remove unneded variables and queries

Options
    • -22
    • +19
    /openacs-4/packages/assessment/tcl/as-apm-checks-procs.tcl
7:09 pm

antoniop

Reduce joining

Options
    • -6
    • +8
    /openacs-4/packages/chat/www/room-oracle.xql
    • -5
    • +4
    /openacs-4/packages/chat/www/room-postgresql.xql
    • -2
    • +4
    /openacs-4/packages/chat/www/room.tcl
6:32 pm

antoniop

Don't cache invalid user ids, as they might become valid shortly after (e.g. during registration)

Options
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
5:14 pm

gustafn

flag current request as being performed via aa_testing

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
4:50 pm

michaela

Fix missing close bracket

Options
    • -1
    • +1
    /openacs-4/packages/acs-object-management/lib/forms/generic.tcl
3:52 pm

michaela

Fix typo. See also https://www.duden.de/rechtschreibung/E_Mail_Adresse

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
2:19 pm

trenner

use form_name in url

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
11:35 am

antoniop

Remove unneded xql

Options
    • -18
    • +0
    /openacs-4/packages/acs-admin/www/users/user-add-2.xql
11:30 am

antoniop

Use more API when retrieving user info and portrait, streamline queries, put all sql inline

Options
    • -4
    • +21
    /openacs-4/packages/acs-subsite/www/user/portrait/comment-edit.tcl
    • -44
    • +0
    /openacs-4/packages/acs-subsite/www/user/portrait/comment-edit.xql
11:18 am

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -34
    • +0
    /openacs-4/packages/acs-templating/tcl/widget-procs-oracle.xql
    • -32
    • +0
    /openacs-4/packages/acs-templating/tcl/widget-procs-postgresql.xql
    • -0
    • +31
    /openacs-4/packages/acs-templating/tcl/widget-procs.xql
11:13 am

antoniop

Use API when retrieving user info

Options
    • -2
    • +4
    /openacs-4/packages/acs-tcl/lib/page-error.tcl
    • -11
    • +2
    /openacs-4/packages/acs-tcl/lib/page-error.xql
11:09 am

antoniop

Remove unnecessary xql

Options
    • -9
    • +11
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -40
    • +0
    /openacs-4/packages/acs-subsite/www/pvt/alerts.xql
11:05 am

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -35
    • +0
    /openacs-4/packages/dotlrn/www/admin/users-oracle.xql
    • -36
    • +0
    /openacs-4/packages/dotlrn/www/admin/users-postgresql.xql
    • -2
    • +4
    /openacs-4/packages/dotlrn/www/admin/users.tcl
    • -0
    • +30
    /openacs-4/packages/dotlrn/www/admin/users.xql
10:56 am

antoniop

Don't pass fine tcl variables through the query, avoid unnecessary quoting (bulk-mail api would pass variable to the stored procedure using ':' notation)

Options
    • -9
    • +4
    /openacs-4/packages/dotlrn/www/spam.tcl
    • -7
    • +2
    /openacs-4/packages/dotlrn/www/spam.xql
10:44 am

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -42
    • +0
    /openacs-4/packages/dotlrn/www/register-oracle.xql
    • -43
    • +0
    /openacs-4/packages/dotlrn/www/register-postgresql.xql
    • -0
    • +37
    /openacs-4/packages/dotlrn/www/register.xql
10:34 am

antoniop

Use more API when retrieving user info

Options
    • -7
    • +5
    /openacs-4/packages/acs-admin/www/users/user-batch-add.tcl
10:27 am

antoniop

Replace leftover Naviserver-only cache idioms with retro compatible ones

Options
    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Monday 28 May 2018
8:26 pm

antoniop

Put this last query also in the code as the others, so no xql is required

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/users/new.tcl
    • -10
    • +0
    /openacs-4/packages/acs-subsite/www/admin/users/new.xql
8:23 pm

antoniop

Use more API, reduce divergency between postgres and oracle code

Options
    • -13
    • +0
    /openacs-4/packages/acs-subsite/www/admin/users/new-oracle.xql
    • -13
    • +0
    /openacs-4/packages/acs-subsite/www/admin/users/new-postgresql.xql
    • -14
    • +8
    /openacs-4/packages/acs-subsite/www/admin/users/new.tcl
    • -35
    • +5
    /openacs-4/packages/acs-subsite/www/admin/users/new.xql
8:10 pm

antoniop

Use more API

Options
    • -6
    • +4
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
7:53 pm

antoniop

Use more API

Options
    • -12
    • +18
    /openacs-4/packages/acs-subsite/www/shared/portrait.tcl
    • -10
    • +8
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -6
    • +3
    /openacs-4/packages/acs-admin/www/users/user-add-2.tcl