• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Converge downstream reading_info feature with upstream

Port downstream only idiom to update reading_info table

Make more use of api when retrieving forum and message information

Optimize message existance query

Fix sql update to populate new forum_id column in existing data

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -5
    • +2
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Remove deprecated idioms and unneded queries

Persist sanitized timestamp into data object before saving (Many thanks to Markus Moser)

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -18
    • +18
    /openacs-4/packages/forums/lib/forums/new.tcl
    • -7
    • +27
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -8
    • +12
    /openacs-4/packages/forums/tcl/forums-procs.xql
Update docs: remove broken links and remove/update obsolete section

  1. … 285 more files in changeset.
further cleanup for XOTcl2

    • -99
    • +101
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
    • -24
    • +0
    /openacs-4/packages/xowiki/www/edit.adp
Simplify idiom

Since PostgreSQL 10 does not support the tsearch2 backword compatibility package anymore, make sure that OpenACS does not use the old names requiring this package.

Revert db_exec_plsql or Oracle will break, remove leftover xql files

restrict detail statistics to swa

Optimize query by using multi-object permission checking and trying to filter the most tuples before joining cr_items with cr_revisions

Reduce divergence between oracle and postgres

Fix oracle systax to call function via select

Uniform API when deleting folder, drill through some calling levels in stored procedure, use a simpler db_string instead of db_exec_plsql

Fix broken links

Remove broken links

make sure to create in initialize WorkflowContext new and remove duplicated instproc

    • -10
    • +6
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Bring legacy versions of image__new() in sync with the actual definitions

fix variable reference

check stripped_name before trying to import the prototype page

    • -3
    • +5
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Fixes for previous commit

Bump version number

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
Prefer XOTcl2 idioms

    • -114
    • +108
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
    • -486
    • +481
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -187
    • +187
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Prefer XOTcl2 idioms

    • -154
    • +134
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
    • -55
    • +52
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -225
    • +225
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
Prefer XOTcl2 idioms

    • -110
    • +100
    /openacs-4/packages/xowiki/tcl/syndicate-procs.tcl
    • -46
    • +45
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
Prefer XOTcl2 idioms

    • -119
    • +111
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
Prefer XOTcl2 idioms

    • -56
    • +54
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -24
    • +24
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -31
    • +31
    /openacs-4/packages/xowiki/tcl/menu-procs.tcl
prefer XOTcl2 idioms

    • -115
    • +92
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl