• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
aks: checking in a bunch of memoization, and some small fixes

    • -1
    • +42
    ./packages/dotlrn/tcl/community-procs.tcl
    • -5
    • +5
    ./packages/dotlrn/tcl/community-procs.xql
    • -13
    • +10
    ./packages/dotlrn/tcl/site-nodes-procs.tcl
    • -32
    • +34
    ./packages/dotlrn/tcl/site-nodes-procs.xql
made some improvements to the subgroup membership widget

    • -6
    • +18
    ./packages/dotlrn/www/members-chunk.adp
making description optional

    • -2
    • +3
    ./packages/dotlrn/www/subcommunity-new.tcl
aks: removed log_time calls, some cleanup

    • -35
    • +29
    ./packages/new-portal/tcl/portal-procs.tcl

Most of this fixes up the creation of application groups for subsites.

Subsites - for PG at least - still have some serious problems that need

fixing.

    • -1
    • +2
    ./packages/acs-api-browser/www/index.adp
    • -1
    • +3
    ./packages/acs-api-browser/www/index.tcl
    • -2
    • +1
    ./packages/acs-tcl/tcl/apm-procs-oracle.xql
    • -3
    • +35
    ./packages/acs-tcl/tcl/apm-procs.tcl
    • -4
    • +13
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
fixed links & navigation

updated calendar to have an item editing page (this is NOT YET functional on PG, finalizing testing)

    • -2
    • +2
    ./packages/calendar/www/cal-dayview.tcl
    • -6
    • +6
    ./packages/calendar/www/cal-item-create.tcl
    • -0
    • +33
    ./packages/calendar/www/cal-item-view.adp
    • -0
    • +62
    ./packages/calendar/www/cal-item-view.tcl
    • -2
    • +2
    ./packages/calendar/www/cal-monthview.tcl
    • -2
    • +2
    ./packages/calendar/www/cal-weekview.tcl

1. Hitting the site with the host name only (http://foo.com) reveals that

[ns_conn urlc] is incorrectly set to "1" and [ns_conn urlv] to [list "\"\""].

I've masked this in the ad_conn structure, so [ad_conn urlc] == 0 and

[ad_conn urlv] == [list].

2. When a cookie is set to an empty string, ad_set_cookie sets it to

"\"\"". I've modified ad_get_cookie to return the empty string if the

cookie it grabs from the browser is "\"\"". I looked quite carefully around

the toolkit and saw no code that appears to depend on this abberant behavior.

    • -1
    • +8
    ./packages/acs-tcl/tcl/utilities-procs.tcl
AKS: rename non-full cal portlet to "Day Summary"

adding the remove_user functionality

    • -73
    • +73
    ./packages/dotlrn-faq/tcl/dotlrn-faq-procs.tcl
    • -1
    • +29
    ./packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
cleaning up some queries

    • -18
    • +0
    ./packages/dotlrn/www/admin/clubs-oracle.xql
    • -0
    • +14
    ./packages/dotlrn/www/admin/clubs.xql
removed unnecessary query in one case

foo

    • -3
    • +2
    ./packages/dotlrn/tcl/department-procs.tcl
using templating system constructs instead of straight tcl code

    • -32
    • +24
    ./packages/dotlrn/www/manage-memberships.adp
fixed query to be more foolproof against sorting weirdness in the connect by

minimized number of queries

    • -39
    • +57
    ./packages/dotlrn/www/dotlrn-main-portlet.adp
    • -4
    • +2
    ./packages/dotlrn/www/dotlrn-main-portlet.tcl
    • -31
    • +0
    ./packages/dotlrn/www/dotlrn-main-portlet.xql
these are oracle specific queries they should be in an oracle specific file

    • -0
    • +34
    ./packages/dotlrn/www/dotlrn-main-portlet-oracle.xql
updated package metadata to reflect file removal

    • -2
    • +0
    ./packages/acs-datetime/acs-datetime.info
fixed broken memoized call; made memoized procs private

    • -10
    • +10
    ./packages/dotlrn/tcl/community-procs.tcl
quick fix

    • -1
    • +1
    ./packages/faq-portlet/www/faq-portlet.adp
getting rid of cc_users

    • -5
    • +10
    ./packages/dotlrn/www/admin/users-oracle.xql
20 queries to 1 query

    • -23
    • +2
    ./packages/fs-portlet/www/fs-portlet.tcl
minimizing number of queries

    • -1
    • +0
    ./packages/faq-portlet/faq-portlet.info
    • -11
    • +52
    ./packages/faq-portlet/www/faq-portlet.adp
    • -95
    • +3
    ./packages/faq-portlet/www/faq-portlet.tcl
    • -14
    • +0
    ./packages/faq-portlet/www/faq-portlet.xql
bringing back one_instance_p

    • -2
    • +2
    ./packages/news-portlet/www/news-portlet.adp
    • -1
    • +2
    ./packages/news-portlet/www/news-portlet.tcl
20 queries to 1 query

    • -1
    • +1
    ./packages/news-portlet/news-portlet.info
    • -0
    • +25
    ./packages/news-portlet/www/news-portlet-oracle.xql
    • -7
    • +25
    ./packages/news-portlet/www/news-portlet.adp
    • -46
    • +2
    ./packages/news-portlet/www/news-portlet.tcl
    • -30
    • +0
    ./packages/news-portlet/www/news-portlet.xql
added parent_id function to apm_package package

optimized dotlrn_users view

fixed up

    • -1
    • +1
    ./packages/dotlrn/www/my-communities.adp
fixed up the full portlet some more

fixed up redirection to make calendar pages easier to integrate with other systems (like dotLRN)

    • -2
    • +7
    ./packages/calendar/www/cal-item-create.tcl
    • -3
    • +8
    ./packages/calendar/www/cal-item-edit.tcl