OpenACS / openacs-4 / packages

xolp

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 01 Sep
Commits this week: 0
Total Lines of Code (LoC): 15,836
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 31 May 2021
3:40 pm

antoniop

Split statements into multiple database commands:

issuing multiple sql statements in the same command is a undocumented feature, probably exploited for performance reason, but not officially supported. The dml api will check if the first statement (supposed to be the only one) is actually a DML one. As the first statement in the chain is a select, the command fails.

Fixes xolp automated tests

Options
    • -16
    • +26
    ./tcl/xolp-indicator-procs.tcl
1:40 pm

hectorr

Add tested procs to test cases

Options
    • -0
    • +17
    ./tcl/test/xolp-test-procs.tcl
Sunday 30 May 2021
7:58 pm

gustafn

fix typo

Options
    • -1
    • +1
    ./tcl/xolp-indicator-procs.tcl
7:57 pm

gustafn

avoid "tuple concurrently updated" errors from PostgreSQL

These errors are produced from PostgreSQL, when multiple

"CREATE OR # REPLACE FUNCTION" SQL are executed..

see e.g.:

https://stackoverflow.com/questions/40525684/tuple-concurrently-updated-when-creating-functions-in-postgresql-pl-pgsql

Options
    • -1
    • +13
    ./tcl/xolp-indicator-procs.tcl
Tuesday 06 Apr 2021
3:07 pm

hectorr

Update spanish message keys

Options
    • -0
    • +4
    ./catalog/xolp.es_ES.ISO-8859-1.xml
  2. … 2 more files in changeset.
Wednesday 10 Feb 2021
5:29 pm

antoniop

Indroduce new indexes on xolp_activity_hierarchy_bridge and xolp_competency_set_bridge

Options
    • -0
    • +8
    ./tcl/xolp-activity-procs.tcl
    • -0
    • +8
    ./tcl/xolp-competency-procs.tcl
Monday 02 Nov 2020
7:07 pm

hectorr

Add 'package_id' for tests so it does not need to be guessed

Options
    • -6
    • +6
    ./tcl/test/xolp-test-procs.tcl
5:26 pm

hectorr

Add 'package_id' for tests so it does not need to be guessed

Options
    • -2
    • +3
    ./tcl/test/xolp-test-procs.tcl
Wednesday 28 Oct 2020
1:08 pm

hectorr

Reuse computations

Options
    • -24
    • +34
    ./tcl/test/xolp-test-procs.tcl
Tuesday 27 Oct 2020
4:13 pm

hectorr

Add 'package_id' for tests so it does not need to be guessed

Options
    • -4
    • +2
    ./tcl/xolp-activity-procs.tcl
    • -1
    • +1
    ./tcl/xolp-iri-procs.tcl
    • -18
    • +65
    ./tcl/test/xolp-test-procs.tcl
Friday 29 Nov 2019
12:12 pm

antoniop

Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper

Options
    • -3
    • +3
    ./tcl/test/xolp-test-procs.tcl
Friday 27 Sep 2019
12:32 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./tcl/xolp-indicator-procs.tcl
Thursday 02 May 2019
6:56 pm

antoniop

Do not require uuid package anymore

Options
    • -2
    • +0
    ./tcl/xolp-util-procs.tcl
5:46 pm

antoniop

Use ns_uuid Naviserver command instead of uuid::uuid generate from tcllib: apparently, this can interact badly with clock localized formatting, leading to the "GREGORIAN_CHANGE_DATE" issue

Options
    • -2
    • +2
    ./tcl/xolp-util-procs.tcl
Wednesday 24 Apr 2019
5:27 pm

antoniop

Do not depend on dt_systime

Apparently, this makes xolp tests more robust with respect to issue discussed in https://stackoverflow.com/questions/49031790/how-can-i-debug-a-tcl-8-6-error-in-clock-tcl#49033144

Options
    • -1
    • +1
    ./tcl/xolp-indicator-procs.tcl
Monday 15 Apr 2019
11:46 am

antoniop

Fix 3 inconsistent log messages in the test

Options
    • -3
    • +3
    ./tcl/test/xolp-test-procs.tcl
Friday 12 Apr 2019
2:35 pm

antoniop

Prefer portable current_timestamp idiom to NOW()

Options
    • -2
    • +2
    ./tcl/xolp-activity-procs.tcl
    • -3
    • +3
    ./tcl/xolp-indicator-procs.tcl
2:17 pm

antoniop

Exploit existing acs::test::user::create api

Options
    • -20
    • +3
    ./tcl/xolp-util-procs.tcl
2:09 pm

antoniop

Normalize indentation, add editor hints

Options
    • -39
    • +46
    ./tcl/xolp-activity-procs.tcl
    • -14
    • +21
    ./tcl/xolp-competency-procs.tcl
    • -0
    • +7
    ./tcl/xolp-date-procs.tcl
    • -37
    • +44
    ./tcl/xolp-evaluation-procs.tcl
    • -54
    • +61
    ./tcl/xolp-indicator-procs.tcl
    • -10
    • +17
    ./tcl/xolp-iri-procs.tcl
    • -0
    • +7
    ./tcl/xolp-procs.tcl
    • -0
    • +7
    ./tcl/xolp-time-procs.tcl
    • -31
    • +38
    ./tcl/xolp-user-procs.tcl
    • -10
    • +17
    ./tcl/xolp-util-procs.tcl
    • -859
    • +866
    ./tcl/test/xolp-test-procs.tcl
1:48 pm

antoniop

Modernize XoTcl idioms

Options
    • -10
    • +10
    ./tcl/xolp-activity-procs.tcl
    • -2
    • +2
    ./tcl/xolp-competency-procs.tcl
    • -11
    • +9
    ./tcl/xolp-evaluation-procs.tcl
    • -17
    • +17
    ./tcl/xolp-indicator-procs.tcl
    • -12
    • +11
    ./tcl/xolp-iri-procs.tcl
    • -3
    • +3
    ./tcl/xolp-user-procs.tcl
1:27 pm

antoniop

Use xotcl-core indentation convention

Options
    • -95
    • +96
    ./tcl/xolp-apm-procs.tcl
1:17 pm

antoniop

Whitespace cleanup, normalize indentation, add editor hints

Options
    • -94
    • +100
    ./tcl/xolp-apm-procs.tcl
1:15 pm

antoniop

Use xotcl db idioms

Options
    • -4
    • +4
    ./tcl/test/xolp-test-procs.tcl
1:09 pm

antoniop

Rollback tests or they will interfere with the others

Options
    • -0
    • +2
    ./tcl/test/xolp-test-procs.tcl
11:37 am

antoniop

Reimplement query to obtain user competencies to fix xolp.user_get_competencies automated test

Personal perplexities:

- why do we specify the competency_set_id on the indicator facts? If one fact can be e.g. an exam, this might be related with multiple competency sets

- should we take into account also the validity of an activity?

Options
    • -14
    • +36
    ./tcl/xolp-user-procs.tcl
Thursday 11 Apr 2019
6:28 pm

antoniop

Port downstream commit cab327aeda04f1f1f6b8f2310ddc88c7c081a84f from Günter Ernst:

Minor adjustments to ensure install- and uninstallability

Options
    • -7
    • +17
    ./tcl/xolp-apm-procs.tcl
    • -1
    • +1
    ./tcl/xolp-competency-procs.tcl
    • -0
    • +1
    ./tcl/xolp-indicator-procs.tcl
5:36 pm

antoniop

Port of downstream commit 9cbc3f04aad075e902e64d0c67d53158160a933c from Felix Möedritscher:

feature / issue #10359: added message keys, extended the xolp API - get_competencies, get_activities_of_package, update_title

Options
    • -2
    • +2
    ./xolp.info
    • -0
    • +4
    ./catalog/xolp.de_DE.ISO-8859-1.xml
    • -0
    • +4
    ./catalog/xolp.en_US.ISO-8859-1.xml
    • -0
    • +22
    ./tcl/xolp-activity-procs.tcl
    • -0
    • +12
    ./tcl/xolp-competency-procs.tcl
3:31 pm

antoniop

Insert missing performance indicators for the user

Options
    • -0
    • +10
    ./tcl/test/xolp-test-procs.tcl
3:25 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./tcl/test/xolp-test-procs.tcl
2:10 pm

antoniop

As xolp_indicator_facts_check1 wants end_timestamp <= storage_timestamp, force end_timestamp some time in the past (api won't allow to specify storage_timestamp)

Options
    • -1
    • +1
    ./tcl/test/xolp-test-procs.tcl