• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Be Bootstrap 5 friendly

Prefer modal implementation from acs-templating to the various approaches used so far

  1. … 2 more files in changeset.
Be stricter with user output:

- enable again the check for monochrome pictures

- enable for the screen as well that one should not send the same identycal picture twice

Reduce impact of PiP preview on the user experience: start PiP only when the window loses focus and interrupt PiP whenever the user interacts with the page in the foreground again

Implement "ground-truth" check for proctoring to make sure that we are sending pictures

When more than 10 times the expected maximum proctoring interval has pasased without any picture being successfully sent to the server, the proctored session will be aborted.

  1. … 6 more files in changeset.
Port of downstream behavior:

to prevent modern browsers to shut down proctoring when put out of focus, make so that a foreground PiP of one of the streams is always displayed.

Reuse the canvas objects throughout the proctoring

Follow Chrome suggestion and apply the willReadFrequently option to the canvas context

See https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently

Fully qualify global classes

Use a consistent idiom to check for undefined

AudioContext is now widely supported

Stop supporting old-sytle media capturing

Prefer an idiom that won't create a fresh object to reset array

Style changes:

- use ' instead of " consistently in the code

- use strict equality operators

Modernize javascript:

- use const and let instead of var to better specify the scope and lifetime of variables

Fix event we listen to

Shorten idioms

Modernize javascript

- prefer querySelector api

- use classList to manipulate the objects classes

Declare variable as constant

Style changes:

- use ' instead of " to delimit strings

- use strict equality operators

    • -115
    • +115
    ./resources/proctored-page.js
Modernize javascript idioms

Fix typo

Fix the case of the last comment

Improve performance of delete operation

Behavior reform:

now commenting an artifact won't be considered as "OK". To flag an artifact as "OK" or "for review", one has to explicitly click on the green and red buttons.

  1. … 2 more files in changeset.
Implement buttons to set all artifacts for a user as ok or not ok

  1. … 6 more files in changeset.
file review-all.tcl was initially added on branch oacs-5-10.

Notify new revisions on a proctoring artifact on the object's websocket, in a way that the users list, already designed to refresh in case on messages, will display new information when the revision is proceeding

Store the string "false", not the boolean false

Normalize the way the flag is represented in the JSON