OpenACS / openacs-4 / packages

attachments

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 25
Last Commit: 29 Jul
Commits this week: 0
Total Lines of Code (LoC): 4,444
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 16 Sep 2021
10:27 am

gustafn

fix release dates in .info files

Options
    • -1
    • +1
    ./attachments.info
  2. … 82 more files in changeset.
Wednesday 15 Sep 2021
6:11 pm

gustafn

release work

Options
    • -2
    • +2
    ./attachments.info
  2. … 204 more files in changeset.
Friday 03 Sep 2021
11:14 am

gustafn

regenerated documentation

Options
    • -2
    • +3
    ./www/doc/index.adp
  2. … 468 more files in changeset.
Thursday 02 Sep 2021
7:22 pm

gustafn

bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

Options
    • -2
    • +2
    ./attachments.info
  2. … 87 more files in changeset.
Tuesday 22 Jun 2021
4:43 pm

hectorr

Add minimal test case for 'attachments::get_package_key'

Options
    • -1
    • +12
    ./tcl/test/attachments-procs.tcl
Monday 31 May 2021
6:42 pm

hectorr

Increment version number due to past catalog changes

Options
    • -4
    • +4
    ./attachments.info
Thursday 18 Feb 2021
3:19 pm

hectorr

Remove leftover comment

Options
    • -2
    • +1
    ./tcl/test/attachments-procs.tcl
3:16 pm

hectorr

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

Options
    • -0
    • +89
    ./tcl/test/attachments-procs.tcl
3:16 pm

hectorr

file attachments-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/attachments-procs.tcl
Sunday 24 Nov 2019
12:10 pm

gustafn

improve documentation

Options
    • -1
    • +1
    ./www/doc/index.adp
    • -1
    • +1
    ./www/doc/index.html
Monday 19 Aug 2019
9:00 am

gustafn

improve spelling

Options
    • -1
    • +1
    ./catalog/attachments.en_AU.ISO-8859-1.xml
  2. … 6 more files in changeset.
Saturday 17 Aug 2019
11:18 am

gustafn

improve spelling

Options
    • -6
    • +5
    ./www/doc/index.html
    • -4
    • +4
    ./www/doc/src/attachments.apt
  3. … 2 more files in changeset.
Wednesday 14 Aug 2019
4:28 pm

hectorr

Return a fallback attachments url when not in a connection context, for example, during mail sending on the bulk-mail package

Options
    • -17
    • +21
    ./tcl/attachments-procs.tcl
Thursday 18 Jul 2019
6:04 pm

hectorr

Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

Options
    • -4
    • +51
    ./tcl/attachments-procs.tcl
Monday 15 Jul 2019
12:53 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./www/doc/index.adp
  2. … 3 more files in changeset.
Friday 12 Jul 2019
4:31 pm

hectorr

Only offer the possibility to delete an attachment from the file storage if it is really there, offer to detach it in any case.

Options
    • -2
    • +2
    ./www/detach.adp
    • -58
    • +75
    ./www/detach.tcl
4:19 pm

hectorr

Add 'attachments::get_title' to centralize the logic of title guessing for an attachment

Options
    • -37
    • +51
    ./tcl/attachments-procs.tcl
Thursday 11 Jul 2019
6:41 pm

hectorr

Whitespace changes

Options
    • -15
    • +20
    ./www/go-to-attachment.xql
    • -2
    • +2
    ./www/download/index.xql
6:38 pm

hectorr

Generalize attachment download logic, so it can deal with different object types, such as 'content_item', 'content_revision', and their subtypes

Options
    • -44
    • +60
    ./www/go-to-attachment.tcl
    • -0
    • +14
    ./www/go-to-attachment.xql
    • -11
    • +35
    ./www/download/index.vuh
    • -1
    • +12
    ./www/download/index.xql
6:01 pm

hectorr

Add 'exception_count' to 'ad_return_complaint'

Options
    • -3
    • +5
    ./www/download/index.vuh
Wednesday 10 Jul 2019
8:39 pm

hectorr

Make 'attachments::get_all_attachments' more general, so we try our best to get the 'label' of the attachment by trying different options depending on the object type: 'content_item', 'content_revision', a subtype of those, or just the 'title' row in the 'acs_objects' table. In the very worst case, just set the given 'item_id' as the label.

Options
    • -24
    • +38
    ./tcl/attachments-procs.tcl
2:50 pm

hectorr

Prefer live to latest revision when getting title for attachments in 'attachments::get_all_attachments'

Options
    • -2
    • +2
    ./tcl/attachments-procs.tcl
2:23 pm

hectorr

When the attachment is not in the file storage, consider both the possibilities of it being a 'content_item' or a 'content_revision', while trying to resolve its title in 'attachments::get_all_attachments' by looking directly in the content respository

Options
    • -5
    • +22
    ./tcl/attachments-procs.tcl
Tuesday 09 Jul 2019
8:30 pm

hectorr

Use 'item_id' instead of 'revision_id' for attachments

Options
    • -2
    • +2
    ./tcl/attachments-procs.tcl
7:42 pm

hectorr

Do not assume all attachments are in the file storage while retrieving their title/name

Options
    • -1
    • +8
    ./tcl/attachments-procs.tcl
Monday 01 Jul 2019
4:47 pm

hectorr

Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

Options
    • -2
    • +2
    ./www/attach.tcl
  2. … 41 more files in changeset.
Tuesday 25 Jun 2019
5:59 pm

hectorr

Whitespace changes

Options
    • -4
    • +2
    ./www/attach.tcl
5:55 pm

hectorr

Prettify data size using 'util::content_size_pretty'

Options
    • -1
    • +0
    ./catalog/attachments.ar_LB.utf-8.xml
    • -1
    • +0
    ./catalog/attachments.ast_ES.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.ca_ES.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.ch_zh.utf-8.xml
    • -1
    • +0
    ./catalog/attachments.da_DK.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.de_DE.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.el_GR.utf-8.xml
    • -1
    • +0
    ./catalog/attachments.en_AU.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.en_US.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.es_CO.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.es_ES.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.es_GT.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.eu_ES.ISO-8859-1.xml
    • -1
    • +0
    ./catalog/attachments.fi_FI.utf-8.xml
    • -1
    • +0
    ./catalog/attachments.fr_FR.ISO-8859-1.xml
  16. … 19 more files in changeset.
Friday 15 Mar 2019
9:59 am

gustafn

improve spelling

Options
    • -1
    • +1
    ./catalog/attachments.en_US.ISO-8859-1.xml
  2. … 4 more files in changeset.
Monday 11 Mar 2019
9:43 am

gustafn

improve spelling

Options
    • -4
    • +3
    ./www/doc/index.adp
  2. … 21 more files in changeset.