• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Applied Luke Pond's patch #173 which did some more form date widget fixing.

Applied Tilmann Singer's patch #124 which implements "<if @foo@>" as a

shorthand for the true check.

Added sequence to demo-create.sql. Applied Geoff Davis's patch #122 which

changes a call to ns_quotehtml to ad_quotehtml.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 71 more files in changeset.

Added a new proc "ad_return_exception_template" that allows you to return

templated error messages after a db error, etc.

added a function for converting a list of ns_sets (probably created with db_list_of_ns_sets) into a multirow datasource

HTML tags cleanup

New xql files as part of the demo fix.

    • -0
    • +12
    ./www/doc/demo/form.xql
    • -0
    • +21
    ./www/doc/demo/user-edit.xql

Fixed the 'Simple Form' and 'Editing: several pages in one' demos.

Run demo-drop and then demo-create scripts in Postgresql to take advantage

of this fix in a running system.

patch 140 applied

applied patches 130,131,132,133,134,135,137

  1. … 6 more files in changeset.

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

  1. … 13 more files in changeset.

I completed a first cut at the currency widget support procs, left incomplete

in ACS 4.2 Classic.

    • -0
    • +190
    ./tcl/currency-procs.tcl

Fixed the compare routine for real this time. I'd spaced earlier and forgot

that the "sql_date" property doesn't return a formatted SQL data but rather

a "to_char" function call ...

Date compare didn't work, does now.

just a bit of work

    • -45
    • +57
    ./www/doc/TclDocs/doc__util.html
    • -18
    • +0
    ./www/doc/TclDocs/namespace-list.html
    • -130
    • +0
    ./www/doc/TclDocs/namespaces.html
  1. … 5 more files in changeset.

Removed some log file noise (ns_log notice)

I fixed the currency datatype and did a little other mumbo-jumbo stuff. I

did this on another installation of OpenACS 4 (dotLRN, to tell the truth)

and just mass-copied the files over to make sure I didn't miss anything.

Not the best idea now that I think about it ...

Added new code from Walter.

bug fix

Oops - I mindlessly copied a patch posted by Stephen Deasy to one of the

openacs.org forums, which of course stripped out the backslash escapes,

causing the patch to bomb.

Grrr ...

Incorporated Stephen Deasy's patch to fix the "elseif" template tag.

Incorporated Bruno Mattarollo's HTML fixes (adding quotes to stuff, etc)

Removed two unused procs.

moved CMS stuff to CR so that content can be displayed by the search interface without requiring the user to load cms

  1. … 21 more files in changeset.
removed FILTER_ABORT code from template::forward as the RP doesn't support the catching of the FILTER_ABORT error as a control structure. Removal of the FILTER_ABORT code allows code to be executed after a template::forward command

  1. … 2 more files in changeset.
cleanup

changed result_name back to name as it has a hardwired dependency on the variable name that wasen't obvious to me when I changed it

ported dynamic queries

  1. … 14 more files in changeset.
files no lnger applicable