• last updated 10 hours ago
Constraints: committers
Constraints: files
Constraints: dates
improve code orthogonality: support "acs_object::get ... -element" similar to "party::get"; return dict from acs_object::get

add tests for "acs_object::get ... -element"; use "string equal" instead of "string match" (since the latter is semantically incorrect)

    • -19
    • +17
whitespace changes: break overlong lines

remove dependency of general-comments on acs-mail-lite

  1. … 3 more files in changeset.
Whitespace changes

  1. … 1 more file in changeset.
Avoid trailing whitespace on info file creation

move function db_current_rdbms to acs-bootstrap installer to improve code locality

  1. … 1 more file in changeset.
Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

  1. … 3 more files in changeset.
reduce usage of ad_arg_parser by using c-level implementation; fixes as well broken cases of bind-var handling

added test cases for db_0or1row and db_1row

whitespace changes

add test cases for db_list*

reduce verbosity

extended regression test: increase coverage of page contract filters

fix util::external_url_p when security::locations returns empty element

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

  1. … 5 more files in changeset.
added test case for db_string with various bind options

whitespace changes

move db-test case to db-regression test files

    • -181
    • +13
complete listing of covered procs in test cases

  1. … 7 more files in changeset.
Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

  1. … 3 more files in changeset.
mark private functions as private

  1. … 7 more files in changeset.
Flush also the threaded cache whenever we flush the permission cache, so that one does not need to call this private api directly

Do not invoke service contract implementations directly, use the public interface

provide a flushing interface to apm_package_id cache to avoid the need to call the uncached code directly

  1. … 1 more file in changeset.
Reinstate proc as private, remove dependency to such proc in external package

  1. … 2 more files in changeset.
make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

  1. … 2 more files in changeset.
Whitespace cleanup

Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test