• last updated 10 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fix for issue #3446

This fixes a bug, where the ordering of the site-nodes in the answer

set of the select_child_site_nodes query in site_node::update_cache

led to disappearing entries in the site map, when additional

items were added. This bug happened in the old-style

(nsv-based) site-node impementation, which is used, when no

xotcl is available.

Many thanks to Keith Paskett for debugging and the fix.

    • -16
    • +19
Rework of the 'test_apm_parameter__register' and 'test_apm_package_instance__new' test cases.

Ignored disabled packages in both tests.

Check all enabled packages in 'test_apm_package_instance__new', instead of picking just one randomly, so all issues instantiating packages are found at once.

Indentation changes.

Ignore singleton packages that are already instantiated on 'apm_package_instance_new', preventing the execution of the after-instantiate callbacks

Convert content of host header field to lower case, since domain names are case insensitive

Keep tolerating parameter_id specified as unnamed argument in legacy code and warn about deprecation

Adapt tests to the new behaviour of 'apm_parameter_unregister'

Do not add admin_node to the component bars if it is empty

Reduce error level to warning in the nullchat test case, as the issue is driver related

Allow in testing mode always a "form" tag, independent of the antispam parameter settings

This addresses an issue, when one is running the regression test for xowiki on installations

with plain dotlrn, where otherwise the validator complains about the form tag in a form.

There should be a nicer way of doing this...

allow calling apm_parameter_unregister without "parameter_id"

previously, it was allowed to call it with an empty parameter_id, but not without it

prefer db_0or1row for exists-queries

improve warning message in case invalid characters are passed in

mark unsued function "proc_source_file_full_path" as deprecated.

simplify code

Humanize indentation

Fix typo in library doc

don't rely on uppercase header field names

  1. … 9 more files in changeset.
whitespace changes

whitespace cleanup

provide better argument name

switch to simple new group::update call with dict as argument

This change fixes as well a bug in install::xml::action::set-join-policy

since group::get returns a member "text" which is not accepted by


  1. … 5 more files in changeset.
relax default samesite setting for login and session cookies to lax

This change was made because otherwise the "keep me logged in"

is often lost, e.g. also with toplevel navigation requests

(e.g. when navigating to the site via Google)

added "ad_conn bot_p" to check, whether request was initiated by a bot

This feature is based on a simple heuristic based on the user-agent

(which can be certainly extended). It is useful to avoid e.g. Google

bot to run into "notifications subscribe" + login attempts, which

are useful for not-logged-in user, but not for bots. These attemps

lead to failures in google statistics that might reduce the google

ranking of a web site.

  1. … 1 more file in changeset.
Whitespace changes

Deprecate 'f::lambda' in favor of tcllib implementation

fix broken support for explicit bindvars to db_foreach

use common "icanuse" idioms

Keep nsv variable "rp_properties request_count"

The nsv "rp_properties request_count" is still needed for bootstart loader.

Set it at the end of rp initialization

remove misleading comment. there should be no re-init

Whitespace cleanup