OpenACS / openacs-4 / packages

acs-subsite

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 79
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 49,839
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Dec 2018
7:20 pm

antoniop

Provide some basic way to create subgroups via the UI

Options
    • -2
    • +3
    ./www/admin/groups/one.adp
    • -2
    • +7
    ./www/admin/groups/one.tcl
Tuesday 11 Dec 2018
5:48 pm

antoniop

Actually store the group name in the UI by intercepting the right form var

Options
    • -2
    • +3
    ./www/admin/groups/new.tcl
5:23 pm

antoniop

Fix test test by considering that group pretty name is automatically localized

Options
    • -3
    • +10
    ./tcl/test/acs-subsite-procs.tcl
5:21 pm

antoniop

Don't quote some function defaults that are meant to be evaluated literally

Options
    • -7
    • +17
    ./tcl/plpgsql-utility-procs.tcl
3:35 pm

antoniop

New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

Options
    • -1
    • +53
    ./tcl/test/acs-subsite-procs.tcl
3:14 pm

antoniop

Move logics to delete a group type into the API

Options
    • -1
    • +34
    ./tcl/group-type-procs-oracle.xql
    • -1
    • +31
    ./tcl/group-type-procs-postgresql.xql
    • -1
    • +71
    ./tcl/group-type-procs.tcl
    • -79
    • +0
    ./www/admin/group-types/delete-2-oracle.xql
    • -85
    • +0
    ./www/admin/group-types/delete-2-postgresql.xql
    • -62
    • +6
    ./www/admin/group-types/delete-2.tcl
    • -14
    • +0
    ./www/admin/group-types/delete-2.xql
2:25 pm

antoniop

Fix quoting of group type

Options
    • -1
    • +1
    ./www/admin/group-types/delete-2-postgresql.xql
12:26 pm

antoniop

Remove unneeded variable

Options
    • -7
    • +1
    ./tcl/subsite-procs.tcl
12:20 pm

antoniop

Add (trivial) ad_include_contract

Options
    • -1
    • +5
    ./lib/subsites.tcl
12:16 pm

antoniop

Avoid unnecessary computations

Options
    • -1
    • +0
    ./lib/subsites-oracle.xql
    • -1
    • +0
    ./lib/subsites-postgresql.xql
    • -9
    • +10
    ./lib/subsites.tcl
Monday 10 Dec 2018
7:26 pm

antoniop

Reduce divergency between oracle and postgres codebase and bring portable sql inline

Options
    • -39
    • +0
    ./tcl/application-group-procs-oracle.xql
    • -41
    • +0
    ./tcl/application-group-procs-postgresql.xql
    • -6
    • +39
    ./tcl/application-group-procs.tcl
    • -33
    • +0
    ./tcl/application-group-procs.xql
5:31 pm

antoniop

Reuse return url over subsites, remove dummy sql

Options
    • -2
    • +3
    ./lib/subsites.tcl
5:27 pm

antoniop

Use best practice list idiom

Options
    • -1
    • +1
    ./lib/subsites.tcl
5:25 pm

antoniop

Avoid useless check

Options
    • -2
    • +1
    ./lib/subsites.tcl
Thursday 29 Nov 2018
11:01 am

antoniop

Use ad_include_contract for this include page

Options
    • -25
    • +29
    ./www/admin/groups/elements-by-rel-type.tcl
Wednesday 28 Nov 2018
6:33 pm

antoniop

Move remaining portable queries to tcl file

Options
    • -5
    • +26
    ./tcl/subsite-procs.tcl
    • -41
    • +0
    ./tcl/subsite-procs.xql
6:28 pm

antoniop

Remove obsolete partial query

Options
    • -6
    • +0
    ./tcl/subsite-procs.xql
6:20 pm

antoniop

Remove obsolete partial query: no reference was found in upstream code

Options
    • -6
    • +0
    ./tcl/subsite-procs-oracle.xql
    • -6
    • +0
    ./tcl/subsite-procs-postgresql.xql
6:01 pm

antoniop

Streamline retrieval of mapped host nodes

Options
    • -7
    • +0
    ./tcl/subsite-procs-oracle.xql
    • -8
    • +0
    ./tcl/subsite-procs-postgresql.xql
    • -5
    • +6
    ./tcl/subsite-procs.tcl
    • -11
    • +0
    ./tcl/subsite-procs.xql
5:47 pm

antoniop

Move query into tcl file

Options
    • -2
    • +5
    ./tcl/subsite-procs.tcl
    • -7
    • +0
    ./tcl/subsite-procs.xql
5:41 pm

antoniop

Avoid setting the whole array in the api and just return what we need

Options
    • -4
    • +2
    ./tcl/subsite-procs.tcl
5:37 pm

antoniop

Avoid asking for an array in the api

Options
    • -3
    • +3
    ./tcl/subsite-procs.tcl
5:31 pm

antoniop

Use api and portable idioms to reduce divergency between oracle and postgres codebase

Options
    • -13
    • +0
    ./tcl/subsite-procs-oracle.xql
    • -13
    • +0
    ./tcl/subsite-procs-postgresql.xql
    • -2
    • +7
    ./tcl/subsite-procs.tcl
5:02 pm

antoniop

Replace queries with api and already available information

Options
    • -9
    • +12
    ./tcl/subsite-procs.tcl
    • -25
    • +0
    ./tcl/subsite-procs.xql
4:55 pm

antoniop

Fix typos in query

Options
    • -3
    • +3
    ./www/admin/groups/elements-by-rel-type.tcl
2:29 pm

antoniop

Move some quoting in the api

Options
    • -1
    • +1
    ./www/admin/groups/elements-by-rel-type.adp
    • -3
    • +8
    ./www/admin/groups/elements-by-rel-type.tcl
2:23 pm

antoniop

Fix typo: new relation would be added always for the latest segment

Options
    • -1
    • +1
    ./www/admin/groups/elements-by-rel-type.adp
2:19 pm

antoniop

Replace stored procedures with inline queries and reduce divergency between oracle and postgres codebase

Options
    • -44
    • +0
    ./www/admin/groups/elements-by-rel-type-oracle.xql
    • -41
    • +0
    ./www/admin/groups/elements-by-rel-type-postgresql.xql
    • -2
    • +37
    ./www/admin/groups/elements-by-rel-type.tcl
1:01 pm

antoniop

Fix typos

Options
    • -2
    • +2
    ./www/admin/relations/one.adp
12:50 pm

antoniop

Recover include intended behavior:

this include was supposedly looking at subgroups of the provided group_id (clearly stated in the doc), while in fact scope was always forcefully set on package_id from the connection

Options
    • -5
    • +2
    ./www/admin/groups/elements-by-group-type.tcl