• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
postgress only query had broken tree (for oracle)

factored a few permissions functions so that i can use them elsewhere

    • -28
    • +0
    ./permissions/toggle-inherit-oracle.xql
    • -23
    • +0
    ./permissions/toggle-inherit-postgresql.xql
  1. … 5 more files in changeset.

Merged with OpenACS 4.5 beta1 branch.

    • -2
    • +2
    ./admin/group-types/change-join-policy.tcl
    • -2
    • +2
    ./admin/group-types/groups-display.tcl
    • -1
    • +1
    ./admin/group-types/one-postgresql.xql
    • -2
    • +2
    ./admin/group-types/rel-type-remove.tcl
    • -1
    • +1
    ./admin/groups/elements-by-rel-type.adp
  1. … 74 more files in changeset.

Applied Lars Pind's patch #179 - the PG version wasn't allowing one to

explicitly add members to a group.

Applied Lars Pind's patch #178, removing an extraneous "]" from the context

bar.

Applied Lars Pind's patch #175 - the header and trailer files were missing

and the Tcl file wasn't using the right path.

file 1pixel.footer was initially added on branch oacs-4-5.

    • binary
    ./shared/1pixel.footer
file 1pixel.tcl.rej was initially added on branch oacs-4-5.

    • -0
    • +0
    ./shared/1pixel.tcl.rej
file 1pixel.tcl.orig was initially added on branch oacs-4-5.

    • -0
    • +0
    ./shared/1pixel.tcl.orig
file 1pixel.header was initially added on branch oacs-4-5.

    • binary
    ./shared/1pixel.header

Applied CR Oldham's patch #152 which does a little HTML cleanup.

    • -1
    • +1
    ./admin/groups/elements-by-rel-type.adp

Applied Graeme Walters's patch #144 which allows existing persons to

upgrade themselves to users through the register pages.

Applied Russell Muetzelfeldt's patch #125 which fixed "needs approval" users.

Added Tilman Singer's patch #117 which changes some multirows to use the

built-in rownum value rather than needlessly select their own.

    • -1
    • +1
    ./admin/group-types/one-postgresql.xql

Applied Tilman Singer's patch #116 which corrects some context bar errors.

    • -2
    • +2
    ./admin/group-types/change-join-policy.tcl
    • -2
    • +2
    ./admin/group-types/groups-display.tcl
    • -2
    • +2
    ./admin/group-types/rel-type-remove.tcl
  1. … 7 more files in changeset.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 70 more files in changeset.

Added a simple database error template that can be used instead of

ad_return_complaint.

    • -0
    • +13
    ./shared/db-error.adp
patch 111 applied

patch 136 applied

yet another .tcl extension removal from links

  1. … 2 more files in changeset.
yet another .tcl extension removal from links

in index.tcl: changed unmounted.tcl to unmounted

applied patch 112, user-login will wrongly redirect registered users to the register page if they have upper case characters in their email address. This patch changes the query to do the authentication comparison case insensitively.

patches 141,142,143 by Gilbert Wong. Fixes broken awaiting-email-verification

    • -1
    • +1
    ./register/awaiting-email-verification-oracle.xql
    • -6
    • +7
    ./register/awaiting-email-verification-postgresql.xql
    • -3
    • +3
    ./register/awaiting-email-verification.tcl
applied patches 130,131,132,133,134,135,137

    • -4
    • +6
    ./register/awaiting-email-verification-postgresql.xql
  1. … 6 more files in changeset.

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

    • -0
    • +35
    ./shared/session-update.tcl
  1. … 13 more files in changeset.
parameterized url of community member page; changed some procs to use the parameter; changed some pages to use the procs instead of linking directly

  1. … 2 more files in changeset.

1. home.tcl - applied patch from SDM to use ad_pvt_home rather than a

fixed value.

2. defs-procs.tcl - applied patch that fixed a "link within a link" problem.

3. content_item.tree_sortkey had no index (gulp!)

  1. … 2 more files in changeset.

switched this to use "all_object_party_privilege_map" ...

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

  1. … 18 more files in changeset.