• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Added Tilman Singer's patch #117 which changes some multirows to use the

built-in rownum value rather than needlessly select their own.

    • -1
    • +1
    ./admin/group-types/one-postgresql.xql

Applied Tilman Singer's patch #116 which corrects some context bar errors.

    • -2
    • +2
    ./admin/group-types/change-join-policy.tcl
    • -2
    • +2
    ./admin/group-types/groups-display.tcl
    • -2
    • +2
    ./admin/group-types/rel-type-remove.tcl
  1. … 7 more files in changeset.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 70 more files in changeset.

Added a simple database error template that can be used instead of

ad_return_complaint.

    • -0
    • +13
    ./shared/db-error.adp
patch 111 applied

patch 136 applied

yet another .tcl extension removal from links

  1. … 2 more files in changeset.
yet another .tcl extension removal from links

in index.tcl: changed unmounted.tcl to unmounted

applied patch 112, user-login will wrongly redirect registered users to the register page if they have upper case characters in their email address. This patch changes the query to do the authentication comparison case insensitively.

patches 141,142,143 by Gilbert Wong. Fixes broken awaiting-email-verification

    • -1
    • +1
    ./register/awaiting-email-verification-oracle.xql
    • -6
    • +7
    ./register/awaiting-email-verification-postgresql.xql
    • -3
    • +3
    ./register/awaiting-email-verification.tcl
applied patches 130,131,132,133,134,135,137

    • -4
    • +6
    ./register/awaiting-email-verification-postgresql.xql
  1. … 6 more files in changeset.

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

    • -0
    • +35
    ./shared/session-update.tcl
  1. … 13 more files in changeset.
parameterized url of community member page; changed some procs to use the parameter; changed some pages to use the procs instead of linking directly

  1. … 2 more files in changeset.

1. home.tcl - applied patch from SDM to use ad_pvt_home rather than a

fixed value.

2. defs-procs.tcl - applied patch that fixed a "link within a link" problem.

3. content_item.tree_sortkey had no index (gulp!)

  1. … 2 more files in changeset.

switched this to use "all_object_party_privilege_map" ...

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

  1. … 18 more files in changeset.

Changed the representation of tree_sortkeys from "text" to "bit varying".

  1. … 62 more files in changeset.
Move "children_count" query from .xql to here.

Added oracle-specific "children_count" query which was in the .xql file

Removed PG-specific query from SQL92 file.

Switched tree-based queries to a tree-using form, which will greatly enhance

scalability...

    • -1
    • +1
    ./admin/group-types/index-postgresql.xql
    • -1
    • +1
    ./admin/group-types/new-postgresql.xql
    • -1
    • +1
    ./admin/group-types/one-postgresql.xql
    • -2
    • +1
    ./admin/groups/elements-display-list-postgresql.xql
    • -5
    • +5
    ./admin/groups/rel-type-add-postgresql.xql
    • -3
    • +5
    ./admin/rel-segments/new-postgresql.xql
    • -1
    • +1
    ./admin/rel-types/index-postgresql.xql
    • -2
    • +2
    ./admin/rel-types/new-2-postgresql.xql
  1. … 12 more files in changeset.

More permissions speeding up, or at least that is the theory...

    • -5
    • +7
    ./admin/rel-segments/constraints/index.xql

First round of speedups for verious permissions issues. Key finding is that

the all_object_party_privilege_map is speedy in PostgreSQL and apparently in

Oracle, as well (having re-read some of the optimization threads).

    • -4
    • +1
    ./admin/group-types/index-postgresql.xql
    • -4
    • +1
    ./admin/rel-segments/index-postgresql.xql
    • -0
    • +12
    ./admin/rel-segments/one-postgresql.xql
    • -0
    • +24
    ./admin/rel-types/delete-2-postgresql.xql
    • -5
    • +2
    ./admin/rel-types/rels-list-postgresql.xql
  1. … 12 more files in changeset.

1. Blank parameters were listed as being of "No Value", and when you hit

"set parameters" this string replaced the empty string in the database,

not exactly what you want. I changed the code to leave the input box

blank.

2. caching of empty parameter strings didn't work. I'd fixed this earlier

for ad_parameter proper but missed the fact that ad_parameter_cache had

the same bug.

With these changes you can now run acs-workflow's admin UI without graphviz

    • -8
    • +10
    ./admin/site-map/parameter-set-oracle.xql
  1. … 1 more file in changeset.
Make the site-map parameter-set page highlight parameters which have

been overridden by the ad.ini/nsd.tcl file (SDM patch #82)

    • -1
    • +1
    ./admin/site-map/parameter-set-oracle.xql
  1. … 1 more file in changeset.

Bunch of files I forgot to add to the last commit ...

    • -0
    • +14
    ./shared/portrait-bits.xql
  1. … 13 more files in changeset.

1. Added a new Tcl procedure to the content repository's library, named

cr_write_content, which properly writes content to the connection

regardless of RDBMS and storage type. This simplified a bunch of stuff

(which explains the removed files).

2. Fixed a lot of general comments issues regarding HTML vs. Plain/Text,

attachments, etc.

3. Partially ported glossary.

    • -1
    • +1
    ./user/portrait/upload-2-postgresql.xql
  1. … 80 more files in changeset.
Adds host-node-map patch

    • -0
    • +17
    ./admin/host-node-map/add.tcl
    • -0
    • +17
    ./admin/host-node-map/add.xql
    • -0
    • +16
    ./admin/host-node-map/delete.tcl
    • -0
    • +15
    ./admin/host-node-map/delete.xql
    • -0
    • +24
    ./admin/host-node-map/index-oracle.xql
    • -0
    • +25
    ./admin/host-node-map/index-postgresql.xql
    • -0
    • +73
    ./admin/host-node-map/index.tcl
    • -0
    • +14
    ./admin/host-node-map/index.xql
adds host-node-map patch