• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 467 more files in changeset.
image width information in table images seems flaky. since portrait-bits provides efficient

scaling, why not use it?

increase number of accepted sizes

make spelling more consitent

  1. … 2 more files in changeset.
add file-not-found .adp file

    • -0
    • +5
    ./shared/file-not-found.adp
Prefer '{}' to '[list]' when creating empty lists

  1. … 218 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 70 more files in changeset.
fix typos, regenerated documentation

    • -4
    • +5
    ./admin/groups/elements-by-group-type.tcl
    • -4
    • +5
    ./admin/groups/elements-by-rel-type.tcl
    • -4
    • +6
    ./doc/group-admin-pages-acceptance-test.adp
    • -5
    • +5
    ./doc/group-admin-pages-requirements.adp
  1. … 304 more files in changeset.
Rework variable assigning loops (set -> lassign)

  1. … 1 more file in changeset.
Fix typos

  1. … 31 more files in changeset.
remove conditions, which are always true

  1. … 6 more files in changeset.
remove conditions, which are always true

modernize Tcl

Use I18n messages for email and username

use canonical Tcl subcommand names

  1. … 7 more files in changeset.
remove $Id$ line

Use message key instead of hardcoded value

Fix typos

  1. … 17 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
Fix typos

  1. … 41 more files in changeset.
Fix even more typos

  1. … 29 more files in changeset.
Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

    • -22
    • +0
    ./user/portrait/upload-postgresql.xql
  1. … 12 more files in changeset.
provide templated error pages for subsite. without this, error pages for host-node-mapped subsites are a pain

CVS: ----------------------------------------------------------------------

  1. … 2 more files in changeset.
fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

strengthen page contracts

  1. … 12 more files in changeset.
fix typo

delete unneeded .xql files

    • -24
    • +0
    ./admin/groups/elements-by-group-type-oracle.xql
    • -24
    • +0
    ./admin/groups/elements-by-group-type-postgresql.xql
    • -22
    • +0
    ./admin/groups/elements-by-group-type.xql
    • -35
    • +0
    ./admin/groups/elements-by-rel-type-postgresql.xql
    • -15
    • +0
    ./admin/rel-types/roles/new-oracle.xql
    • -13
    • +0
    ./admin/rel-types/roles/new-postgresql.xql
  1. … 11 more files in changeset.
Use consistently ad_script_abort after ad_return_warning

  1. … 5 more files in changeset.
Use consistently ad_script_abort after ad_return_error.

Break long lines

    • -5
    • +11
    ./admin/applications/application-add.tcl
    • -3
    • +7
    ./admin/group-types/change-join-policy.tcl
    • -3
    • +5
    ./admin/group-types/rel-type-add-2.tcl
    • -4
    • +9
    ./admin/group-types/rel-type-remove.tcl
    • -6
    • +9
    ./admin/rel-segments/constraints/new.tcl
    • -3
    • +5
    ./admin/rel-segments/constraints/one.tcl
  1. … 10 more files in changeset.
add ad_script_abort after connection-closing commands to make termination intent explicit

  1. … 30 more files in changeset.