• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- fix lob interface (especially for portraits)

  1. … 5 more files in changeset.
- write sql statements between curly braces

  1. … 11 more files in changeset.
.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

  1. … 24 more files in changeset.
- improve portrait bits to provide cached scaling and caching

- fix old security hole, that allowed to download arbitrary files given a known item_id

  1. … 2 more files in changeset.
.xql overhaul:

- removed misleading sql-statements from db_* calls, which were

ignored due .xql files

- removed bug where same query name was used in a single proc

with different intended sql queries, but the same was picked

up from the .xql file due to the name

- removed multiple entries of same query name from .xql files

(e.g. the entry "package_create_attribute_list.select_type_info" was

7 (!!!) times in a single .xql file)

- removed redundant queries for unsupported versions of the dbms

- added missing xql entries for db-backends, where other db-specific

queries exists (e.g. added an entry to -oracle.xql, where an entry

existed in -postgres.xql)

  1. … 70 more files in changeset.
- prefer ns_quotehtml over ad_quotehtml

  1. … 36 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 740 more files in changeset.
- improve robustness against not-logged-in users

- remove globals for errorInfo and use namespace qualifiers instead

  1. … 5 more files in changeset.
- fix and standardize quoting in template properties

  1. … 391 more files in changeset.
- standardize url construction

  1. … 5 more files in changeset.
- fix validity of HTML

  1. … 7 more files in changeset.
- quote HTML attributes

- quote & in hrefs

  1. … 5 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2533 more files in changeset.
- check ids in page contracts

  1. … 36 more files in changeset.
- parameter page: make setting of context for instance and global parameter uniform

- provide link from package instance parameters page to global page in

case global parameters exist

- provide backlink when global parameters are called from /acs-admin/index.tcl

  1. … 1 more file in changeset.
- The C-library function tmpnam() is deprecated since a while. Therefore naviserver has deprecated ns_tmpnam as well.

Therefore we introduce a new function "ad_tmpnam" which requires just a minimal change and uses ns_mktemp.

  1. … 27 more files in changeset.
- don't return an "internal server error" on expected condition (user_id gone)

- don't return "internal server error" in case the user id is missing

- improve spacing

- remove deprecated call to ad_header

- use standard templating

- fix HTML

- remove call to deprecated ad_header

  1. … 1 more file in changeset.
- use property "doc(title)" throughout oacs-5-8 instead of "title" to get rid of warnings in error.log of the form:

Warning: /forums/message-view has no doc(title) set.

Using doc(title) is required in blank-master.tcl but was used so far only in a few packages

  1. … 330 more files in changeset.
- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

  1. … 120 more files in changeset.
- remove deprecated call ad_privacy_threshold

- replace deprecated command "ns_unlink" with native tcl command "file delete"

  1. … 7 more files in changeset.
changed ad_return_error to ad_return_exception_page 404 with same message, because error is not with system, but with request. This helps prevent bots from retrying when user no longer exists etc.

Improved the queries for global/instance params ...

1. First shot at sitewide admin ui for global parameters. You can edit them

from the sitewide admin page list that was previously built for packages

that have a sitewide-admin subdirectory. Package is now displayed for

either the existence of sitewide-admin or global parameters.

2. Did something I'd wanted to do for some time. When Nima added the

parameter_changed callback in acs subsite, he actually *moved* the

set_value call there. I've changed it so it more rationally sets the

value in the parameters page, then calls the parameter_changed callback.

3. Invented a global_parameter_changed callback that works as the regular

parameter_changed callback. This was necessary to avoid breaking existing

uses of parameter_changed.

More testing is required before release (which will hopefully happen

tomorrow, Sunday Apr 4).

  1. … 4 more files in changeset.