• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- improve readability and indentation

- align with openacs.org

- standardize argument passing to adp-includes, don't perform double i18n and double quoting

  1. … 124 more files in changeset.
- fix and standardize quoting in template properties

  1. … 394 more files in changeset.
- harden page contracts

  1. … 6 more files in changeset.
- quote HTML attribute values

  1. … 12 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2542 more files in changeset.
- use consistently "naturalnum" instead of "integer" when accepting just positive values

  1. … 13 more files in changeset.
- Don't use util_user_message to provide feedback for newly registered

users. util_user message is used for "ad_returnredirect ... -message",

which was used to report back to the user that some actions are required.

If RegistrationRequiresEmailVerificationP or

RegistrationRequiresApprovalP is set, a newly registered users is

logged out immediately after filling out the form. Therefore,

session_id is reset, and util_user_message (that depends on the

session_id) fails to deliver the content. We use now

"ad_return_warning" which does not have this problem.

- flatten nested list structures

  1. … 4 more files in changeset.
- fix syntax

- use compilable expressions

- use "in" operator instead of "lsearch"

- use tcl 8.5 extended index format for "string range"

- brace expressions to allow for tcl compilation

  1. … 6 more files in changeset.
- fix incorrect variable name "package_id" used instead of "subsite_id"

- make variable check explicit

- use property "doc(title)" throughout oacs-5-8 instead of "title" to get rid of warnings in error.log of the form:

Warning: /forums/message-view has no doc(title) set.

Using doc(title) is required in blank-master.tcl but was used so far only in a few packages

  1. … 336 more files in changeset.
- get rid of empty_string_p in non-deprecated code

- make use of tcl byte-code compiler

  1. … 42 more files in changeset.
Fix passing HTML in url variable and use util_user_message instead

  1. … 2 more files in changeset.
removing OpenGraph from default implementation, moving side-bar to ecommerce

  1. … 3 more files in changeset.
fixing to not serve social networking icons by default, when connected via https

adding packages/acs-subsite/lib/share-bar for share links example.

  1. … 1 more file in changeset.
Remove the change-locale link since it is now in the user basic info.

Add language and timezone to the user-info form

  1. … 1 more file in changeset.
Use the same vocabulary everywhere (in this case "biography" instead of "about you")

remove deprecated calls to ad_parameter

  1. … 5 more files in changeset.
Add new by default external URL checking to ad_returnredirect. Modify security::locations to be simpler, not rely on ecommerce at all, and use util_current_location to determine the host name.

  1. … 2 more files in changeset.
TIP#126 optionally allow user to provide email, first, last name when authority does not

  1. … 5 more files in changeset.
removing diagnostic ns_logs I added by mistake, and adding case of possible third 3 variant to locations (when behind reverse proxy)

  1. … 1 more file in changeset.
fixing faulty wrong domain message by using a reliable ecommerce method to determine locations, creating security::locations

  1. … 1 more file in changeset.
Fix return_url checking on login page to respect host node mapping and allow return_url to switch http/https for the same host name

Changed admin checks to check against ad_conn subsite_id, not package_id, so

that these work correctly when included from a package other than acs-subsite.

Such as within a portlet/includelet ...

Merged from 5.4.2

  1. … 282 more files in changeset.