OpenACS / openacs-4 / packages

acs-authentication

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 38
Last Commit: 28 Dec
Commits this week: 0
Total Lines of Code (LoC): 13,240
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 02 Aug 2018
11:29 am

gustafn

use public interface instead of private one

Options
    • -2
    • +2
    ./tcl/test/acs-authentication-procs.tcl
Friday 27 Jul 2018
11:16 am

antoniop

Provide an ad_include_contract for the page (fixes files__page_contracts)

Options
    • -46
    • +55
    ./lib/local-search.tcl
10:54 am

antoniop

Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

Options
    • -0
    • +1
    ./lib/local-search.adp
    • -0
    • +79
    ./lib/local-search.tcl
    • -0
    • +106
    ./lib/search.adp
    • -0
    • +155
    ./lib/search.tcl
  5. … 1 more file in changeset.
10:43 am

antoniop

Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

Options
    • -1
    • +0
    ./lib/local-search.adp
    • -79
    • +0
    ./lib/local-search.tcl
    • -106
    • +0
    ./lib/search.adp
    • -155
    • +0
    ./lib/search.tcl
  5. … 1 more file in changeset.
Thursday 26 Jul 2018
6:23 pm

antoniop

Trim whitespaces

Options
    • -8
    • +8
    ./lib/search.adp
6:22 pm

antoniop

Indentation change

Options
    • -3
    • +13
    ./lib/search.adp
Wednesday 25 Jul 2018
8:27 pm

hectorr

Harmonize parameter names in proc documentation removing unexistent ones

Options
    • -3
    • +1
    ./tcl/authority-procs.tcl
Monday 23 Jul 2018
8:31 pm

gustafn

handle authorizations with no auth_sync_process defined without raising an error in the error.log

Options
    • -28
    • +8
    ./tcl/sync-procs.tcl
Friday 20 Jul 2018
3:39 pm

antoniop

Remove ns_parseurl from list of tested procs, as not being a openacs proc will trigger an error at load time

Options
    • -2
    • +1
    ./tcl/test/sync-test-procs.tcl
3:38 pm

antoniop

Test also the portrait api (exploit the fact that we are already creating bogus users), move helper procs to the beginning so they can be found by the testing machinery

Options
    • -28
    • +53
    ./tcl/test/acs-authentication-procs.tcl
3:01 pm

antoniop

Trim whitespace

Options
    • -64
    • +64
    ./tcl/test/acs-authentication-procs.tcl
Thursday 19 Jul 2018
2:15 pm

gustafn

improve testcases by removing useless expr commands

Options
    • -19
    • +19
    ./tcl/test/acs-authentication-procs.tcl
    • -21
    • +21
    ./tcl/test/sync-test-procs.tcl
  3. … 16 more files in changeset.
1:46 pm

gustafn

make tested procs explicit

Options
    • -10
    • +101
    ./tcl/test/acs-authentication-procs.tcl
    • -15
    • +94
    ./tcl/test/sync-test-procs.tcl
  3. … 1 more file in changeset.
Tuesday 17 Jul 2018
8:30 pm

gustafn

improve rowcount expressions

Options
    • -1
    • +1
    ./lib/search.adp
  2. … 76 more files in changeset.
Wednesday 11 Jul 2018
11:57 pm

hectorr

Fix typos

Options
    • -2
    • +2
    ./www/doc/ext-auth-ldap-install.adp
    • -1
    • +1
    ./www/doc/ext-auth-ldap-install.html
  3. … 10 more files in changeset.
12:37 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/local-procs.tcl
  2. … 12 more files in changeset.
Saturday 07 Jul 2018
4:26 pm

antoniop

Fix test on system having 0.0.0.0 as IPv4 address in the config file

Options
    • -2
    • +15
    ./tcl/test/sync-test-procs.tcl
Sunday 01 Jul 2018
12:04 am

hectorr

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @parameter -> @param

- @params -> @param

- Add missing @param

- @cvs -> @cvs-id

- @version -> @cvs-id

Options
    • -3
    • +3
    ./tcl/authentication-procs.tcl
  2. … 12 more files in changeset.
Friday 29 Jun 2018
7:27 pm

hectorr

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

Options
    • -1
    • +1
    ./tcl/authentication-procs-aolserver.tcl
    • -1
    • +1
    ./tcl/authentication-procs-naviserver.tcl
  3. … 367 more files in changeset.
Thursday 28 Jun 2018
5:44 pm

antoniop

Apply new api where appropriate

Options
    • -26
    • +25
    ./tcl/password-procs.tcl
4:20 pm

antoniop

Exploit new api where appropriate

Options
    • -6
    • +11
    ./tcl/local-procs.tcl
4:10 pm

antoniop

Apply new user api when appropriate

Options
    • -28
    • +33
    ./tcl/authentication-procs.tcl
3:42 pm

antoniop

Rework of this tests

- use dict idioms instead of array, so we don't have to unset all the time

- use new user api when appropriate

- fix test when we try to reuse the username of somebody who was previously banned.

This is no longer possible and is now reflected in the test

Options
    • -82
    • +82
    ./tcl/test/sync-test-procs.tcl
Friday 22 Jun 2018
12:46 pm

hectorr

Update es_ES translation

Options
    • -0
    • +1
    ./catalog/acs-authentication.es_ES.ISO-8859-1.xml
  2. … 3 more files in changeset.
10:33 am

antoniop

Fix typo and add missing italian translation

Options
    • -1
    • +1
    ./catalog/acs-authentication.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-authentication.it_IT.ISO-8859-1.xml
Friday 15 Jun 2018
1:38 am

hectorr

Fix typos

Options
    • -4
    • +4
    ./tcl/authentication-procs.tcl
  2. … 1 more file in changeset.
12:27 am

hectorr

Fix wording

Options
    • -3
    • +3
    ./tcl/sync-procs.tcl
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./lib/local-search.tcl
    • -1
    • +1
    ./tcl/authentication-procs-aolserver.tcl
    • -1
    • +1
    ./tcl/authentication-procs-naviserver.tcl
    • -3
    • +3
    ./tcl/driver-procs.tcl
    • -3
    • +3
    ./tcl/local-procs.tcl
    • -2
    • +2
    ./tcl/sync-procs.tcl
    • -2
    • +2
    ./tcl/test/acs-authentication-procs.tcl
  8. … 469 more files in changeset.
12:37 am

hectorr

Rework variable assigning loops (set -> lassign) + Whitespace changes

Options
    • -2
    • +1
    ./lib/local-search.tcl
  2. … 13 more files in changeset.
Tuesday 01 May 2018
9:16 am

gustafn

simplify weird construction

Options
    • -3
    • +3
    ./tcl/authentication-procs.tcl