OpenACS / openacs-4 / packages / acs-admin

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 44
Last Commit: 16:34
Commits this week: 0
Total Lines of Code (LoC): 12,326
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 09 Mar 2002
3:00 am

donb

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

Options
    • -3
    • +0
    ./users/become.tcl
    • -2
    • +2
    ./users/complex-search.tcl
    • -4
    • +4
    ./users/search.tcl
    • -3
    • +2
    ./users/user-add-2.tcl
    • -19
    • +1
    ./users/user-add-2.xql
  6. … 70 more files in changeset.
Wednesday 06 Mar 2002
1:06 am

yon

if there is a return_url use it before the email page is presented, maybe the programmer wants this behaviour

Options
    • -0
    • +3
    ./users/member-state-change.tcl
Saturday 23 Feb 2002
3:43 am

donb

Added C. R. Oldham's patch to fix membership testing (unimplemented in ACS

4.2). Ported it to PG on the way ...

Options
    • -2
    • +2
    ./apm/parameter-add-2.xql
  2. … 9 more files in changeset.
Thursday 21 Feb 2002
6:13 pm

neophytosd

patch 157 applied

Options
    • -0
    • +24
    ./users/one.adp
    • -2
    • +28
    ./users/one.tcl
    • -1
    • +24
    ./users/one.xql
Monday 18 Feb 2002
11:02 pm

ben

fixed up uniqueness of package_key

Options
    • -2
    • +3
    ./apm/parameter-add-2.tcl
Sunday 17 Feb 2002
6:04 pm

neophytosd

yet another .tcl extension removal from links

Options
    • -2
    • +2
    ./apm/package-add.tcl
    • -2
    • +2
    ./apm/package-delete.tcl
  3. … 1 more file in changeset.
Friday 15 Feb 2002
7:53 pm

neophytosd

removed .tcl extension from redirects

Options
    • -2
    • +2
    ./apm/packages-install-2.tcl
    • -3
    • +3
    ./apm/packages-install-3.tcl
3:01 am

neophytosd

fixed some unported queries from the old code, scary!!!

Options
    • -1
    • +13
    ./users/member-state-change-postgresql.xql
2:41 am

neophytosd

applied patches 145,146,148, ignore patch 147. Patches by Gilbert Wonf. Fixes problems with email verification

Options
    • -1
    • +1
    ./users/member-state-change-oracle.xql
    • -6
    • +10
    ./users/member-state-change-postgresql.xql
    • -2
    • +2
    ./users/member-state-change.tcl
Wednesday 13 Feb 2002
6:41 pm

yon

cleaned up and fixed some bugs

Options
    • -49
    • +0
    ./users/member-state-change-postgresql.xql
    • -38
    • +25
    ./users/member-state-change.tcl
  3. … 2 more files in changeset.
Saturday 12 Jan 2002
11:31 am

yon

added referer variable so that i can use this code as a plug-in

Options
    • -2
    • +3
    ./users/user-add-2.adp
    • -2
    • +3
    ./users/user-add-2.tcl
    • -1
    • +1
    ./users/user-add-3.adp
    • -3
    • +4
    ./users/user-add-3.tcl
    • -0
    • +1
    ./users/user-add.adp
    • -3
    • +5
    ./users/user-add.tcl
Saturday 29 Dec 2001
2:48 am

donb

Fixed the 4K character limit on session properties for Oracle by making an

optional "clob" value available. The APM wouldn't let me load any packages

when I added all the dotLRN packages plus standard packages over to a new

"dotlrn" user from my normal "acs" user - the list of packages grew to

> 4KB in size! Grrrr!

Options
    • -5
    • +5
    ./apm/packages-install-2.tcl
    • -2
    • +4
    ./apm/packages-install.tcl
  3. … 5 more files in changeset.
Saturday 01 Dec 2001
4:41 pm

donb

After importing openacs.org users, forums and messages I discovered that it

took literally several minutes to load the APM's home page. This was due

to a rather stupid subselect of the form:

select count(*)

from content_revisions r

where r.revision_id = content_item.get_latest_revision(item_id)

where item_id comes from the package versions table.

It's stupid in both PG and Oracle because get_latest_revision already

joins the latest_revision_id value from cr_items with the content

revisions table thus a simple check for a null return by get_latest_revision

would be sufficient.

It's *really* stupid in Oracle because Oracle won't use the index on

revision_id when checking NULLs so we get two sequential scans of the

cr_revisions table tucked into that one itty-bitty subquery (itself called

once for each package version in ths system).

Which explains why I hadn't noticed it while working on scalability testing

in PG - PG uses the index because its btree index structure handles NULLs.

Meaning this query only fell apart at a rate of O(log2(R)) rather than O(R)

as in Oracle (R being the number of revision objects in the system).

My solution was to rewrite the subselect using "case" rather than "count(*)"

and also to speed up get_latest_revision by having it check for NULL and

return NULL immediately rather than execute the query (in PG this is

accomplished by declaring the function "isstrict", and the executor won't

even call the function if the argument's NULL, making it REALLY fast!).

Options
    • -3
    • +5
    ./apm/index-oracle.xql
    • -3
    • +5
    ./apm/index-postgresql.xql
  3. … 2 more files in changeset.
Monday 19 Nov 2001
8:34 pm

donb

1. Modified the Javascript "check/uncheck all boxes" code in the APM

package install page so that it still works if javascript's disabled.

2. Slight rewrite of a view in bboard.

3. Skin works in OpenACS Oracle/PG - changed info file to reflect this.

4. Added clean error handling to wimpy point attachment upload page.

Options
    • -4
    • +6
    ./apm/packages-install.tcl
  2. … 3 more files in changeset.
Saturday 17 Nov 2001
12:17 pm

stevew

Implement check/uncheck all with Javascript (SDM patch #86)

Options
    • -7
    • +14
    ./apm/packages-install.tcl
11:37 am

stevew

Add ad_return_top_of_page to pages which start with an ns_write to

make sure HTTP headers get returned

Options
    • -2
    • +2
    ./apm/package-load-2.tcl
    • -3
    • +2
    ./apm/packages-install.tcl
    • -4
    • +3
    ./apm/write-all-specs.tcl
Thursday 18 Oct 2001
11:06 pm

donb

Bootstrap installer was installing packages that don't work with the

current RDBMS (search vs. Oracle in particular)

Options
    • -2
    • +1
    ./apm/packages-install.tcl
  2. … 2 more files in changeset.
Thursday 04 Oct 2001
1:35 am

donb

1. Fixed APM bug - updating a package failed due to an unported query.

2. Updated the version number for version control.

Options
    • -0
    • +15
    ./apm/packages-install-3-oracle.xql
    • -0
    • +15
    ./apm/packages-install-3-postgresql.xql
    • -15
    • +0
    ./apm/packages-install-3.xql
  4. … 2 more files in changeset.
Friday 21 Sep 2001
12:44 am

donb

Fixed a couple of minor problems:

1. A typo in version-edit-2 that didn't really impact anything

2. A "triggered data change" error caused by apm-create.sql

3. restore-user flat-out didn't work and aD had never tested it

Options
    • -3
    • +2
    ./apm/version-edit-2.tcl
  2. … 2 more files in changeset.
Sunday 16 Sep 2001
3:34 pm

donb

Fixed db_blob_get for PG, and got rid of db_continue_transaction, which we

can no longer support because PG automatically aborts a transaction after an

error.

Options
    • -15
    • +1
    ./tests/db-api-acceptance-test.tcl
  2. … 4 more files in changeset.
Monday 03 Sep 2001
8:40 pm

donb

*** empty log message ***

Options
    • -1
    • +2
    ./apm/packages-install.tcl
  2. … 4 more files in changeset.
Wednesday 29 Aug 2001
11:22 pm

donb

A bunch of "ACS"->"OpenACS" and similar changes

Options
    • -8
    • +8
    ./apm/package-add.tcl
    • -5
    • +5
    ./tests/tcl-documentation.tcl
  3. … 27 more files in changeset.
1:51 am

donb

Started on address book, still a lot of work to do.

made minor improvements to "packages-install" in the APM.

Options
    • -24
    • +42
    ./apm/packages-install.tcl
  2. … 15 more files in changeset.
Sunday 19 Aug 2001
11:26 pm

donb

1. Fixed a bug in the oracle version of acs-mail-nt-create.sql

2. Fixed a bug in the oracle version of the APM - a standard SQL92

left join was being executed rather than the nasty Oracle-specific

notation.

3. Futzed with the APM a bit - you can now only set "watch" commands on

those .xql files which are used by the current installation, you can

only install packages supported by the current installation's RDBMS.

Options
    • -8
    • +10
    ./apm/packages-install.tcl
    • -2
    • +2
    ./apm/version-files.tcl
  3. … 7 more files in changeset.
Sunday 12 Aug 2001
5:19 pm

donb

Oops - Vinod caught the fact that only the standard SQL92 version of the

query "apm_all_files" existed in a query file ...

Options
    • -0
    • +17
    ./apm/version-files-oracle.xql
Tuesday 29 May 2001
3:46 am

donb

1. Fixed a couple of .info files

2. Got rid of Ben's hack to always reload query files before doing a query

mapping. He did this so you wouldn't have to reboot AOLserver every

time you change query files. It was a short-term hack but unfortunately

it looped virgin installs.

3. Added code to the APM to make the "watch" feature work with query files

as well as library files. This makes Ben's hack mentioned above

unnecessary.

Options
    • -4
    • +4
    ./apm/index.tcl
    • -2
    • +2
    ./apm/version-files.tcl
  3. … 7 more files in changeset.
Sunday 13 May 2001
4:30 pm

donb

Built two query snippets using "db_map". They weren't db specific so we

now have a generic index.xql file...

Options
    • -0
    • +16
    ./apm/index.xql
6:41 am

danw

catchall

Options
    • -0
    • +1
    ./users/complex-search-postgresql.xql
  2. … 2 more files in changeset.
3:53 am

donb

Added calls to Dan's new "db_map" routine to make db-specific queries in

the apm index page work.

Options
    • -1
    • +11
    ./apm/index-oracle.xql
    • -0
    • +10
    ./apm/index-postgresql.xql
    • -9
    • +4
    ./apm/index.tcl
Saturday 12 May 2001
7:09 am

danw

cleaned up content repository data-model and converted oracle apm to use file storage in the content repository

Options
    • -3
    • +4
    ./apm/packages/index-postgresql.xql
  2. … 11 more files in changeset.