OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 09:48
Commits this week: 5
Total Lines of Code (LoC): 7,563,598
Net change in LoC this week: -7

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Aug
8:31 am

gustafn

new function: ad_unless_script_abort and bump version to 5.10.1b12

This convenience function eases handling of ad_script_abort exceptions

in cases, where the OpenACS request processor is not involved.

From the documentation:

Execute the provided body in the callers' environment. When the

body does not raise an "ad_script_abort" exception, the

"non_abort_action" is also executed. This pattern is useful when

handling client requests and where the "non_abort_action" is used

to return results to the client. When "ad_script_abort" is

executed, the connection is usually closed, and any attempt to

talk to the client over the closed connection will fail.

The handling of script_abort exceptions is done usually in the

request processor. The function is useful when registering own

request procs (e.g., via "ns_register_proc") where the OpenACS

request processor is not involved.

bumped version to 5.10.1b12

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +35
    /openacs-4/packages/acs-tcl/tcl/exception-procs.tcl
Tuesday 27 Aug
8:08 pm

gustafn

handle script abort in proc handler

Options
    • -8
    • +19
    /openacs-4/packages/notifications/tcl/test/notifications-test-procs.tcl
7:26 pm

gustafn

include warnings and bugs in summary line

Options
    • -2
    • +6
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
7:24 pm

gustafn

take out "nsstats" from the tests for page_contracts

Options
    • -5
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl
    • -49
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/log-test-procs.tcl
4:50 pm

gustafn

fixed race condition and silence regression test

Options
    • -16
    • +26
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
4:27 pm

gustafn

silence expected errors during regression test

Options
    • -10
    • +16
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
4:06 pm

gustafn

silence regression test

Options
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
3:56 pm

gustafn

promote warning message from ns_log to ad_log

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
3:55 pm

gustafn

reduce verbosity during regression test

Options
    • -1
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -6
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/ad-proc-test-procs.tcl
3:54 pm

gustafn

reduce verbosity

Options
    • -3
    • +6
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
3:37 pm

gustafn

do not complain about expected behavior

Options
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
3:22 pm

gustafn

silence regression test

Options
    • -5
    • +32
    /openacs-4/packages/acs-tcl/tcl/test/ad-proc-test-procs.tcl
    • -4
    • +9
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
3:21 pm

gustafn

don't expect that invalid input becomes magically valid

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
3:20 pm

gustafn

reduce verbosity

Options
    • -18
    • +1
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
3:16 pm

gustafn

use for includelets and web-callable parameters @query_param instead of @param

Options
    • -5
    • +5
    /openacs-4/packages/xowf/tcl/xowf-includelet-procs.tcl
    • -110
    • +112
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
3:01 pm

gustafn

align nameing with 'resource_info_procs'

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/richtext-tinymce/tcl/richtext-init.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
2:14 pm

gustafn

silence test cases

Options
    • -2
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:13 pm

gustafn

claim test coverage

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/apm-file-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
2:12 pm

gustafn

fixed old bug via regression test in page contract filters

The binding variable for "min_length" and others was not passed correctly.

We saw unexpected warning of the following form during regression test:

Warning: Message contains a variable named 'min_length' which doesn't exist in the caller's environment:

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
1:29 pm

gustafn

handle cases in the page contract, when not connected (used this way in the regression test)

Options
    • -5
    • +9
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
1:27 pm

gustafn

keep log file viewable (don't add too many entries)

Options
    • -2
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl
1:24 pm

gustafn

remove leftover files after run, silence regression test run

Options
    • -4
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/defs-procs.tcl
12:52 pm

gustafn

whitespace changes

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-includelet-procs.tcl
    • -4
    • +1
    /openacs-4/packages/xowiki/lib/view.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowiki/www/sitewide-admin/download.tcl
12:06 pm

gustafn

whitespace changes

Options
    • -73
    • +73
    /openacs-4/packages/acs-tcl/tcl/aolserver-3-procs.tcl
    • -17
    • +16
    /openacs-4/packages/acs-tcl/tcl/user-extensions-procs.tcl
    • -974
    • +974
    /openacs-4/packages/acs-tcl/tcl/xml-1-dom-procs.tcl
    • -69
    • +69
    /openacs-4/packages/acs-tcl/tcl/xml-2-procs.tcl
    • -52
    • +52
    /openacs-4/packages/acs-tcl/tcl/tcltrace-procs.tcl
    • -10
    • +10
    /openacs-4/packages/acs-tcl/tcl/tdom-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/06-param-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/cluster-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/generic-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/test/context-test-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/www/show-class-graph.tcl
12:06 pm

gustafn

silence test cases

Options
    • -3
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
11:52 am

gustafn

removed progress bar from curl output

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
11:21 am

gustafn

wget is not used anymore

Options
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
11:20 am

gustafn

silence regression test run

Options
    • -36
    • +59
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:49 am

gustafn

provide proper HTML syntax for test cases

https://html.spec.whatwg.org/dev/syntax.html#syntax-attributes

Options
    • -4
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
10:32 am

gustafn

use own Package initialize for safety (in case it was extended locally)

Options
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/xowf-callback-procs.tcl