OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 146
Last Commit: 25 Nov
Commits this week: 14
Total Lines of Code (LoC): 7,560,967
Net change in LoC this week: 146

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 08 Aug
4:30 pm

gustafn

Fixed issue in cluster mode, denoted by Khy H in the OpenACS forum

A new command "ad_parameter_cache_flush_dict" was introduced to handle

the case, where a cluster node modifies a parameter value without

having it read before. This case could lead to a coherency problem for

parameter values.

Background:

This proc is necessary in cases, where a node writes a new

parameter value before it has read the old one.

Since a plain "nsv_dict unset ad_param $key $parameter_name"

raises an exception, when the pair does not exist, and we do

not want to allow in cluster requests arbitrary "catch"

commands, we allow "ad_parameter_cache_flush_dict" instead.

Probably, the best solution is to add support for

nsv_dict unset -nocomplain -- ad_param $key $parameter_nam

The existing nsv_dict was built after Tcl's "dict unset",

which does not have the "-nocomplain" option either. However,

an atomic operation would certainly be preferable over an exists/unset

pair, which is no acceptable solution.

For details, see https://openacs.org/forums/message-view?message_id=5822470

Options
    • -4
    • +5
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
    • -4
    • +29
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
2:56 pm

gustafn

use generic mount icon in site map

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
2:55 pm

gustafn

added generic icon for "mount" operations

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -1
    • +6
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
2:19 pm

gustafn

added after-mount callback to restrict default permissions

- Modify default permissions after mount to restrict read access to

the package from public read to read access for registered users.

- The change affects only fresh installed, existing permission settings

are not touched.

- fixed typos

- bumped version number to 5.10.1b3

Options
    • -2
    • +4
    /openacs-4/packages/acs-lang/acs-lang.info
    • -1
    • +1
    /openacs-4/packages/acs-lang/bin/functions.sh
    • -1
    • +25
    /openacs-4/packages/acs-lang/tcl/apm-callback-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/tcl/test/lang-widget-procs.tcl
Wednesday 07 Aug
5:39 pm

gustafn

provide posture overview for widely-accessible-packages when count == 1

Options
    • -0
    • +51
    /openacs-4/packages/acs-admin/tcl/acs-admin-procs.tcl
    • -43
    • +13
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
    • -5
    • +13
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.adp
    • -6
    • +24
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.tcl
5:36 pm

mischa

Fix documentation for group::update.

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/group-procs.tcl
4:24 pm

gustafn

provide icon and title for managing service parameters

Options
    • -2
    • +5
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
4:23 pm

gustafn

perform proper cleanup after regressin test

Options
    • -4
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
3:57 pm

gustafn

use a different icon for mounting, reduced verbosity

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
3:56 pm

gustafn

xotcl-request-monitor Change site-node permissions after mount

This package might reveal internal information and should

not be public available per default.

bumped version number to 0.66

Options
    • -3
    • +4
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -1
    • +21
    /openacs-4/packages/xotcl-request-monitor/tcl/callback-procs.tcl
3:51 pm

gustafn

require login for version numbers, since this reveals internal information

Options
    • -0
    • +2
    /openacs-4/packages/xotcl-core/www/version-numbers.tcl
3:50 pm

gustafn

added test for xotcl/version-numbers

Options
    • -0
    • +1
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
3:03 pm

gustafn

Added state of "robots.txt" and "security.txt" to posture overview

Options
    • -0
    • +20
    /openacs-4/packages/acs-admin/www/posture-overview.adp
    • -3
    • +43
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
11:56 am

gustafn

Prettify subsite admin page

- Made explicit that "Administration" means "Subsite Administration"

(use the term consistently)

- Changed message key of acs-subsite.administration to "Subsite Administration"

- added icons to subsite admin index page (full set only for bootstrap icons)

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/subsites.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
    • -8
    • +8
    /openacs-4/packages/acs-subsite/www/admin/index.adp
    • -6
    • +7
    /openacs-4/packages/acs-subsite/www/admin/index.tcl
    • -7
    • +16
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
11:54 am

gustafn

Removed useless and hard to track ad_log messages in the forums:

Cannot determine package_id. Returning 0

Options
    • -11
    • +18
    /openacs-4/packages/forums/tcl/messages-procs.tcl
11:34 am

gustafn

use tag <i> for technical terms as on other places

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/lib/check-installed.adp
11:25 am

gustafn

increased timeout for checking requests on own site

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
Tuesday 06 Aug
7:25 pm

gustafn

fix over-eager renaming

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
7:17 pm

gustafn

delete global package parameter as for all other javascript libraries

Make managing of version numbers consistent.

For details, see: https://openacs.org/xowiki/external-javascript-packages

Options
    • -9
    • +2
    /openacs-4/packages/cookie-consent/cookie-consent.info
    • -3
    • +2
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
4:36 pm

gustafn

fixed package_id in ADP page

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/posture-overview.adp
3:57 pm

gustafn

improved PostgreSQL version compatibility

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.tcl
3:51 pm

gustafn

fixed URLs

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.tcl
3:41 pm

gustafn

New pages for admins: Security and Privacy Posture Overview

As expressed as a wish from OpenACS users at the last OpenACS

conference, a "Security and Privacy Posture Overview" was added that

offers a quick overview of the state of the system and eases access to

the parameters scattered over different packages in the system.

The page offers:

- Quick overview

- Check of security and privacy relevant package parameters

- Permission and accessibility check of mounted packages

- Response header check

- External library check (CDN vs local usage, vulnerable or outdated libraries)

TODO: One should probably reconsider the permissions of some of the standard site nodes

(similar to what we did with the API browser some time ago).

Options
    • -0
    • +164
    /openacs-4/packages/acs-admin/www/posture-overview.adp
    • -0
    • +364
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
    • -0
    • +81
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.adp
    • -0
    • +170
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.tcl
3:41 pm

gustafn

file posture-overview.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-admin/www/posture-overview.adp
3:41 pm

gustafn

file widely-accessible-packages.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.tcl
3:41 pm

gustafn

file widely-accessible-packages.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-admin/www/widely-accessible-packages.adp
3:41 pm

gustafn

file posture-overview.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-admin/www/posture-overview.tcl
12:16 pm

gustafn

reduce verbosity in the system log

Options
    • -1
    • +12
    /openacs-4/packages/forums/tcl/forums-procs.tcl
11:43 am

gustafn

spell "site-wide" consistently with a dash

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/lib/site-wide-services.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/i18n-requirements.adp
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/object-system-requirements.adp
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/kernel/apm-design.xml
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/kernel/i18n-requirements.xml
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/xml/kernel/object-system-req.xml
    • -6
    • +6
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/doc/i18n-design.adp
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/doc/i18n-requirements.adp
    • -3
    • +3
    /openacs-4/packages/acs-messaging/www/doc/requirements.adp
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
  16. … 20 more files in changeset.
10:38 am

gustafn

improved the site-wide admin pages for external ja libraries

- add a sample for pinning the version number via the NaviServer configuration file

- privide a link to the requirements and background page explaining the implemented policies

Options
    • -4
    • +18
    /openacs-4/packages/acs-tcl/lib/check-installed.adp