• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed a broken oracle query

acs_user::flush_cache didn't flush the get_by_username memoized call, causing

problems if you deleted a user then tried to recreate the same user, because

the auth validate data (for a user) code uses this proc.

Removed the old test case #3 (and renumbered the remaining ones). The test

checked that updating the cache without sync'ing the children didn't change

the results returned by the get procedure. However the lazy caching code by

Malte changed the semantics of get to automatically load the cache with

children if you try to get the node_id of a node with kids. This is a good

thing, actually, since the update cache w/o sync'ing kids exists to make the

cache update quick. But it did break the test checking explicitly for the old

semantics.

It would be nice, however, if people, after writing new code and noticing that

tests break, would actually sit down and determine if the test or code is wrong

and take appropriate action.

Because I just spent two full hours tracking this down and verifying that the

new semantics invalidate the old test code in a reasonable way, and I'm not the

author of the new code.

Added doc bodies where missing.

Added an explicit blank body to two callbacks added by Malte, so automated

tests will pass. This is about the third release in which I've had to do

this. Simply adding "-" after the empty doc comment block is sufficient,

ad_proc treats that as an empty body.

BSD "which" doesn't return -1 if no path for the given binary exists, therefore

"catch" didn't, therefore (sigh) "bin" was always set to aspell whether or not

it exists. Same result as the error I fixed long ago with this init file (see

comments) but for a different reason!

Remove RTE files

  1. … 26 more files in changeset.
Remove support for RTE.

Running these test twice would lead to errors, due to test users not being

deleted. The tear-down stuff knows how to rollback the database, but caching

is a bit beyond its automated capability at the moment.

support for tag microformat

    • -2
    • +11
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
fix double subsititution of ampersand ... strange.

allow certain instance attributes to be updated optionally withtout forcing a new revision

- better naming

- more general method for updating single attributes

Set default path for binary to /usr/bin instead of /usr/local/bin

    • -1
    • +1
    /openacs-4/packages/dotlrn/dotlrn.info
- rename render_content for form fields to render_input

- provide flag for make_link to avoid double subsitition in tdom

    • -3
    • +5
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Changed to reflect changes made in views datamodel

    • -2
    • +2
    /openacs-4/packages/lorsm/lib/user-lorsm.xql
    • -338
    • +338
    /openacs-4/packages/lorsm/www/delivery/menu-mk.tcl
Removing extra "provides" tag.

Changed to use new acs_mail_lite::send

    • -16
    • +6
    /openacs-4/packages/imsld/tcl/imsld-procs.tcl
Merging Luis fixes from 5.3

    • -2
    • +9
    /openacs-4/packages/imsld/www/monitor-frame.tcl
    • -1
    • +16
    /openacs-4/packages/imsld/www/monitor-frame.xql
Changed to use new acs_mail_lite::send

Changed to use new acs_mail_lite::send

It's "sysdate", not "sysdate()", folks :)

HTML Strict cleanup

Set the default config for a debian/ubuntu instalation (as agreed at the OCT)

fix bug with right click and properties popup

fix sorting of folder and files in treepanel and filespanel

Fixed version number

Broken for oracle ... not now though.

Crap, this script was added with the following problems ...

1. called contacts package (fixed previously)

2. embedded PG-only queries (no xql files, no attempt to make this dotlrn

component work with oracle despite our policy of supporting oracle)

3. authorship misattributed to tracy adams (copied another script as a stub),

she wasn't the source of these problems

    • -0
    • +16
    /openacs-4/packages/notifications/www/subscribers-oracle.xql
    • -0
    • +14
    /openacs-4/packages/notifications/www/subscribers-postgresql.xql
    • -0
    • +16
    /openacs-4/packages/notifications/www/subscribers.xql
Changed *^*&#$(&*(*$%&#@ tabs to spaces, and yes, it messes up history, and

no, I don't care.

    • -127
    • +127
    /openacs-4/packages/forums/lib/message/post.tcl