OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 146
Last Commit: 14 Nov
Commits this week: 10
Total Lines of Code (LoC): 7,560,821
Net change in LoC this week: 22

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 Dec 2018
11:39 am

antoniop

Replace single quotes wuith double quotes in javascript expressions involving acs_ListBulkActionClick

this is really needed only for the URL part, but was done on the name as well for consistency. The reason

is even a properly encoded URL could still contain single quotes, therefore breaking the expression,

while double quotes are expected to be encoded in valid, urlencoded URLs. This relies on trusting the developer

to properly encode URLs, which should be expected. An alternative could involve active escaping of

javascript special characters by e.g. ad_js_escape.

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/lists/courses.adp
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/lists/table-2third.adp
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/lists/table.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/lists/table-2third.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/lists/table.adp
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
10:48 am

gustafn

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

Options
    • -2
    • +2
    /openacs-4/packages/soap-gateway/sql/postgresql/soap-gateway-create.sql
10:13 am

michaela

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/sql/postgresql/postgresql.sql
Saturday 15 Dec 2018
7:07 pm

gustafn

backport from oacs-5-9, which might avoid problems with oacs 5-8 when used with recent versions of nsf

Options
    • -0
    • +9
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
6:46 pm

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
Friday 14 Dec 2018
9:15 pm

gustafn

perform javascript escaping with more regular semantics

Options
    • -9
    • +11
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -4
    • +11
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
4:11 pm

antoniop

Introduce new ad_js_escape with the purpose of sanitizing tcl strings used inside javascript code from escape sequences and from quotes in particular and provide some test cases

TODO: consider its usage into templates when e.g. we are putting a URL into javascript functions such as acs_ListBulkActionClick. URLs might in fact contain single and double quotes.

Options
    • -1
    • +22
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -0
    • +19
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Wednesday 12 Dec 2018
7:20 pm

antoniop

Provide some basic way to create subgroups via the UI

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/www/admin/groups/one.adp
    • -2
    • +7
    /openacs-4/packages/acs-subsite/www/admin/groups/one.tcl
Tuesday 11 Dec 2018
5:48 pm

antoniop

Actually store the group name in the UI by intercepting the right form var

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/www/admin/groups/new.tcl
5:23 pm

antoniop

Fix test test by considering that group pretty name is automatically localized

Options
    • -3
    • +10
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
5:21 pm

antoniop

Don't quote some function defaults that are meant to be evaluated literally

Options
    • -7
    • +17
    /openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl
3:35 pm

antoniop

New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

Options
    • -1
    • +53
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
3:14 pm

antoniop

Move logics to delete a group type into the API

Options
    • -1
    • +34
    /openacs-4/packages/acs-subsite/tcl/group-type-procs-oracle.xql
    • -1
    • +31
    /openacs-4/packages/acs-subsite/tcl/group-type-procs-postgresql.xql
    • -1
    • +71
    /openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
    • -79
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2-oracle.xql
    • -85
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2-postgresql.xql
    • -62
    • +6
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.tcl
    • -14
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.xql
2:25 pm

antoniop

Fix quoting of group type

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2-postgresql.xql
12:26 pm

antoniop

Remove unneeded variable

Options
    • -7
    • +1
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
12:20 pm

antoniop

Add (trivial) ad_include_contract

Options
    • -1
    • +5
    /openacs-4/packages/acs-subsite/lib/subsites.tcl
12:16 pm

antoniop

Avoid unnecessary computations

Options
    • -1
    • +0
    /openacs-4/packages/acs-subsite/lib/subsites-oracle.xql
    • -1
    • +0
    /openacs-4/packages/acs-subsite/lib/subsites-postgresql.xql
    • -9
    • +10
    /openacs-4/packages/acs-subsite/lib/subsites.tcl
11:38 am

gustafn

add index for bulk mail sweeper. was already #10 on sequential reads on learn

Options
    • -2
    • +2
    /openacs-4/packages/bulk-mail/bulk-mail.info
    • -1
    • +2
    /openacs-4/packages/bulk-mail/sql/oracle/bulk-mail-create.sql
    • -0
    • +4
    /openacs-4/packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
    • -2
    • +3
    /openacs-4/packages/bulk-mail/sql/postgresql/bulk-mail-create.sql
    • -0
    • +24
    /openacs-4/packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
Monday 10 Dec 2018
7:26 pm

antoniop

Reduce divergency between oracle and postgres codebase and bring portable sql inline

Options
    • -39
    • +0
    /openacs-4/packages/acs-subsite/tcl/application-group-procs-oracle.xql
    • -41
    • +0
    /openacs-4/packages/acs-subsite/tcl/application-group-procs-postgresql.xql
    • -6
    • +39
    /openacs-4/packages/acs-subsite/tcl/application-group-procs.tcl
    • -33
    • +0
    /openacs-4/packages/acs-subsite/tcl/application-group-procs.xql
5:31 pm

antoniop

Reuse return url over subsites, remove dummy sql

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/lib/subsites.tcl
5:27 pm

antoniop

Use best practice list idiom

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/lib/subsites.tcl
5:25 pm

antoniop

Avoid useless check

Options
    • -2
    • +1
    /openacs-4/packages/acs-subsite/lib/subsites.tcl
3:47 pm

gernst

Proc "util_get_subset_missing": make sure to return the found elements.

Added test case for this proc.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -5
    • +13
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
10:24 am

gustafn

allow passing of pretty_names that contain content including less and greater sign

Options
    • -1
    • +1
    /openacs-4/packages/notifications/lib/notification-widget.tcl
    • -2
    • +2
    /openacs-4/packages/notifications/www/request-new.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/templates/packages/notifications/lib/notification-widget.tcl
9:55 am

gustafn

fix overquoting in notification-widget

Options
    • -1
    • +1
    /openacs-4/packages/forums/www/forum-view.adp
    • -1
    • +1
    /openacs-4/packages/forums/www/message-view.adp
    • -1
    • +1
    /openacs-4/packages/calendar/www/view.adp
    • -1
    • +1
    /openacs-4/packages/faq/www/one-faq.adp
    • -1
    • +1
    /openacs-4/packages/file-storage/www/index.adp
    • -1
    • +1
    /openacs-4/packages/fs-portlet/www/fs-contents-portlet.adp
    • -1
    • +1
    /openacs-4/packages/fs-portlet/www/fs-portlet.adp
Friday 07 Dec 2018
1:02 pm

antoniop

Localize file-size limits in the UI

Options
    • -4
    • +5
    /openacs-4/packages/file-storage/www/file-add.tcl
12:54 pm

antoniop

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Options
    • -2
    • +20
    /openacs-4/packages/file-storage/www/file-add.tcl
12:34 pm

antoniop

Prettify code

Options
    • -10
    • +20
    /openacs-4/packages/file-storage/www/file-add.tcl
12:31 pm

hectorr

Make 'util_user_message' quote the message when the parameter 'html_p' is false, not otherwise, restoring pre-refactoring behavior and making it coherent with the parameter doc

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
12:12 pm

antoniop

Remove obsolete xql files

Options
    • -31
    • +0
    /openacs-4/packages/file-storage/www/version-delete-oracle.xql
    • -26
    • +0
    /openacs-4/packages/file-storage/www/version-delete-postgresql.xql
    • -25
    • +0
    /openacs-4/packages/file-storage/www/version-delete.xql