OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 146
Last Commit: 29 Jul
Commits this week: 0
Total Lines of Code (LoC): 7,561,801
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Feb 2018
3:00 pm

antoniop

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -24
    • +23
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-item.sql
    • -0
    • +77
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +11
    /openacs-4/packages/acs-kernel/sql/postgresql/acs-objects-create.sql
    • -0
    • +80
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
    • -3
    • +8
    /openacs-4/packages/acs-subsite/lib/home.tcl
    • -19
    • +0
    /openacs-4/packages/acs-subsite/lib/home.xql
    • -16
    • +6
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
    • -19
    • +0
    /openacs-4/packages/acs-subsite/www/user/portrait/upload-oracle.xql
    • -22
    • +0
    /openacs-4/packages/acs-subsite/www/user/portrait/upload-postgresql.xql
    • -75
    • +15
    /openacs-4/packages/acs-subsite/www/user/portrait/upload.tcl
    • -38
    • +0
    /openacs-4/packages/acs-subsite/www/user/portrait/upload.xql
    • -1
    • +14
    /openacs-4/packages/acs-tcl/tcl/community-core-procs-oracle.xql
    • -0
    • +16
    /openacs-4/packages/acs-tcl/tcl/community-core-procs-postgresql.xql
    • -7
    • +63
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
    • -10
    • +0
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.xql
Tuesday 20 Feb 2018
10:15 am

gustafn

avoid errors, when connection is already closed

Options
    • -1
    • +8
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
10:07 am

gustafn

fix more spelling issues

Options
    • -1
    • +1
    /openacs-4/packages/acs-mail-lite/acs-mail-lite.info
    • -4
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/www/doc/analysis-notes.adp
Monday 19 Feb 2018
8:14 pm

gustafn

remove spurious "expr" in "expr"

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/www/doc/imap-test.tcl
8:00 pm

gustafn

simplfy expressions (no need for backslash), standardize writing of RFC

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -48
    • +55
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -16
    • +18
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -9
    • +9
    /openacs-4/packages/acs-mail-lite/tcl/maildir-inbound-procs.tcl
    • -3
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/utils-procs.tcl
7:33 pm

gustafn

fix spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-mail-lite/www/doc/imap-install.adp
    • -1
    • +1
    /openacs-4/packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp
7:32 pm

gustafn

Apply pachtes #960, #961, #962 and #963 from Ben Brink, bump version number to 5.10.0d3 such that changes in .info file get picked up

Options
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/acs-mail-lite.info
    • -8
    • +52
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -2
    • +10
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -18
    • +35
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
7:08 pm

gustafn

provide templated error pages for subsite. without this, error pages for host-node-mapped subsites are a pain

CVS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -0
    • +7
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/acs-subsite/www/shared/403.adp
    • -0
    • +4
    /openacs-4/packages/acs-subsite/www/shared/404.adp
    • -0
    • +5
    /openacs-4/packages/acs-subsite/www/shared/500.adp
    • -0
    • +5
    /openacs-4/packages/acs-subsite/www/shared/503.adp
5:55 pm

gustafn

fix for bug #3338

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
1:31 pm

hectorr

fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Options
    • -3
    • +5
    /openacs-4/packages/acs-subsite/www/user/portrait/upload.tcl
Sunday 18 Feb 2018
4:43 pm

gustafn

Improve HTML

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/www/doc/inbound-message-bot.adp
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/www/doc/inbound.adp
11:41 am

gustafn

modernize Tcl code

Options
    • -6
    • +6
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/maildir-inbound-procs.tcl
11:40 am

gustafn

prefer ad_try over catch, simplify expression

Options
    • -7
    • +13
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
Saturday 17 Feb 2018
6:33 pm

gustafn

fix typos

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl
6:25 pm

gustafn

Protect Tcl's file operations against leading dashes in file names

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-mail-lite/tcl/maildir-inbound-procs.tcl
6:15 pm

gustafn

change "fetch first 1 row only" to "limit 1" to generic xql file, since Oracle started to support fetch first only with version 12c

Options
    • -1
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.xql
6:08 pm

gustafn

merge with changes from https://github.com/tekbasse/acs-mail-lite/tree/master/tcl

in essence, these changes provide support for handling email with attachments based on nsIMAP.

see https://openacs.org/forums/message-view?message_id=5378972 for more background

Options
    • -14
    • +25
    /openacs-4/packages/acs-mail-lite/acs-mail-lite.info
    • -1
    • +358
    /openacs-4/packages/acs-mail-lite/sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +42
    /openacs-4/packages/acs-mail-lite/sql/postgresql/acs-mail-lite-drop.sql
    • -0
    • +356
    /openacs-4/packages/acs-mail-lite/sql/postgresql/upgrade/upgrade-5.10.0d1-5.10.0d2.sql
    • -5
    • +134
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl
    • -13
    • +58
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-init.tcl
    • -0
    • +19
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs-oracle.xql
    • -0
    • +20
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs-postgresql.xql
    • -14
    • +32
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -0
    • +56
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs-oracle.xql
    • -0
    • +56
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs-postgresql.xql
    • -8
    • +48
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs.tcl
    • -0
    • +2434
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -0
    • +877
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -18
    • +32
    /openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl
  16. … 57 more files in changeset.
Friday 16 Feb 2018
5:51 pm

hectorr

Add ad_script_abort (thanks to Felix Moedritscher)

Options
    • -1
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -1
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
2:23 pm

gernst

Use ad_script_abort after ns_return

Options
    • -2
    • +2
    /openacs-4/packages/xml-rpc/www/index.tcl
Thursday 15 Feb 2018
3:40 pm

gernst

Consistently use ad_script_abort after ad_returnredirect

Options
    • -1
    • +5
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
    • -2
    • +2
    /openacs-4/packages/new-portal/www/admin/portal-config-2.tcl
Tuesday 13 Feb 2018
4:07 pm

hectorr

Fix bad handler type error, use ad_try/finally instead of else (Thanks to Felix Moedritscher)

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
Friday 09 Feb 2018
3:57 pm

gernst

Fixed package version numbering

Options
    • -2
    • +2
    /openacs-4/packages/acs-events/acs-events.info
3:11 pm

gernst

Added missing index creation statment; Fixed typo in index name

Options
    • -4
    • +3
    /openacs-4/packages/acs-events/acs-events.info
    • -2
    • +4
    /openacs-4/packages/acs-events/sql/postgresql/acs-events-create.sql
    • -0
    • +5
    /openacs-4/packages/acs-events/sql/postgresql/upgrade/upgrade-0.6-0.6.1.sql
Thursday 08 Feb 2018
6:36 pm

gustafn

remove obsolete comment (basic hastore support was moved to xowiki)

Options
    • -12
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
6:35 pm

gustafn

Make sure to add hkey when db has hstore defined

Options
    • -1
    • +19
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
3:42 pm

gernst

Corrected table name

Options
    • -2
    • +2
    /openacs-4/packages/static-portlet/sql/postgresql/upgrade/upgrade-2.9.1-2.10.0d1.sql
Wednesday 07 Feb 2018
6:39 pm

gustafn

add return_url to to add_url on view-one-day-display

Options
    • -6
    • +7
    /openacs-4/packages/calendar/www/view-one-day-display.tcl
Monday 05 Feb 2018
5:34 pm

hectorr

Add custom delimiter to csv (Thanks to Monika Andergassen)

Options
    • -4
    • +6
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
Sunday 04 Feb 2018
1:59 am

gustafn

provide more feedback when tdom parsing fails

Options
    • -4
    • +44
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
1:50 am

gustafn

reduce logging level for page-contract loading (otherwise we see many errors from e.g. obsolete packages where page_contract cannot be executed)

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl