nsfError.c

Clone Tools
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code cleanup

- remove calls to deprecated function Tcl_DStringTrunc

- prefer boolean expressions to avoid signed conversions

- add default statement to switch to ease life of static checkers

  1. … 2 more files in changeset.
- provide clean compile for compilations with "-Wwrite-strings" - add const declarations

  1. … 6 more files in changeset.
- remove spurious blank in error message - fix typo in print string

  1. … 3 more files in changeset.
- improve comment and signature of NsfNoCurrentObjectError - improve wording of other commends, keep cmments within the limits of the header/trailer line

  1. … 1 more file in changeset.
nsfError.c: Fixed typos and unified writing style in code comments

- cleanup of type conversions

  1. … 6 more files in changeset.
- Remove occurrences of deprecated Tcl Call Tcl_AppendResult() in overall code

  1. … 1 more file in changeset.
- don't compute string length twice

remove various code smells: - add const declarations - prefer boolean tests - don't write "for" loops without a block - don't pass non-initialized value in an array on index [0] - reduce variable scope - prefer single returns statements in functions - dont't use CONST unless defined by Tcl-API

  1. … 9 more files in changeset.
Promote log statement to Tcl panic

NsfDStringVPrintf: Make log statement conditional on NDEBUG

Rephrase err message

Suppress cppcheck warning: unused variable assignment

- minor cleanup

Improve documentation on NsfDStringVPrintf()

Another attempt to sort out the vs*printf() mess between runtimes

- fix potential memory corruption bug in NsfDStringVPrintf()

  1. … 1 more file in changeset.
- New macros NSF_nonnull_assert() and nonnull_assert() Background: The unreleased gcc6 with "-pedantic" complaints since recently about asserts, in which nonnull conditions implied by nonnull declarations are explicitly tested, and spits out warnings like ... warning: nonnull argument ... compared to NULL ... The new macros turns off asserts, when gcc6 is used.

  1. … 16 more files in changeset.
- prefer boolean expressions - reduce implicit conversions - wite body of if-statements as blocks - whitespace changes - update licenses

  1. … 8 more files in changeset.
- changed trace facility to append to a variable to minimize interactions for results and return codes, which happen via nsf::log. - added more convenient function for adding to DStrings: Nsf_DStringPrintf - renamed NsfDStringPrintf to NsfDStringVPrintf - replaced complex macros for tracing by functions

  1. … 8 more files in changeset.
- prefer const over CONST unless Tcl API

  1. … 6 more files in changeset.
- prefer boolean expression in tests over expressions of other types

  1. … 26 more files in changeset.
NsfDStringPrintf(): Fix vargs processing under VC 12

Done revising license statements in generic/*

  1. … 26 more files in changeset.
- white-space changes

  1. … 15 more files in changeset.
- fix name paths in error messages triggered from ArgumentParse()

  1. … 5 more files in changeset.
- move NsfMethodNamePath() out of NsfUnexpectedArgumentError() and NsfUnexpectedNonposArgumentError()

  1. … 1 more file in changeset.
- no need to call NsfMethodNamePath in NsfArgumentError()

- move NsfMethodNamePath() out of NsfUnexpectedArgumentError() and NsfUnexpectedNonposArgumentError()

  1. … 1 more file in changeset.
- move NsfMethodNamePath() out of NsfObjWrongArgs()

  1. … 2 more files in changeset.