• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed inline js handlers to comply with CSP

Removed deprecated html attributes bgcolor and align

Removed exec mv and used file rename instead

Fixed markup

Removed redundant files: they are duplicated in attach-file.adp and attach-file.tcl

in the same folder, actually used by the OacsAttach plugin and revised for CSP already.

Removed commented markup

Remove inline js handlers to comply with CSP

Remove inline event handlers to comply with CSP

    • -5
    • +18
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
Creating a transcript is an administrative action, regular users can already

see every transcript created, including the current conversation.

Therefore, disable create transcript button for people without privilege.

(Privilege would be enforced anyway afterwards)

    • -6
    • +17
    /openacs-4/packages/chat/lib/transcripts.tcl
Fix class instead of id so events can fire

- improve breadcrums

- prettify long-calls page

- fixed some prev/next links

- made don't provide empty links in navigation arrows

  1. … 31 more files in changeset.
- use "-is_latest true" also for save_new

- remove commented out lines

    • -3
    • +1
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- improve comments

Fix wrong localization key

- avoid call of deprecated sql variant with 12 args via API (many thnaks to Guenter Ernst)

- handling of NULL values in cr_revision_latest_tr (many thanks to Guenter Ernst)

- bump version to 5.9.1d24

file upgrade-5.9.1d23-5.9.1d24.sql was initially added on branch oacs-5-9.

Align popups into richtext-xinha package to the one currently used into xowiki,

as they will be the proper replacement in the future

Put up.gif from richtext-xinha package

Changed reference to the "up" icon so it is found.

TODO

The best would have been the one from richtext-xinha package, but is not reachable because it cannot be mounted.

Removed inline js in favor of explicit ones to comply with CSP

Removed inline js handlers in favor of explicit ones to comply with CSP

Removed inline js handlers, replaced with explicit ones

Remove handler which function was nowhere in the original javascript

Removed redundand body and html tags (they come already from master template)

Removed inline js events into explicit handlers. Test and revamp of plugin to functional state.

Uniform cache for chat room infos to the established nomenclature.

Increase size so that 1000 maximum entries would fit in the cache.

    • -6
    • +7
    /openacs-4/packages/chat/tcl/chat-procs.tcl
- provide partial times to statistics (if available)

- add long-calls to navigation structure

- bump version number to 0.48

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

- set live and latest revision on one sweep (use is_latests setting when setting live_revision)

Reduced generation of dead tuples in postgres.

Background: In the old version, the fields latest and live

revisions were updated always via two separate dmlDML statements.

Every update causes in PostgreSQL (tested to pg 9.6) one more dead

tuple, such that on busy systems, we see 30k + dead tuples per

hour. These dead tuples in turn cause more auto vacuum operations

and can lead to abandoned query plans.

This change can reduce the number of dead tuples on cr_items into

half, by allowing both fields to be set in one operation (namely

content_item__set_live_revision). This function has an optional 4th

argument that can cause this optimization. For legacy applications,

nothing changes.

Btw: since all commonly used applications use the live revision, the

fallback of the latest_revision is unused. One can consider to

remove the cr_revision_latest_tr, at least on on certain

installations.

bump revision to 5.1.9d23

file upgrade-5.9.1d22-5.9.1d23.sql was initially added on branch oacs-5-9.