OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 11
Total Committers: 146
Last Commit: 26 Dec
Commits this week: 11
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Feb 2021
12:47 pm

gustafn

Refactor content repository backend

The refactored code is a first step to become able to provide plugins

for backends for storing content in different systems. Instead of

using switch statements to distinguish between backends "file", "lob"

and "text", procs with a suffix of the storage name are provided

now. Essentially, by providing process with additional suffixes can be

used to provide additional storage systems.

In addition, the deletion handling was also refactored such that the

non-scalable functions iterating over all items (such as

"cr_check_orphaned_files") will become obsolete. This is imporant for

content repositories with double and triple digit terabytes.

Options
    • -15
    • +0
    /openacs-4/packages/acs-content-repository/tcl/acs-content-repository-init-oracle.xql
    • -13
    • +0
    /openacs-4/packages/acs-content-repository/tcl/acs-content-repository-init-postgresql.xql
    • -10
    • +0
    /openacs-4/packages/acs-content-repository/tcl/acs-content-repository-init.tcl
    • -5
    • +14
    /openacs-4/packages/acs-content-repository/tcl/acs-content-repository-procs-oracle.xql
    • -0
    • +8
    /openacs-4/packages/acs-content-repository/tcl/acs-content-repository-procs-postgresql.xql
    • -1
    • +21
    /openacs-4/packages/acs-content-repository/tcl/acs-content-repository-procs.tcl
    • -6
    • +27
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -12
    • +0
    /openacs-4/packages/acs-content-repository/tcl/content-procs-postgresql.xql
    • -24
    • +38
    /openacs-4/packages/acs-content-repository/tcl/content-procs.tcl
    • -10
    • +21
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs-oracle.xql
    • -22
    • +4
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs-postgresql.xql
    • -45
    • +366
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
    • -27
    • +111
    /openacs-4/packages/acs-content-repository/tcl/deprecated-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/revision-procs-oracle.xql
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/revision-procs-postgresql.xql
    • -115
    • +136
    /openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl
    • -107
    • +27
    /openacs-4/packages/acs-content-repository/tcl/search-procs.tcl
11:33 am

hectorr

Make length greater than 0 in 'ad_pad' test case

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Friday 19 Feb 2021
7:07 pm

gustafn

added "content_type" to the list of specially handled calls. this fixes two more cases in Test case callgraph__bad_calls

Options
    • -3
    • +3
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
6:48 pm

gustafn

added more covered procs to the list of tested procs

Options
    • -1
    • +6
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
4:29 pm

hectorr

Add proc names to the list of covered procs in xml-rpc tests

Options
    • -2
    • +7
    /openacs-4/packages/xml-rpc/tcl/test/xml-rpc-test-procs.tcl
4:20 pm

hectorr

Whitespace changes

Options
    • -94
    • +88
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
4:16 pm

hectorr

Add proc names to the list of covered procs in oacs-dav tests

Options
    • -5
    • +13
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
4:12 pm

hectorr

Fix extra brace

Options
    • -2
    • +1
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
3:19 pm

hectorr

Whitespace changes

Options
    • -141
    • +135
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
    • -33
    • +59
    /openacs-4/packages/assessment/tcl/test/as-item-procs.tcl
2:53 pm

hectorr

Add proc names to the list of covered procs in assessment tests

Options
    • -10
    • +41
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
    • -2
    • +10
    /openacs-4/packages/assessment/tcl/test/as-item-procs.tcl
11:19 am

gustafn

moved helper proc "portlet_exists_p" from test cases to library

Options
    • -2
    • +17
    /openacs-4/packages/bm-portlet/tcl/bm-portlet-procs.tcl
11:14 am

gustafn

include package key in proc info

Options
    • -1
    • +6
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
11:12 am

gustafn

replace call to deprecated function

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:11 am

gustafn

remove protection "private", since function has to be called from other packages

Options
    • -4
    • +7
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -5
    • +6
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
11:08 am

gustafn

- fixed mis-classification of "max", "min" and "random" in "tclcode_to_html"

- added new test case "callgraph__bad_calls" to check for

a) calls to deprecated procs

b) direct calls to private procs from other packages ("private" means "packakge private"

Options
    • -11
    • +29
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -1
    • +62
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
10:47 am

gustafn

reduce verbosity, add covered calls in test cases

Options
    • -6
    • +8
    /openacs-4/packages/calendar/tcl/cal-item-procs.tcl
    • -1
    • +3
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
Thursday 18 Feb 2021
6:40 pm

hectorr

Fix extra braces

Options
    • -2
    • +2
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
6:37 pm

hectorr

Add 'calendar_basic_api' test case, covering 'calendar::new', 'calendar::delete', 'calendar::rename' and 'calendar::name'

Options
    • -1
    • +58
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
5:41 pm

hectorr

Extend 'create_portal_from_template' test case to cover 'portal::delete', 'portal::page_delete', 'portal::page_count', 'portal::get_page_id', 'portal::get_page_pretty_name', 'portal::set_page_pretty_name' and 'portal::first_page_p'

Options
    • -34
    • +91
    /openacs-4/packages/new-portal/tcl/test/new-portal-test-procs.tcl
4:47 pm

hectorr

Whitespace changes

Options
    • -24
    • +24
    /openacs-4/packages/new-portal/tcl/test/new-portal-test-procs.tcl
4:45 pm

hectorr

Add covered procs to test case

Options
    • -1
    • +4
    /openacs-4/packages/new-portal/tcl/test/new-portal-test-procs.tcl
4:06 pm

hectorr

Add trivial test for 'bulk_mail::package_key'

Options
    • -0
    • +12
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
3:51 pm

gustafn

remove dependency on ad_ns_set_keys

Options
    • -5
    • +8
    /openacs-4/packages/categories/www/cadmin/master.tcl
3:46 pm

gustafn

improve listing of test coverage

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl
    • -1
    • +25
    /openacs-4/packages/news/tcl/test/news-db-test-init.tcl
3:41 pm

gustafn

mark functions called only internally as private

Options
    • -6
    • +6
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/example-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/tcl/acs-admin-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/tcl/acs-core-docs-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl
    • -5
    • +7
    /openacs-4/packages/acs-mail-lite/tcl/utils-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-service-contract/tcl/msg-type-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
3:28 pm

gustafn

bring test coverage to >50% by adding test cases and marking only locally called functions as private

Options
    • -5
    • +5
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
    • -0
    • +29
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
3:25 pm

hectorr

Add editor hints + whitespace changes

Options
    • -5
    • +10
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
3:19 pm

hectorr

Remove leftover comment

Options
    • -2
    • +1
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
3:16 pm

hectorr

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

Options
    • -0
    • +89
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
3:16 pm

hectorr

file attachments-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl