OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 146
Last Commit: 13:32
Commits this week: 19
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 19 Feb 2021
11:11 am

gustafn

remove protection "private", since function has to be called from other packages

Options
    • -4
    • +7
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -5
    • +6
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
11:08 am

gustafn

- fixed mis-classification of "max", "min" and "random" in "tclcode_to_html"

- added new test case "callgraph__bad_calls" to check for

a) calls to deprecated procs

b) direct calls to private procs from other packages ("private" means "packakge private"

Options
    • -11
    • +29
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -1
    • +62
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
10:47 am

gustafn

reduce verbosity, add covered calls in test cases

Options
    • -6
    • +8
    /openacs-4/packages/calendar/tcl/cal-item-procs.tcl
    • -1
    • +3
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
Thursday 18 Feb 2021
6:40 pm

hectorr

Fix extra braces

Options
    • -2
    • +2
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
6:37 pm

hectorr

Add 'calendar_basic_api' test case, covering 'calendar::new', 'calendar::delete', 'calendar::rename' and 'calendar::name'

Options
    • -1
    • +58
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
5:41 pm

hectorr

Extend 'create_portal_from_template' test case to cover 'portal::delete', 'portal::page_delete', 'portal::page_count', 'portal::get_page_id', 'portal::get_page_pretty_name', 'portal::set_page_pretty_name' and 'portal::first_page_p'

Options
    • -34
    • +91
    /openacs-4/packages/new-portal/tcl/test/new-portal-test-procs.tcl
4:47 pm

hectorr

Whitespace changes

Options
    • -24
    • +24
    /openacs-4/packages/new-portal/tcl/test/new-portal-test-procs.tcl
4:45 pm

hectorr

Add covered procs to test case

Options
    • -1
    • +4
    /openacs-4/packages/new-portal/tcl/test/new-portal-test-procs.tcl
4:06 pm

hectorr

Add trivial test for 'bulk_mail::package_key'

Options
    • -0
    • +12
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
3:51 pm

gustafn

remove dependency on ad_ns_set_keys

Options
    • -5
    • +8
    /openacs-4/packages/categories/www/cadmin/master.tcl
3:46 pm

gustafn

improve listing of test coverage

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl
    • -1
    • +25
    /openacs-4/packages/news/tcl/test/news-db-test-init.tcl
3:41 pm

gustafn

mark functions called only internally as private

Options
    • -6
    • +6
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/example-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/tcl/acs-admin-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/tcl/acs-core-docs-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl
    • -5
    • +7
    /openacs-4/packages/acs-mail-lite/tcl/utils-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-service-contract/tcl/msg-type-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
3:28 pm

gustafn

bring test coverage to >50% by adding test cases and marking only locally called functions as private

Options
    • -5
    • +5
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
    • -0
    • +29
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
3:25 pm

hectorr

Add editor hints + whitespace changes

Options
    • -5
    • +10
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
3:19 pm

hectorr

Remove leftover comment

Options
    • -2
    • +1
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
3:16 pm

hectorr

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

Options
    • -0
    • +89
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
3:16 pm

hectorr

file attachments-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
1:45 pm

gustafn

mark unused function "_mr" as deprecated

Options
    • -9
    • +8
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
Wednesday 17 Feb 2021
9:52 pm

gustafn

mark unused functions as deprecated

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -2
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:52 pm

gustafn

improve comment

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
9:51 pm

gustafn

make use of built-in reverse proxy mode of newer versions of NaviServer

Options
    • -3
    • +6
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -5
    • +13
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
8:01 pm

gustafn

overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments

Options
    • -11
    • +28
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
7:43 pm

gustafn

make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty

Options
    • -4
    • +6
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -1
    • +1
    /openacs-4/packages/survey/tcl/survey-procs.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/one.tcl
12:13 pm

gustafn

don't load deprecated code unless explicitly required

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/sql-statement-procs.tcl
12:10 pm

gustafn

deprecate unused and untested code

Options
    • -3
    • +8
    /openacs-4/packages/acs-tcl/tcl/sql-statement-procs.tcl
11:41 am

gustafn

fix deprecated function

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/deprecated-procs.tcl
11:41 am

gustafn

remove call to deprecated proc

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/lib/page-error.tcl
11:24 am

gustafn

removed leftover from debugging

Options
    • -2
    • +0
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
10:30 am

gustafn

Fix correct-when test of empty input when constraint is "<" or "<=". Many thanks for Florian Mosböck for finding this.

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
9:27 am

gustafn

provide more details in log message

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl