Activity OpenACS/

12:37 pm

antoniop

Consider failures obtaining the token as failure to verify the value and report into the log file

- -2
- +8
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

12:28 pm

antoniop

Fix boolean syntax in adp

- -1
- +1
/openacs-4/packages/dotlrn-forums/www/user.adp
- History
- Source
- Diff
/openacs-4/packages/.../www/user.adp

12:27 pm

antoniop

Fix/modernize boolean syntax in adp

- -1
- +1
/openacs-4/packages/dotlrn/www/site-map.adp
- History
- Source
- Diff
/openacs-4/packages/.../www/site-map.adp
- -1
- +1
/openacs-4/packages/dotlrn/www/admin/class.adp
- History
- Source
- Diff
/openacs-4/packages/.../admin/class.adp

5:29 pm

antoniop

Declare api as tested

- -1
- +2
/openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

5:27 pm

antoniop

Make the api creating the Service Contract implementations for RSS in the file-storage package private, as they are meant to be invoked only once at install/uninstall time

- -2
- +2
/openacs-4/packages/file-storage/tcl/file-storage-rss-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-rss-procs.tcl

5:24 pm

antoniop

Deprecate fs::torrent::get_hashsum, which can be replaced by a oneliner idiom on modern NaviServer

- -1
- +6
/openacs-4/packages/file-storage/tcl/file-storage-torrent-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-torrent-procs.tcl

5:18 pm

antoniop

Increase proc coverage

- -1
- +169
/openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

4:04 pm

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

- -37
- +110
/openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

2:50 pm

antoniop

Make service contract implementation private

- -4
- +6
/openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

2:19 pm

antoniop

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

- -12
- +37
/openacs-4/packages/forums/tcl/forums-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/forums-procs.tcl

2:04 pm

antoniop

Provide package_id to the api explicitly

- -2
- +2
/openacs-4/packages/calendar/www/cal-item-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/cal-item-view.tcl

2:03 pm

antoniop

Cleanup unused variables

- -4
- +1
/openacs-4/packages/calendar/www/cal-item-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/cal-item-view.tcl

2:02 pm

antoniop

Cleanup reference to non-existent parameter

- -2
- +1
/openacs-4/packages/calendar/www/cal-item-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/cal-item-view.tcl

1:53 pm

antoniop

Test checking for attachments availability by providing explicit package_id

- -2
- +10
/openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../calendar-procs.tcl

1:53 pm

antoniop

Do not require a connection context to determine whether attachments are enabled on a certain package and provide explicit available information instead

- -7
- +6
/openacs-4/packages/calendar/tcl/cal-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../cal-item-procs.tcl
- -43
- +0
/openacs-4/packages/calendar/tcl/cal-item-procs.xql
- History
- Source
- Diff
/openacs-4/packages/.../cal-item-procs.xql
- -3
- +20
/openacs-4/packages/calendar/tcl/calendar-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../calendar-procs.tcl

10:56 am

antoniop

Harden page contract

- -2
- +2
/openacs-4/packages/notifications/www/request-delete.tcl
- History
- Source
- Diff
/openacs-4/packages/.../request-delete.tcl

6:05 pm

antoniop

Value checkers will let empty values pass through

E.g. for a query like "?popular=&summary=1", the checker won't complain for "popular" being empty. Make sure empty values are normalized to false.

- -3
- +3
/openacs-4/packages/xowiki/tcl/package-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/package-procs.tcl

5:24 pm

antoniop

Harden page contract

- -3
- +3
/openacs-4/packages/notifications/www/object-goto.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/object-goto.tcl

5:12 pm

antoniop

Enforce data type of hidden fields, add missing parameters to the page contract

- -3
- +6
/openacs-4/packages/forums/lib/message/post.tcl
- History
- Source
- Diff
/openacs-4/packages/.../message/post.tcl

4:25 pm

antoniop

Make Service Contract implementation private

- -3
- +6
/openacs-4/packages/faq/tcl/faq-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/faq/tcl/faq-procs.tcl

4:04 pm

antoniop

Fix bulk_mail::url using the site_node api

- -14
- +4
/openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../bulk-mail-procs.tcl

4:04 pm

antoniop

Complete coverage for the package

This test currently fails because a query was lost for bulk_mail::url

- -8
- +24
/openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../bulk-mail-procs.tcl

3:47 pm

antoniop

Deprecate bulk_mail::pretty_name, trivial wrapper to the parameter api, which won't do anything to ensure that the pretty_name we are retrieving actually comes from a bulk-mail instance

- -2
- +9
/openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../bulk-mail-procs.tcl
- -2
- +2
/openacs-4/packages/bulk-mail/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl
- -2
- +2
/openacs-4/packages/dotlrn-bm/www/admin/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/index.tcl

3:28 pm

antoniop

Deprecate bulk_mail::parameter, which implements a global parameter logic

For now, the occurrences have just been inlined (fixing also the inconsistent naming PrettyName vs pretty_name). A future reform might create a proper global parameter for this.