OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 07 Sep 2022
4:35 pm

antoniop

Deprecate ad_approval_system_inuse_p

Options
    • -2
    • +8
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
4:22 pm

antoniop

Fix implementation of ad_acs_admin_node so that the node_id is returned as stated in the doc

For the one occurrence that treated this proc as boolean, the result will be the same (e.g. 0 = false and any other id = true)

Options
    • -15
    • +12
    /openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl
    • -16
    • +0
    /openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.xql
4:16 pm

antoniop

Test some system information api

The test shows that ad_acs_admin_node has so far returned a boolean, countrary to what the documentation says

Options
    • -0
    • +52
    /openacs-4/packages/acs-tcl/tcl/test/acs-kernel-procs.tcl
4:16 pm

antoniop

file acs-kernel-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/acs-kernel-procs.tcl
3:56 pm

antoniop

When demoting a user, flush the permissions cache as well

Options
    • -1
    • +7
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
3:53 pm

antoniop

Test demoting/promoting of a user + a buch of other api

This test fails now when checking if a demoted user is still an swa, one needs to flush the permissions as well

Options
    • -1
    • +103
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
2:51 pm

antoniop

Test acs_user::ScreenName

Options
    • -1
    • +42
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
12:27 pm

antoniop

Test acs_object_type_hierarchy

Options
    • -1
    • +76
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
Tuesday 06 Sep 2022
2:41 pm

antoniop

Test acs_object_type::get_table_name

Options
    • -1
    • +21
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
2:31 pm

antoniop

Test acs_object_name api

Options
    • -1
    • +21
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
2:27 pm

antoniop

Test acs_magic_object

Options
    • -1
    • +18
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
2:22 pm

antoniop

Test various URL generating procs

Options
    • -0
    • +72
    /openacs-4/packages/acs-tcl/tcl/test/defs-procs.tcl
2:22 pm

antoniop

file defs-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/defs-procs.tcl
1:43 pm

antoniop

Deprecate util_get_current_url, superseded by ad_return_url

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:17 pm

antoniop

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -4
    • +31
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/search-2.tcl
11:44 am

antoniop

Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/shared/confirm.tcl
    • -7
    • +19
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/dimensional-procs.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/search-2.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/view-comment.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/admin/index.tcl
    • -2
    • +2
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
10:15 am

antoniop

Reimplement util_subset_p

Options
    • -39
    • +25
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:42 am

antoniop

Deprecate util_report_successful_library_load

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/index.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/rel-segments/one.tcl
    • -2
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -20
    • +20
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/attachments/www/file-add-2.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/search.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/community-edit-2.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/file-add.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/version-add.tcl
8:50 am

antoniop

Whitespace cleanup

Options
    • -8
    • +8
    /openacs-4/packages/acs-admin/www/users/index.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/rel-segments/one.tcl
7:48 am

antoniop

Deprecate export_entire_form

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
7:21 am

antoniop

Deprecate util_AnsiDatetoPrettyDate

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/www/asm-admin/one-a.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/one.tcl
7:09 am

antoniop

Deprecate util_report_library_entry

Options
    • -2
    • +9
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:55 am

antoniop

Formatting changes

Options
    • -14
    • +30
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Monday 05 Sep 2022
6:43 pm

antoniop

Deprecate util::string_check_urlsafe

Options
    • -2
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:32 pm

antoniop

Simplify implementation

Options
    • -54
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:57 pm

antoniop

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

Options
    • -15
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:19 pm

antoniop

Cleanup duplicated and slower proc definition

Options
    • -13
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -11
    • +8
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
4:48 pm

antoniop

Use faster idiom to tell if a string is only space

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl