• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve api robustness and test it

Cache api per request

    • -24
    • +27
    /openacs-4/packages/acs-tcl/tcl/object-procs.tcl
Harden page contracts using new features in acs-tcl

    • -1
    • +1
    /openacs-4/packages/chat/lib/transcripts.tcl
    • -11
    • +3
    /openacs-4/packages/chat/www/chat.tcl
    • -18
    • +4
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -10
    • +2
    /openacs-4/packages/chat/www/room-delete.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/room-edit.tcl
    • -11
    • +5
    /openacs-4/packages/chat/www/room-enter.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/room-exit.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/search.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/toggle-active.tcl
  1. … 8 more files in changeset.
Reimplement the message-list UI using the template::list

Reimplement package-list UI using the template::list

Cleanup message keys that do not exist in the english locale (they do exist in their "_time" variant, e.g. Time_must_be_after_min_time, already translated in spanish)

Update italian localization

Don't append an extra empty string to the form command when we are dealing with flags (that have therefore no value)

Fixes regression from https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20220331163354, because now we treat flags properly

Reimplement the main admin locale UI using the template::list

Depend on the new features in acs-tcl

Add missing message key

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
Export message keys from the UI to normalize sorting and quoting

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
Fix typo

Provide a default value for the filter

New ad_page_contract filter object_type

Rhis can enforce an object id to not only be formally correct, but also to be an object of a specific type. It can also be used as a simple existance check

    • -1
    • +33
    /openacs-4/packages/acs-tcl/tcl/object-procs.tcl
Fix query name

Add include contract

Add include contract, bring export page parameter in the page contract, fix javascript handlers

    • -3
    • +2
    /openacs-4/packages/calendar/www/view.tcl
Update documentation

Add include contract

Accept previously valid formats

    • -2
    • +2
    /openacs-4/packages/calendar/www/view.tcl
Streamline idiom

    • -13
    • +2
    /openacs-4/packages/calendar/www/view.tcl
Add include contract

Notice that this page is stored under www, but is de-facto an include.

    • -10
    • +10
    /openacs-4/packages/calendar/www/mini-calendar.tcl
Improve test

Collect common definition of an argspec flag in a proc to improve clarity

Introduce a new clock ad_page_contract filter:

this filter enforces that a datestring belongs to one of the clock formats specified in the argspec. By default, this will be %Y-%m-%d.

Cleanup

ad_page/include_contract argspec parsing reform: allow arbitrary characters in the argspec flag parameters

This reform allows to specify an argspec containing pipes, parenthesys and other so far forbidden characters as parameters for a flag. The purpose is to enhance the expressiveness of existing validators (e.g. the oneof validator) and enable new one, for instance, a date validator using a clock format as parameter.

Pipes and parenthesys need to be escaped via the backslash character in the new syntax.

file tcl-documentation-procs.tcl was initially added on branch oacs-5-10.

Whitespace changes

    • -8
    • +8
    /openacs-4/packages/faq/www/one-faq.tcl