OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Jul 2018
5:53 pm

antoniop

Skip test for those applets associated with a package_id of 0 (happens when no community with this applet is on the system, verified that for 'real' applets this is fine)

Options
    • -1
    • +8
    /openacs-4/packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl
2:31 pm

antoniop

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized when a system was freshly restarted

Options
    • -2
    • +4
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
2:31 pm

antoniop

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Options
    • -5
    • +11
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:03 pm

antoniop

Fix regression test by recreating test file: as it seems, put operation destroys it

Options
    • -3
    • +10
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
1:48 pm

antoniop

Simplify idioms, handle also the case where multiple results might come from the query, as the datamodel doesn't state it clearly and we also had a suspicious orderby

Options
    • -11
    • +3
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
    • -3
    • +2
    /openacs-4/packages/new-portal/tcl/portal-procs.xql
12:13 pm

antoniop

Skip test when tclwebtest is not available

Options
    • -0
    • +5
    /openacs-4/packages/assessment/tcl/test/twt-procs.tcl
12:03 pm

antoniop

Fix News automated tests:

- rename tests using underscore instead of '-' or links in UI would not work

- remove duplicated SQL

- fix awkward hardcoded dates that were supposed to be in the future for test to work

Options
    • -1
    • +1
    /openacs-4/packages/news/tcl/test/news-db-test-init-oracle.xql
    • -1
    • +1
    /openacs-4/packages/news/tcl/test/news-db-test-init-postgresql.xql
    • -44
    • +24
    /openacs-4/packages/news/tcl/test/news-db-test-init.tcl
11:20 am

antoniop

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

Options
    • -2
    • +19
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -6
    • +16
    /openacs-4/packages/forums/tcl/messages-procs.tcl
10:56 am

antoniop

Add documentation and a fallback body for this deprecated proc

Options
    • -2
    • +11
    /openacs-4/packages/forums/tcl/forums-procs.tcl
10:12 am

gustafn

revive xo::list_to_values as it is used by the forthcoming caldav package

Options
    • -8
    • +20
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Saturday 07 Jul 2018
4:26 pm

antoniop

Fix test on system having 0.0.0.0 as IPv4 address in the config file

Options
    • -2
    • +15
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
12:58 pm

gustafn

provide documentation of public procs and methods, make some procs private

Options
    • -1
    • +5
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-mode-procs.tcl
    • -2
    • +12
    /openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/yui-procs.tcl
12:56 pm

gustafn

Improve documentation of public procs and methods.

some legacy cleanup

Options
    • -51
    • +24
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -8
    • +8
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
12:38 pm

gustafn

document public methods

Options
    • -22
    • +66
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
12:36 pm

gustafn

whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
12:35 pm

gustafn

prettify reports

Options
    • -5
    • +10
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
    • -18
    • +31
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
12:11 pm

antoniop

Make sure namespaced variable ::acs::db_pools is created before accessing it

This is needed when upgrading from openacs versions that didn't use this variable before

Options
    • -0
    • +8
    /openacs-4/packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl
11:03 am

gustafn

it seems, we can reactivate per-request caching for sitenodes, otherwise we see up to 37 locks per requests on get_node_id on openacs.org (regression test works fine)

Options
    • -2
    • +11
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
10:58 am

gustafn

bump version number to 5.10.0d5, otherwise the new package keys (such as acs-subsite.404_title) are not known an lead to errors

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
9:54 am

gustafn

reduce verbosity

Options
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
9:48 am

gustafn

Don't be so quick on deprecating a common interface

Options
    • -3
    • +4
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
Thursday 05 Jul 2018
5:14 pm

gustafn

fix broken commit

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
1:52 pm

antoniop

Add TIMESTAMP to the list of feasible time database types in tests

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
1:17 pm

antoniop

Remove duplicated sql

Options
    • -14
    • +0
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.xql
1:16 pm

antoniop

Remove leftover acs_attribute without a database table counterpart (fixes regression test)

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
    • -10
    • +1
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-init.sql
    • -16
    • +1
    /openacs-4/packages/dotlrn/sql/postgresql/dotlrn-init.sql
    • -1
    • +10
    /openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl
1:12 pm

antoniop

Fix attribute::delete proc so it leverages stored procedure capability of dropping the database table as well (was broken before)

This is needed for a non-xotcl portable way of dropping acs_attributes

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/tcl/attribute-procs-oracle.xql
    • -1
    • +1
    /openacs-4/packages/acs-subsite/tcl/attribute-procs-postgresql.xql
    • -24
    • +24
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -6
    • +0
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.xql
12:42 pm

antoniop

Fix acs_attribute datatype to match table type (fixes automated tests)

Options
    • -2
    • +2
    /openacs-4/packages/assessment/assessment.info
    • -0
    • +34
    /openacs-4/packages/assessment/sql/postgresql/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
    • -30
    • +30
    /openacs-4/packages/assessment/tcl/as-install-procs.tcl
12:33 pm

gustafn

fix site-node test in regression test

don't use per-request caching, since we migh shoot in our own foot

interrupt cache_transaction to achieve desired semantics

allow in a few cases empty node_ids for method "get_url" as it is used by current OpenACS

Options
    • -37
    • +47
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -6
    • +19
    /openacs-4/packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl
12:18 pm

gustafn

add debugging aids

Options
    • -0
    • +16
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
12:16 pm

antoniop

Unwrap indentation

Options
    • -233
    • +1320
    /openacs-4/packages/assessment/tcl/as-install-procs.tcl