• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset {id} does not exist.

added tclhttp to system statistics

reapplied post 5-10 release fix

Many thanks to Claudio Pasolini for reporting and identifying the problem!

fixed bug security::validated_host_header

Many thanks to Claudio Pasolini for reporting and identifying the problem!

Fixed 2 bugs: with remote code repository

- fixed repository URL when trying to "install-from-repositry"

on a checkout from the HEAD channel. The code tried to fetch

from a channel "6-0", which does not exist.

- determine the exact repository tag for repository channels

unset temporary variables which would be kept in the in the ::xowiki namespace

    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
streamline spelling

fixed typo

Bumped upstream version of highcharts to 12.1.2

bumped version of fa icons to 6.7.2

Ported essential post-release fixes from oacs-5-10 branch

    • -8
    • +14
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
improved comments

backport from oacs-head, otherwise the cache viewer is unusuable

fixed page contract for cache viewer

Bumped version number of acs-tcl to 5.10.2d2

    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
Fixed bug in install-from-repository (issue #3472)

Install from repository (e.g., of /dotlrn) was horribly broken, see,

e.g., issue #3472. Furthermore, this bug was hard to debug, since it

showed up just during a complex installation attempts involving

install.xml, and it requires fetching from the repository. Therefore,

the debug rounds were quite time-consuming.

There were several problems involved:

1) dotlrn/install.xml was trying to set the theme to the

dotlrn-bootstrap3-theme, which was not loaded from the repository

2) The loading order was not correct, since the theme requires an

existing dotlrn instance to register the theme templates there.

3) The tests in install::xml::action::mount checking, if the package

was already mounted were incorrect, probably since many years. It

looks to me as some refactorings of the "get_node_id" semantics

(many years ago) were not reflected in this code. This bug let

the code assume, that the package was already mounted. Therefore,

the package was never mounted, causing a long tail of subsequent

issues.

4) the site_node::instantiate_and_mount call in

install::xml::action::mount was called with incorrect parameters,

causing overwriting of the site root node, leaving the site

completely unusable.

Bumped version number of acs-tcl to 5.10.2d1

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -8
    • +14
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
fixed overquoting in "ad_progress_base_end"

dirty editor buffer

    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
switch responsibilities for theme setting

    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
One more attempt to install bootstrap3 theme automatically

    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
fixed cut&paste problem

    • -1210
    • +0
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
reset to released version to keep differences little

    • -1
    • +1201
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
deactivate automated theme setting for now

    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
keep theme-stetting for dotlrn themes in dotlrn, since it requires a dotlrn instance

but when the dotlrn is installed, it requires the dotlrn-theme package to be installed

    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
Continue working on the install.xml issue.

added more debugging info

undo one more recent change

undo recent change. This was not the problem

added debug statement

try to get a non-empty context id

added debugging line