• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Oracle testing uncovered a missing parenthesis. Don't you wish EVERYONE

tested their changes under Oracle as well as PG?

    • -1
    • +1
    ./acs-templating/tcl/list-procs-oracle.xql
Oops forgot the ever-so-important .xql files!

    • -0
    • +16
    ./acs-templating/tcl/list-procs-oracle.xql
    • -0
    • +12
    ./acs-templating/tcl/list-procs-postgresql.xql
file list-procs-oracle.xql was initially added on branch oacs-5-1.

    • -0
    • +0
    ./acs-templating/tcl/list-procs-oracle.xql
file list-procs-postgresql.xql was initially added on branch oacs-5-1.

    • -0
    • +0
    ./acs-templating/tcl/list-procs-postgresql.xql
Greatly sped up pagination in the list builder.

1. The list builder builds a separate (optionally cached) paginator for each

page group, rather than each list. No more filling of the Tcl cache with (say) 5500

forum entries when we know that users rarely march through the entire list of forums.

2. Since the list builder builds an "in (list of ids)" query clause to select

just those rows needed for this display page, there's no reason to sort the list

of ids so I'm building the list within the list builder rather than using

the more generalized paginator code. Minor speedup ...

This could probably be sped up more by simply caching the list of keys within

the list builder and replicating some other paginator functionality in lightweight

form specific to the list builder, but this will do for now. And maybe forever.

    • -2
    • +2
    ./acs-templating/tcl/acs-templating-init.tcl
    • -12
    • +38
    ./acs-templating/tcl/list-procs.tcl
    • -4
    • +19
    ./acs-templating/tcl/paginator-procs.tcl
Remove the $ from the word Permissions in quotes. Was throwing a variable not found error.

    • -2
    • +2
    ./calendar/www/admin/permissions-user-add.tcl
Reverse previous commit - fix was actually in catalog. There was a duplicate value for 'Remove' and no 'Remove_All'.

The key 'Remove' had two values 'Remove' and 'Remove_All'. Have now changed the second 'Remove' key to 'Remove_All' and have removed the underscore from the value.

    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
Correct message key 'acs-subsite.Remove_All' to acs-subsite.Remove' to eliminate MISSING KEY message.

no questions bug

add edit icon

add Edit icon

    • binary
    ./rules/www/images/Edit16.gif
change new_rule procedure

add edit icon

change to ad_form instead of form template

fix first question results bug... again

approve requests

    • -0
    • +23
    ./rules/www/admin/approve-users.tcl
add changes

add title property

fix bug or first question

fixing when handling dates

    • -4
    • +10
    ./evaluation/tcl/evaluation-procs.tcl
fixing bug when handling dates

    • -4
    • +10
    ./evaluation/tcl/evaluation-procs.tcl
Increase version to force upgrade of plpgsql function.

Change etp__get_folder_id to stable to improve performance.

file upgrade-1.8b1-1.8b2.sql was initially added on branch oacs-5-1.

added admin pages to edit items, copy items, copy sections

    • -2
    • +30
    ./assessment/catalog/assessment.en_US.ISO-8859-1.xml
    • -0
    • +3
    ./assessment/lib/item-show-display-cb.adp
    • -0
    • +12
    ./assessment/lib/item-show-display-cb.tcl
    • -0
    • +17
    ./assessment/lib/item-show-display-cb.xql
    • -0
    • +3
    ./assessment/lib/item-show-display-rb.adp
    • -0
    • +12
    ./assessment/lib/item-show-display-rb.tcl
    • -0
    • +17
    ./assessment/lib/item-show-display-rb.xql
    • -0
    • +3
    ./assessment/lib/item-show-display-sa.adp
    • -0
    • +10
    ./assessment/lib/item-show-display-sa.tcl
    • -0
    • +16
    ./assessment/lib/item-show-display-sa.xql
    • -0
    • +3
    ./assessment/lib/item-show-display-sb.adp
    • -0
    • +13
    ./assessment/lib/item-show-display-sb.tcl
    • -0
    • +17
    ./assessment/lib/item-show-display-sb.xql
    • -0
    • +3
    ./assessment/lib/item-show-display-ta.adp
    • -0
    • +10
    ./assessment/lib/item-show-display-ta.tcl
  1. … 112 more files in changeset.
change title

Making this scale for sites with a lot of users.

    • -2
    • +2
    ./acs-developer-support/lib/footer.adp
    • -6
    • +22
    ./acs-developer-support/lib/footer.tcl
changes in request processing

add options