OpenACS / openacs-4 / packages

acs-subsite

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 79
Last Commit: 29 Jul
Commits this week: 0
Total Lines of Code (LoC): 49,846
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 09 Mar 2002
3:00 am

donb

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

Options
    • -1
    • +1
    ./www/register/user-login.xql
    • -1
    • +1
    ./www/shared/whos-online-postgresql.xql
    • -3
    • +3
    ./www/shared/whos-online.tcl
    • -2
    • +2
    ./www/user/basic-info-update-2.tcl
    • -1
    • +1
    ./www/user/basic-info-update-2.xql
  6. … 70 more files in changeset.
Friday 08 Mar 2002
10:03 pm

yon

don't allow creation_user to be 0 because it will fail the referential constraint

Options
    • -1
    • +5
    ./tcl/package-procs.tcl
Sunday 24 Feb 2002
9:18 pm

donb

Added a simple database error template that can be used instead of

ad_return_complaint.

Options
    • -0
    • +13
    ./www/shared/db-error.adp
Saturday 23 Feb 2002
10:26 pm

neophytosd

patch 111 applied

Options
    • -2
    • +2
    ./www/admin/groups/one.tcl
10:14 pm

neophytosd

patch 136 applied

Options
    • -7
    • +0
    ./www/admin/site-map/index-oracle.xql
    • -7
    • +0
    ./www/admin/site-map/index-postgresql.xql
3:43 am

donb

Added C. R. Oldham's patch to fix membership testing (unimplemented in ACS

4.2). Ported it to PG on the way ...

Options
    • -0
    • +6
    ./tcl/group-procs-oracle.xql
    • -0
    • +6
    ./tcl/group-procs-postgresql.xql
    • -1
    • +52
    ./tcl/group-procs.tcl
    • -0
    • +6
    ./tcl/group-procs.xql
  5. … 6 more files in changeset.
Sunday 17 Feb 2002
6:04 pm

neophytosd

yet another .tcl extension removal from links

Options
    • -2
    • +2
    ./www/admin/site-map/instance-delete.tcl
  2. … 2 more files in changeset.
12:14 am

neophytosd

yet another .tcl extension removal from links

Options
    • -1
    • +1
    ./www/register/email-confirm.adp
    • -3
    • +3
    ./www/register/user-new-2.tcl
Friday 15 Feb 2002
6:39 pm

neophytosd

in index.tcl: changed unmounted.tcl to unmounted

Options
    • -2
    • +2
    ./www/admin/site-map/index.tcl
1:14 am

neophytosd

applied patch 112, user-login will wrongly redirect registered users to the register page if they have upper case characters in their email address. This patch changes the query to do the authentication comparison case insensitively.

Options
    • -1
    • +1
    ./www/register/user-login.xql
Thursday 14 Feb 2002
1:53 am

neophytosd

patches 141,142,143 by Gilbert Wong. Fixes broken awaiting-email-verification

Options
    • -1
    • +1
    ./www/register/awaiting-email-verification-oracle.xql
    • -6
    • +7
    ./www/register/awaiting-email-verification-postgresql.xql
    • -3
    • +3
    ./www/register/awaiting-email-verification.tcl
Sunday 10 Feb 2002
11:11 pm

neophytosd

applied patches 130,131,132,133,134,135,137

Options
    • -2
    • +5
    ./www/admin/site-map/index.tcl
    • -4
    • +6
    ./www/register/awaiting-email-verification-postgresql.xql
  3. … 6 more files in changeset.
Saturday 09 Feb 2002
3:33 am

donb

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

Options
    • -0
    • +1
    ./acs-subsite.info
    • -0
    • +35
    ./www/shared/session-update.tcl
  3. … 12 more files in changeset.
Monday 04 Feb 2002
7:52 pm

stevew

Reverse a change introduced in rev 1.4 which breaks the group-new

admin page

Options
    • -1
    • +1
    ./tcl/package-procs-oracle.xql
Wednesday 23 Jan 2002
3:05 am

ben

added user service contract

Options
    • -0
    • +1
    ./acs-subsite.info
    • -1
    • +2
    ./sql/oracle/acs-subsite-create.sql
    • -0
    • +144
    ./sql/oracle/user-sc-create.sql
Tuesday 22 Jan 2002
9:08 pm

yon

parameterized url of community member page; changed some procs to use the parameter; changed some pages to use the procs instead of linking directly

Options
    • -1
    • +1
    ./www/pvt/home.adp
    • -2
    • +2
    ./www/shared/community-member.tcl
    • -3
    • +3
    ./www/shared/portrait.tcl
  4. … 2 more files in changeset.
Wednesday 16 Jan 2002
9:07 pm

donb

1. home.tcl - applied patch from SDM to use ad_pvt_home rather than a

fixed value.

2. defs-procs.tcl - applied patch that fixed a "link within a link" problem.

3. content_item.tree_sortkey had no index (gulp!)

Options
    • -2
    • +2
    ./www/pvt/home.tcl
  2. … 2 more files in changeset.
Thursday 13 Dec 2001
3:00 am

donb

switched this to use "all_object_party_privilege_map" ...

Options
    • -1
    • +1
    ./www/permissions/index-postgresql.xql
Sunday 09 Dec 2001
5:21 am

donb

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

Options
    • -3
    • +3
    ./www/admin/site-map/index-postgresql.xql
  2. … 18 more files in changeset.
Saturday 08 Dec 2001
2:17 am

donb

Changed the representation of tree_sortkeys from "text" to "bit varying".

Options
    • -2
    • +2
    ./www/admin/relations/add-postgresql.xql
  2. … 62 more files in changeset.
Friday 07 Dec 2001
11:46 pm

arjun

Move "children_count" query from .xql to here.

Options
    • -0
    • +10
    ./www/permissions/one-postgresql.xql
11:45 pm

arjun

Added oracle-specific "children_count" query which was in the .xql file

Options
    • -0
    • +11
    ./www/permissions/one-oracle.xql
11:44 pm

arjun

Removed PG-specific query from SQL92 file.

Options
    • -13
    • +0
    ./www/permissions/one.xql
Tuesday 04 Dec 2001
1:20 am

donb

Switched tree-based queries to a tree-using form, which will greatly enhance

scalability...

Options
    • -3
    • +4
    ./tcl/application-group-procs-postgresql.xql
    • -5
    • +4
    ./tcl/attribute-procs-postgresql.xql
    • -13
    • +8
    ./tcl/package-procs-postgresql.xql
    • -1
    • +1
    ./tcl/party-procs-postgresql.xql
    • -6
    • +5
    ./tcl/rel-types-procs-postgresql.xql
    • -1
    • +1
    ./tcl/relation-procs-postgresql.xql
    • -1
    • +1
    ./tcl/subsite-callback-procs-postgresql.xql
    • -2
    • +1
    ./tcl/subsite-procs-postgresql.xql
    • -1
    • +1
    ./www/admin/group-types/index-postgresql.xql
    • -1
    • +1
    ./www/admin/group-types/new-postgresql.xql
    • -1
    • +1
    ./www/admin/group-types/one-postgresql.xql
    • -1
    • +1
    ./www/admin/group-types/rel-type-add-postgresql.xql
    • -2
    • +1
    ./www/admin/groups/elements-display-list-postgresql.xql
    • -2
    • +1
    ./www/admin/groups/new-postgresql.xql
    • -5
    • +5
    ./www/admin/groups/rel-type-add-postgresql.xql
  16. … 12 more files in changeset.
Thursday 29 Nov 2001
3:11 am

donb

Put the .info file in alignment with this package's world...

Options
    • -24
    • +24
    ./acs-subsite.info
Wednesday 28 Nov 2001
11:01 pm

donb

More permissions speeding up, or at least that is the theory...

Options
    • -5
    • +7
    ./www/admin/rel-segments/constraints/index.xql
7:39 pm

donb

First round of speedups for verious permissions issues. Key finding is that

the all_object_party_privilege_map is speedy in PostgreSQL and apparently in

Oracle, as well (having re-read some of the optimization threads).

Options
    • -2
    • +2
    ./www/admin/group-types/delete-2.xql
    • -4
    • +1
    ./www/admin/group-types/index-postgresql.xql
    • -4
    • +1
    ./www/admin/rel-segments/index-postgresql.xql
    • -0
    • +12
    ./www/admin/rel-segments/one-postgresql.xql
    • -0
    • +24
    ./www/admin/rel-types/delete-2-postgresql.xql
    • -5
    • +2
    ./www/admin/rel-types/one-postgresql.xql
    • -5
    • +2
    ./www/admin/rel-types/rels-list-postgresql.xql
    • -2
    • +2
    ./www/permissions/index-oracle.xql
    • -2
    • +2
    ./www/permissions/index-postgresql.xql
    • -1
    • +1
    ./www/permissions/one-oracle.xql
    • -1
    • +1
    ./www/permissions/one-postgresql.xql
    • -7
    • +3
    ./www/permissions/one.xql
  13. … 12 more files in changeset.
Tuesday 27 Nov 2001
7:08 am

ben

updated package_instantiate_object for PG

Options
    • -0
    • +8
    ./tcl/package-procs-postgresql.xql
Wednesday 21 Nov 2001
6:24 am

ben

took out extraneous logging notices

Options
    • -11
    • +1
    ./tcl/package-procs.tcl
6:20 am

ben

updated package procs and relation procs to provide better handling of

additional variables. This *may* cause some things to break, and the added

functionality is not yet PG-compatible. It will be soon, though. (ben)

Options
    • -1
    • +1
    ./tcl/package-procs-oracle.xql
    • -5
    • +90
    ./tcl/package-procs.tcl
    • -1
    • +8
    ./tcl/relation-procs.tcl