• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
file image-doc.tcl was initially added on branch oacs-5-8.

- fix image.vuh for invalid urls: in case the path is invalid, the variable object_id is not set and can't be contained in error message

- use compilable expressions

- use "in" operator instead of "lsearch"

- use tcl 8.5 extended index format for "string range"

- brace expressions to allow for tcl compilation

  1. … 8 more files in changeset.
- improve spacing

- use "lassign" instead of "util_unlist"

  1. … 19 more files in changeset.
- remove deprecated call to ad_header

- use standard templating

- remove deprecated call of ad_header

    • -23
    • +23
    ./admin/site-map/parameter-set.tcl
file parameter-set.adp was initially added on branch oacs-5-8.

    • -0
    • +0
    ./admin/site-map/parameter-set.adp
file revoke.adp was initially added on branch oacs-5-8.

    • -0
    • +0
    ./permissions/revoke.adp
- use standard templating

- fix HTML

- remove call to deprecated ad_header

- fix gor bug #3174. subsites disappeared from sitemap, when a hard coded value was surpassed

- use property "doc(title)" throughout oacs-5-8 instead of "title" to get rid of warnings in error.log of the form:

Warning: /forums/message-view has no doc(title) set.

Using doc(title) is required in blank-master.tcl but was used so far only in a few packages

    • -1
    • +1
    ./admin/applications/application-add.adp
  1. … 323 more files in changeset.
- replace deprecated "export_url_vars" by "export_vars -url", rewriting syntax

- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

    • -1
    • +1
    ./admin/group-types/change-join-policy.tcl
    • -1
    • +1
    ./admin/group-types/groups-display.tcl
    • -1
    • +1
    ./admin/group-types/rel-type-add-2.tcl
  1. … 107 more files in changeset.
- replace deprecated "export_form_vars" by "export_vars -form"

- replace deprecated "ad_export_vars" by "export_vars"

    • -2
    • +2
    ./admin/group-types/change-join-policy.tcl
    • -2
    • +2
    ./admin/group-types/groups-display.tcl
    • -2
    • +2
    ./admin/group-types/rel-type-add-2.tcl
  1. … 58 more files in changeset.
- revert form_vars update

    • -1
    • +1
    ./admin/group-types/change-join-policy.tcl
    • -1
    • +1
    ./admin/group-types/groups-display.tcl
    • -1
    • +1
    ./admin/group-types/rel-type-add-2.tcl
  1. … 68 more files in changeset.
- replace deprecated "export_form_vars" by "export_vars -form"

- replace deprecated "ad_export_vars" by "form_vars"

    • -2
    • +2
    ./admin/group-types/change-join-policy.tcl
    • -2
    • +2
    ./admin/group-types/groups-display.tcl
    • -2
    • +2
    ./admin/group-types/rel-type-add-2.tcl
  1. … 39 more files in changeset.
- replace deprecated "export_form_vars" by "form_vars"

  1. … 24 more files in changeset.
- replace deprecated "site_node_closest_ancestor_package_url" by "lindex [site_node::get_url_from_object_id -object_id [site_node::closest_ancestor_package ...]] 0"

    • -1
    • +1
    ./permissions/perm-user-add-include.tcl
- replace deprecated "ad_get_user_id" by "ad_conn user_id"

  1. … 6 more files in changeset.
- replace deprecated "ad_require_permission" by "permission::require_permission"

    • -1
    • +1
    ./admin/rel-segments/elements-display.tcl
    • -2
    • +2
    ./admin/rel-segments/constraints/one.tcl
  1. … 54 more files in changeset.
- remove deprecated call ad_privacy_threshold

- replace deprecated ad_permission_p with permission::permission_p

    • -3
    • +3
    ./admin/groups/elements-by-rel-type.tcl
    • -2
    • +2
    ./admin/groups/elements-display-list.tcl
    • -1
    • +1
    ./admin/rel-segments/elements-display.tcl
    • -2
    • +2
    ./admin/rel-segments/constraints/one.tcl
  1. … 18 more files in changeset.
- change widget from "allhtml" to "html" on (potential) non-admin pages (thanks to Frank Bergmann for the suggestion)

Getting rid of last calls to deprecated ad_table. Instead using the list-builder. There is still one call to ad_table within acs-subsite but this page is not linked from anywhere anymore ( probably we remove it later ).

  1. … 6 more files in changeset.
- get rid of empty_string_p in non-deprecated code

- make use of tcl byte-code compiler

    • -3
    • +3
    ./admin/groups/elements-display-list.tcl
  1. … 29 more files in changeset.
Rewriting acs_permission__permission_p function to use recursive queries ( available in PG since 8.4 ) and modifiying

queries around core packages to avoid checking persmissions using a subquery on the acs_object_party_privilege_map view.

    • -0
    • +53
    ./admin/site-map/index-postgresql.xql
    • -0
    • +51
    ./admin/site-map/site-map-postgresql.xql
  1. … 12 more files in changeset.
- replace deprecated command "ns_unlink" with native tcl command "file delete"

  1. … 7 more files in changeset.
changed ad_return_error to ad_return_exception_page 404 with same message, because error is not with system, but with request. This helps prevent bots from retrying when user no longer exists etc.