• last updated 39 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 73 more files in changeset.
don't allow null for supertype in acs_object_type__create_type. default to 'acs_object'

Added a Ben Adida fix from the Oracle version.

fixed order of loading to allow all_object_party_privilege_map to be created before acs_gropu body

Added C. R. Oldham's patch to fix membership testing (unimplemented in ACS

4.2). Ported it to PG on the way ...

    • -7
    • +18
    ./postgresql/groups-body-create.sql
  1. … 6 more files in changeset.
added person.first_names, person.last_name, party.email functions to person and party packages, as well as porting to their postgresql equivelants

    • -0
    • +49
    ./postgresql/community-core-create.sql

Minor typo, another apostrophe catastrophe.

Added "iscachable" to "tree_ancestor_p".

fixed remove_user function to do the right things

fixed an efficiency issue in removing objects

changed incorrect/confusing error text

Fixing incorrect and confusing error text.

Moved from 7/15 bit keys to 7/31 bit keys to accomodate big flat trees.

fixed instr for searching backwards

I accidently included a change intended for use with PG 7.2 in my previous

commit. This had a couple of idiotic typos that broke installation...

    • -1
    • +10
    ./postgresql/groups-body-create.sql

Fixed the 4K character limit on session properties for Oracle by making an

optional "clob" value available. The APM wouldn't let me load any packages

when I added all the dotLRN packages plus standard packages over to a new

"dotlrn" user from my normal "acs" user - the list of packages grew to

> 4KB in size! Grrrr!

  1. … 6 more files in changeset.

Renamed a column named "timestamp" in the security package because this is

now a reserved word in PG (correctly). I changed the Oracle version, too,

because I know that 9i has added the "timestamp" datatype and even if it

will accept it as a column name it's confusing.

I also changes postgresql.sql to load correctly under PG 7.1 and 7.2.

  1. … 6 more files in changeset.

Incorporated Marc Fournier's PG 7.2 fix for finding comments on a column.

New checks for proper PG configuration and some PG 7.1 vs. PG 7.2 changes

in postgresql.sql (which now checks at varies its behavior according to

the version being run).

  1. … 1 more file in changeset.

added privacy control

    • -0
    • +24
    ./oracle/acs-create-2.sql
    • -0
    • +19
    ./postgresql/acs-create-2.sql
  1. … 1 more file in changeset.

Oops added a couple of comments with single apostrophes within a quoted

string (PL/pgSQL function body)

Fixed some errors in my earlier hacking on hierarchical queries...

  1. … 3 more files in changeset.

Improved this slightly ...

    • -12
    • +17
    ./postgresql/acs-relationships-create.sql

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

    • -87
    • +7
    ./postgresql/acs-metadata-create.sql
    • -63
    • +9
    ./postgresql/acs-objects-create.sql
    • -25
    • +17
    ./postgresql/acs-relationships-create.sql
  1. … 14 more files in changeset.

Changed the representation of tree_sortkeys from "text" to "bit varying".

    • -18
    • +14
    ./postgresql/acs-metadata-create.sql
    • -20
    • +16
    ./postgresql/acs-objects-create.sql
    • -13
    • +15
    ./postgresql/acs-permissions-create.sql
    • -241
    • +204
    ./postgresql/postgresql.sql
    • -17
    • +13
    ./postgresql/site-nodes-create.sql
  1. … 57 more files in changeset.
made /pvt/home configurable

    • -2
    • +16
    ./postgresql/acs-objects-create.sql
  1. … 3 more files in changeset.

1. Replaced more "tree_sortkey like" with "tree_sortkey between" expressions

2. Fixed a bad port of an Oracle query in site-nodes-procs.tcl and removed

a needless outer join from both versions in the process.

    • -3
    • +3
    ./postgresql/acs-permissions-create.sql
    • -10
    • +6
    ./postgresql/acs-relationships-create.sql
    • -8
    • +4
    ./postgresql/rel-constraints-create.sql
    • -19
    • +14
    ./postgresql/rel-segments-create.sql
  1. … 4 more files in changeset.

Check the comments in postgresql.sql - my previous commit didn't quite work

as expected.

I also removed an ugly assumption made in the PG port in bboard-procs.tcl.

  1. … 2 more files in changeset.

Added "tree_left" and "tree_right" in order to optimize tree queries, which

I did for the bboard package. "LIKE (tree_sortkey || %)" never uses the

index as we thought it did, as it turns out ... see postgresql.sql for

example queries that do.

  1. … 2 more files in changeset.

First round of speedups for verious permissions issues. Key finding is that

the all_object_party_privilege_map is speedy in PostgreSQL and apparently in

Oracle, as well (having re-read some of the optimization threads).

    • -36
    • +78
    ./postgresql/acs-permissions-create.sql
  1. … 23 more files in changeset.