• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code reviewed the authority API

Code reviewed password management procs

Use API to test email verification

    • -11
    • +12
    ./test/acs-authentication-procs.tcl
Fixed auth_confirm_email test case after renaming the proc

Made register link remember username

  1. … 3 more files in changeset.
Added a switch to auth::create_user to say that you want password_confirm verified

  1. … 1 more file in changeset.
Caching of auth::authority::get_id

Code reviewed and fixed things

    • -688
    • +473
    ./authentication-procs.tcl
    • -0
    • +562
    ./password-procs.tcl
    • -119
    • +147
    ./test/acs-authentication-procs.tcl
refactoring user registration to use new ext-auth API

  1. … 2 more files in changeset.
forgotten_pwd_url was set to forgotten-password by default, changed it to recover-password

Moved ad_maybe_redirect_for_registration over to auth::require_login

  1. … 1 more file in changeset.
Changed auth_create_user test case to test the API design

    • -8
    • +27
    ./test/acs-authentication-procs.tcl
Use username instead of email for the auth_authenticate test case

    • -15
    • +16
    ./test/acs-authentication-procs.tcl
invoking array unset before array set in testcases where appropriate as array set command doesn't re-initialize an array

    • -3
    • +11
    ./test/acs-authentication-procs.tcl
adding xql files for driver procs that I forgot to add earlier

    • -0
    • +17
    ./driver-procs-oracle.xql
    • -0
    • +16
    ./driver-procs-postgresql.xql
making sure auth::authenticate proc sets appropriate auth_message and account_message values. Also, the account_message is the concatenation of the local and remote values

Moved the rowid query for email verification into XQL files

    • -0
    • +12
    ./authentication-procs-oracle.xql
    • -0
    • +12
    ./authentication-procs-postgresql.xql
making Tcl API tests pass for Oracle

    • -1
    • +1
    ./test/acs-authentication-procs-oracle.xql
*** empty log message ***

    • -0
    • +14
    ./authority-procs.xql
updated tests to work with auth::password::recover_password

Fixed email verification for Oracle, refactored, error checking

doc update

changed auth::password::forgotten to auth::password::recover_password

bugfix: typo in message lookup

adding params for service contract implementations

    • -0
    • +4
    ./acs-authentication-init.tcl
    • -1
    • +103
    ./test/acs-authentication-procs.tcl
fixing the authority API and adding tests for it

    • -0
    • +41
    ./authority-procs-oracle.xql
    • -0
    • +37
    ./authority-procs-postgresql.xql
    • -6
    • +85
    ./test/acs-authentication-procs.tcl
adding API and tests for password management API (EXT-AUTH-05)

    • -0
    • +28
    ./test/acs-authentication-procs-oracle.xql
    • -0
    • +29
    ./test/acs-authentication-procs-postgresql.xql
    • -117
    • +149
    ./test/acs-authentication-procs.tcl
adding Tcl API and tests for EXT-AUTH-3: Account creation API

    • -7
    • +96
    ./test/acs-authentication-procs.tcl
making the auth_authentication test case pass. Fixing a few bugs and adding some error handling to the authentication proc. Simon has added other test cases that have not been finished yet

    • -5
    • +239
    ./test/acs-authentication-procs.tcl
Synced with the actual columns in the table