• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- remove duplicated package (in contrib/packages and in packages) from contrib to reduce confusion

    • -106
    • +0
    ./catalog/general-comments.da_DK.ISO-8859-1.xml
    • -108
    • +0
    ./catalog/general-comments.de_DE.ISO-8859-1.xml
    • -113
    • +0
    ./catalog/general-comments.en_US.ISO-8859-1.xml
    • -106
    • +0
    ./catalog/general-comments.es_ES.ISO-8859-1.xml
    • -74
    • +0
    ./catalog/general-comments.fi_FI.ISO-8859-15.xml
    • -106
    • +0
    ./catalog/general-comments.gl_ES.ISO-8859-1.xml
    • -24
    • +0
    ./catalog/general-comments.it_IT.ISO-8859-1.xml
    • -106
    • +0
    ./catalog/general-comments.nl_NL.ISO-8859-1.xml
    • -106
    • +0
    ./catalog/general-comments.no_NO.ISO-8859-1.xml
    • -106
    • +0
    ./catalog/general-comments.pl_PL.ISO-8859-2.xml
    • -107
    • +0
    ./catalog/general-comments.pt_BR.ISO-8859-1.xml
    • -106
    • +0
    ./catalog/general-comments.ru_RU.windows-1251.xml
  1. … 89 more files in changeset.
Update TODO to reflect reality of current practices

change ad_verify_and_get_user_id to ad_conn user_id, change ad_maybe_redirect_for_registration to auth::require_login, make some db_ and dt_ function -public

  1. … 687 more files in changeset.
Fixed problem in xql file: it was not parsable, now it is.

Ported to oracle.

    • -99
    • +163
    ./sql/oracle/general-comments-plsql-create.sql
Fixing tabs.

    • -28
    • +25
    ./tcl/general-comments-procs.tcl
Fixing a few porting bugs.

    • -11
    • +11
    ./sql/oracle/general-comments-create.sql
merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 598 more files in changeset.
Oracle9i porting changes

- Changed procedure names from delete to del

- Changed view declaration to use actual column names

- Changed "rel_constraints_violated_one" and "rel_constraints_violated_two"

(http://openacs.org/forums/message-view?message_id=81045)

    • -2
    • +2
    ./sql/oracle/general-comments-drop.sql
  1. … 275 more files in changeset.
Remove old file.

Remove comment-edit files, add replacement add-edit files.

    • -0
    • +27
    ./www/comment-add-edit-oracle.xql
    • -52
    • +0
    ./www/comment-edit-3-postgresql.xql
Remove generic xql file, move to database specific xql. Comment-add-edit now

works for add and edit.

    • -0
    • +25
    ./www/comment-add-edit-postgresql.xql
Added xql file. Fixed datamodel to reflect general_comments subtype of

content_item. Added plsql api for adding a new revision of a comment.

    • -82
    • +117
    ./sql/postgresql/general-comments-plsql-create.sql
    • -1
    • +1
    ./tcl/general-comments-procs-postgresql.xql
    • -0
    • +20
    ./www/comment-add-edit.xql
General_comments references cr_items. None of the attributes in general_comments should be versioned.

Fix noquote problems. Move comment-edit.xql to comment-add-edit.xql

Recover lost file.

Adding missing adp file.

    • -0
    • +1
    ./www/comment-add-edit.adp
Moved to comment-add-edit.

    • -0
    • +1
    ./www/comment-add-edit.tcl
Rename comment-add to comment add-edit. Using ad_form one can do add and edit.

Added database specific xql files for url add/edit.

    • -0
    • +25
    ./www/url-add-edit-oracle.xql
    • -0
    • +31
    ./www/url-add-edit-postgresql.xql
Replaced seperate url add and edit files with url-add-edit ad_form based

script.

Update form to use ad_form, combine add and edit into one tcl/adp pair.

    • -0
    • +83
    ./www/url-add-edit.tcl
    • -0
    • +14
    ./www/url-add-edit.xql
Move adp file too!

    • -0
    • +8
    ./templates/comments.adp
Moved include to templates directory

    • -0
    • +37
    ./templates/comments.tcl
Started work on oracle data model upgrade. PL/SQL exists, but is unported.

    • -16
    • +35
    ./sql/oracle/general-comments-create.sql
    • -0
    • +106
    ./sql/oracle/general-comments-plsql-create.sql
Adding and displaying comments works with existing applications.

    • -3
    • +3
    ./sql/postgresql/general-comments-drop.sql
    • -7
    • +22
    ./tcl/general-comments-procs-postgresql.xql
    • -133
    • +18
    ./tcl/general-comments-procs.tcl
more work on plsql api

Adding new tcl api

    • -3
    • +27
    ./tcl/general-comments-procs-postgresql.xql
    • -136
    • +50
    ./tcl/general-comments-procs.tcl
Adding includable template to display comments.

noquote changes (Dirk Gomez)

  1. … 62 more files in changeset.