• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- get rid of some more empty_string_p

- use common parameter definition conventions (get rid of old-style nonpos args)

- do not raise error on duplicate dependencies

- follow formatting conventions

- remove some more "empty_string_p" occurances

    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/applets-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/dotlrn-master.tcl
- use $$ quoting in postgres SQL

- use name parameter for SQL functions

- favor tcl-compilable string comparisons

- brace expressions

- replace deprecated "acs_sc_call" by "acs_sc::invoke"

- bump version number to indicate compatibility with 5.8.1

  1. … 5 more files in changeset.
- use $$ quoting in postgres SQL

- use name parameter for SQL functions

- provide compatility with pg9

- replace deprecated "acs_sc_call" by "acs_sc::invoke"

- replace deprecated "ad_maybe_redirect_for_registration" by "auth::require_login"

- brace expressions

- favor tcl-compilable string comparisons

- don't use numeric comparison operator for non-numeric arguments

- use numeric comparison operator for truth value comparisons

- use "in" or "ni" expression instead of "lsearch"

- bump version number to indicate compatibility with 5.8.1

    • -10
    • +11
    /openacs-4/packages/dotlrn/dotlrn.info
    • -13
    • +16
    /openacs-4/packages/dotlrn/install.xml
    • -3
    • +3
    /openacs-4/packages/dotlrn/lib/member-email.tcl
  1. … 132 more files in changeset.
- fix partial SQL edit

- use "lassign" instead of multiple "lindex" operations

- replace 3 further depreacted "ad_parameter" by parameter::get

- don't return "internal server error" in case the user id is missing

overhaul of package:

- favor tcl-compilable string comparisons

- don't use numeric comparison operator for non-numeric arguments

- brace expressions

- replace depreacted "ad_parameter" by parameter::get

- use "in" or "ni" expression instead of "lsearch"

- use tcl 8.5 extended index format for "string range"

  1. … 6 more files in changeset.
- make function more robust against invalid input

- add missing dollar symbols, otherwise api-code browser shows incomplete results for xotcl methods

- replace mulitple "lindex" operations by "lassign"

- don't call fings pairs, which have more than two elements

- use "lassign" instead of mulitple "set ... [lindex ...]" command

- remove needless quotes from numeric comparisons

- quote pattern

- use numeric comparison operator for truth value comparisons

- use "lassign" instead of "foreach ... break" idiom

- use numeric comparison operator for truth value comparisons

- modernize tcl coding

- remove needless quotes from numeric comparison

- remove needless quotes from numeric comparisons

- use tcl 8.5 expand operator instead of "eval"

- simplify regular expression handling

- replace "foreach ... break" idiom by "lassign"

- remove unneeded expr from condition in "for" loop

    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -2
    • +2
    /openacs-4/packages/search/www/search.tcl
- replace "foreach ... break" idiom by "lassign"

- reimplementation of util_memoize cache for NaviServer. The original

implementation of the util-memoize functions was based on "manual expirations"

(every cached entry was a pair of value + timestamp). This is not needed

on naviserver, since NaviServer allows us to specify for every entry

directly an expire time, which is implemented internally. The new

has the advantage that (a) it is faster, (b) more secure (no race conditions),

(c) smaller memory footprint (not only storing the timestamp is not needed;

furthermore invalidation of timed-out entries happend in the old version only,

when the entry was fetched; in practice (openacs.org) many dead entries

where kept, the size wen down by 90%), (d) due to small number of entries

the search in the keys is much faster.

    • -113
    • +261
    /openacs-4/packages/acs-tcl/tcl/memoize-procs.tcl
- call ds_init for all types of concrete files for which handlers are registered

- fix 2 typos

- add missing commits for more light-weight developer support integration

- use variable ::acs::rootdir instead of function