OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 26 Nov
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 141

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Jul 2015
1:03 am

gustafn

- fix subtle quoting bug: the substitution of

#package_key.message_key# happens via regex on the resulting page

late in the layout process. When a message contains %-substitution

variables, at least these values have to be html-escaped.

The bug showed up e.g. on OpenACS.org in the forums, when

a subject line contained a double quote (e.g. in the .LRN Q&A forum,

message "My applet doesn't appear ...". Since the layout is produced

via

<a href="@messages.message_url@" title="#forums.goto_thread_subject#">

and the message key is defined as

Go to thread %messages.subject%

the HTML title attribute was terminated prematurely by the double

quote of the subject line and the remainder was invalid HTML.

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
Thursday 02 Jul 2015
10:03 pm

gustafn

- update documentation

Options
    • -5
    • +5
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/templates.xml
9:26 pm

gustafn

- don't raise an error on missing substitution variables, but write an error to the error.log (otherwise, one can get recursive errors on missing variables)

Options
    • -3
    • +4
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
9:24 pm

gustafn

- improve readability

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/admin/groups/elements-by-group-type.adp
9:22 pm

gustafn

- remove ignored sql statement

Options
    • -4
    • +2
    /openacs-4/packages/general-comments/www/delete-2.tcl
9:20 pm

gustafn

- use more precise data types

Options
    • -4
    • +4
    /openacs-4/packages/bug-tracker/www/bug.tcl
9:19 pm

gustafn

- strengthen page contracts

Options
    • -4
    • +4
    /openacs-4/packages/acs-api-browser/www/proc-view.tcl
    • -4
    • +4
    /openacs-4/packages/search/www/search.tcl
9:12 pm

gustafn

- backport from head to ease using HEAD modules

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +23
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
11:22 am

gustafn

- harden page contracts

Options
    • -5
    • +5
    /openacs-4/packages/xotcl-core/www/show-class-graph.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/www/show-object.tcl
Wednesday 01 Jul 2015
9:40 pm

gustafn

- use export_vars for url-generation

Options
    • -8
    • +7
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
8:41 pm

gustafn

- improve validity of HTML

Options
    • -1
    • +1
    /openacs-4/packages/download/www/help.adp
    • -2
    • +3
    /openacs-4/packages/download/www/index.adp
    • -15
    • +15
    /openacs-4/packages/download/www/index.tcl
    • -4
    • +4
    /openacs-4/packages/download/www/admin/index.adp
    • -4
    • +3
    /openacs-4/packages/download/www/admin/report-by-ip.adp
    • -3
    • +3
    /openacs-4/packages/download/www/admin/report-by-ip.tcl
    • -3
    • +5
    /openacs-4/packages/download/www/admin/report-by-user.adp
    • -3
    • +3
    /openacs-4/packages/download/www/admin/report-by-user.tcl
    • -1
    • +2
    /openacs-4/packages/download/www/admin/repository-metadata.adp
    • -0
    • +3
    /openacs-4/packages/download/www/admin/repository-reasons.adp
    • -2
    • +2
    /openacs-4/packages/download/www/admin/repository-types.adp
8:00 pm

gustafn

- fix typos

Options
    • -3
    • +3
    /openacs-4/packages/download/www/index.tcl
7:57 pm

gustafn

- improve validity of HTML

Options
    • -3
    • +3
    /openacs-4/packages/download/www/index.adp
    • -25
    • +30
    /openacs-4/packages/download/www/index.tcl
10:58 am

gustafn

- fix HTML validity of plsql-subprogram-one, proc-browse and tcl-proc-view

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/plsql-subprogram-one.adp
    • -4
    • +6
    /openacs-4/packages/acs-api-browser/www/proc-browse.adp
    • -7
    • +4
    /openacs-4/packages/acs-api-browser/www/tcl-proc-view.adp
10:56 am

gustafn

- strengthen page contracts

Options
    • -3
    • +3
    /openacs-4/packages/acs-api-browser/www/plsql-subprogram-one.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/procs-file-view.tcl
Tuesday 30 Jun 2015
11:14 pm

gustafn

- use stored procedure sec_session_property__upsert

Options
    • -1
    • +10
    /openacs-4/packages/acs-tcl/tcl/security-procs-oracle.xql
    • -0
    • +9
    /openacs-4/packages/acs-tcl/tcl/security-procs-postgresql.xql
    • -20
    • +28
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
11:08 pm

gustafn

- add stored procedure sec_session_property__upsert to address concurrency problems with

updates in sec_session_properties; implementation for PostgreSQL and

Oracle are added, latter is not tested.

- bump version number to 5.9.0d4

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -1
    • +47
    /openacs-4/packages/acs-kernel/sql/oracle/security-create.sql
    • -1
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/security-drop.sql
    • -0
    • +45
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.9.0d3-5.9.0d4.sql
    • -1
    • +44
    /openacs-4/packages/acs-kernel/sql/postgresql/security-create.sql
    • -1
    • +5
    /openacs-4/packages/acs-kernel/sql/postgresql/security-drop.sql
    • -0
    • +40
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.9.0d3-5.9.0d4.sql
10:19 pm

gustafn

- adjust return status information

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
1:39 pm

gustafn

- add function args missed by earlier upgrades

- bump version numbers

Options
    • -2
    • +2
    /openacs-4/packages/acs-events/acs-events.info
    • -0
    • +48
    /openacs-4/packages/acs-events/sql/postgresql/upgrade/upgrade-0.6d7-0.6d8.sql
    • -2
    • +2
    /openacs-4/packages/acs-messaging/acs-messaging.info
    • -0
    • +18
    /openacs-4/packages/acs-messaging/sql/postgresql/upgrade/upgrade-5.9.0d1-5.9.0d2.sql
    • -2
    • +2
    /openacs-4/packages/categories/categories.info
    • -0
    • +29
    /openacs-4/packages/categories/sql/postgresql/upgrade/upgrade-1.1.3d3-1.1.3d4.sql
    • -2
    • +2
    /openacs-4/packages/file-storage/file-storage.info
    • -0
    • +16
    /openacs-4/packages/file-storage/sql/postgresql/upgrade/upgrade-5.9.0d1-5.9.0d2.sql
    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -0
    • +21
    /openacs-4/packages/forums/sql/postgresql/upgrade/upgrade-1.3d10-1.3d11.sql
11:26 am

gustafn

- provide a friendly message in case the xowiki_form_instance_item_index was not setup correctly

Options
    • -2
    • +9
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
11:22 am

gustafn

- increase verbosity of upgrade script

Options
    • -2
    • +9
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
11:20 am

gustafn

- don't build db-stubs for trigger functions

Options
    • -1
    • +8
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
Monday 29 Jun 2015
8:52 pm

gustafn

- strengthen page-cpntracts

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/tcl-doc-search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/tcl-proc-view.tcl
8:49 pm

gustafn

- add colon to the alloed characters of a token for page-contracts, to make it usable for api-browser

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
8:46 pm

gustafn

- fix bug, when "dfs" was specified

Example: http://openacs.org/search/search?q=Spam&dfs=m3

Options
    • -4
    • +4
    /openacs-4/packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl
6:34 pm

gustafn

- fix for bug #3256

- provide a simple templated error page

Options
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/filter-procs.tcl
    • -0
    • +8
    /openacs-4/packages/acs-content-repository/www/index.adp
    • -11
    • +2
    /openacs-4/packages/acs-content-repository/www/index.vuh
3:15 pm

gustafn

- fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/sql/display-sql.tcl
1:08 pm

gustafn

- get rid of the pesky "MISSING FORMWIDGET: search:search:formbutton:ok" message

Options
    • -2
    • +2
    /openacs-4/packages/forums/lib/search/search-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/search/search-form.tcl
1:03 pm

gustafn

- protect against attacks against form:id

Options
    • -15
    • +15
    /openacs-4/packages/acs-templating/resources/forms/standard.adp
    • -1
    • +3
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -21
    • +17
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
1:00 pm

gustafn

- protect against i18n message key substitution in ds_comments (in case the message i18n needs variables, this will fail anyhow)

Options
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/tcltrace-procs.tcl