• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Updated release notes to reflect final release.

    • -161
    • +13
    ./acs-core-docs/www/release-notes.html
Took out Oracle support for ETP as it doesn't work.

One quick fix to etp oracle

    • -0
    • +2
    ./edit-this-page/tcl/etp-procs-oracle.xql
Fixed SDM #1533 by applying patch #251: /admin/users/new.tcl breaks on PostgreSQL with a "query didn't return any rows" from the rel_type_info query. I've debugged and fixed this.

    • -1
    • +1
    ./acs-subsite/www/admin/users/new-postgresql.xql
Updated .info files of all core packages to version 4.5

    • -6
    • +10
    ./acs-api-browser/acs-api-browser.info
    • -9
    • +10
    ./acs-bootstrap-installer/acs-bootstrap-installer.info
    • -5
    • +6
    ./acs-content-repository/acs-content-repository.info
    • -16
    • +99
    ./acs-core-docs/acs-core-docs.info
    • -4
    • +7
    ./acs-core-docs/www/xml/install-guide/os.xml
    • -3
    • +5
    ./acs-service-contract/acs-service-contract.info
  1. … 8 more files in changeset.

1) Added local vars to end of each xml file so that psgml-mode works properly

2) Added disclaimer to authorblurb stylesheet

3) Minor fixes to install guide

    • -116
    • +3
    ./acs-core-docs/www/acs-dev.html
    • -223
    • +66
    ./acs-core-docs/www/aolserver.html
    • -486
    • +114
    ./acs-core-docs/www/apm-design.html
    • -704
    • +133
    ./acs-core-docs/www/apm-requirements.html
    • -120
    • +33
    ./acs-core-docs/www/bootstrap-acs.html
    • -73
    • +16
    ./acs-core-docs/www/credits.html
    • -474
    • +189
    ./acs-core-docs/www/db-api-detailed.html
    • -446
    • +188
    ./acs-core-docs/www/db-api.html
    • -52
    • +2
    ./acs-core-docs/www/developers-overview.html
    • -407
    • +118
    ./acs-core-docs/www/docbook-primer.html
    • -152
    • +21
    ./acs-core-docs/www/eng-standards-constraint-naming.html
    • -247
    • +77
    ./acs-core-docs/www/eng-standards-filenaming.html
    • -124
    • +29
    ./acs-core-docs/www/eng-standards-plsql.html
  1. … 101 more files in changeset.
fixed bug in apm_package_version__upgrade_p

    • -2
    • +2
    ./acs-kernel/sql/postgresql/apm-create.sql
Added upgrade script for CR 4.1.2->4.5

Committed Vinod Kurup's patch #1502 which fixed a file-storage bug.

Fixed more date and currency bugs, for the most part

    • -9
    • +67
    ./acs-templating/tcl/currency-procs.tcl
    • -14
    • +39
    ./acs-templating/tcl/date-procs.tcl
    • -1
    • +21
    ./acs-templating/tcl/element-procs.tcl
confirm-button - useful in confirm pages used with the form builder and

especially the forthcoming "ad_form" wrapper proc.

coddo.adp and plain.adp are sample form templates

    • -0
    • +104
    ./acs-templating/resources/forms/coddo.adp
    • -0
    • +86
    ./acs-templating/resources/forms/plain.adp
Fixed the long-annoying "Your Workspace" page's navigation - there's now a

link back to the home page.

Added new form style, used in the bug-tracker

Forgot to commit the changes acs-api-browser.info file when I committed the patch for SDM #1417.

    • -0
    • +2
    ./acs-api-browser/acs-api-browser.info
Added search of the Tcl man pages over at dev.scriptics.com, just like we can search AOLserver API pages at aolserver.com. SDM #1417

    • -0
    • +27
    ./acs-api-browser/www/tcl-doc-search.adp
    • -0
    • +33
    ./acs-api-browser/www/tcl-doc-search.tcl
template::multirow foreach feature, which loops over the rows in a multirow, setting local vars, executing a code block, and then resetting the values in the foreach. Useful in conjunction with template::multirow extend.

    • -19
    • +81
    ./acs-templating/tcl/query-procs.tcl
Added -extend switch to db_multirow and removed Arjun's regsub hack in same. db_multirow also sets the varname:columns list, and it checks that columns stay the same when you append. I've also added documentation, as per SDM #1486

    • -28
    • +92
    ./acs-tcl/tcl/00-database-procs.tcl
Fixed a bug in site_node_closest_ancestor_package.

Mostly fixed subsite issues with the PG version.

There was an error when trying to edit a spam that was either text or

html but not both, because I forgot to port the query spam_get_text to

postgres.

This has already been checked in but accidentially on the HEAD branch,

so this is a re-checkin to the oacs-4-5 branch. Conflicts are ok this

time, Don said.

    • -0
    • +10
    ./spam/www/admin/spam-edit-postgresql.xql

Most of this fixes up the creation of application groups for subsites.

Subsites - for PG at least - still have some serious problems that need

fixing.

    • -1
    • +7
    ./acs-api-browser/www/tcl-proc-view.adp
    • -185
    • +20
    ./acs-api-browser/www/tcl-proc-view.tcl
    • -10
    • +10
    ./acs-subsite/tcl/application-group-procs-oracle.xql
    • -10
    • +8
    ./acs-subsite/tcl/application-group-procs-postgresql.xql
    • -14
    • +3
    ./acs-subsite/tcl/application-group-procs.tcl
    • -1
    • +12
    ./acs-subsite/tcl/application-group-procs.xql
    • -1
    • +1
    ./acs-tcl/tcl/apm-procs-postgresql.xql

1. Hitting the site with the host name only (http://foo.com) reveals that

[ns_conn urlc] is incorrectly set to "1" and [ns_conn urlv] to [list "\"\""].

I've masked this in the ad_conn structure, so [ad_conn urlc] == 0 and

[ad_conn urlv] == [list].

2. When a cookie is set to an empty string, ad_set_cookie sets it to

"\"\"". I've modified ad_get_cookie to return the empty string if the

cookie it grabs from the browser is "\"\"". I looked quite carefully around

the toolkit and saw no code that appears to depend on this abberant behavior.

    • -1
    • +10
    ./acs-tcl/tcl/request-processor-procs.tcl

Robert Locke's bug fixes that make news work with PG 7.2 as well as PG 7.1

Added Lars Pind's patch #196 which lists out packages that didn't install

along with a reason.

    • -1
    • +11
    ./acs-admin/www/apm/packages-install.tcl

Applied Michael Steigman's patches 199-201, which fixes package spec/body

mismatches allowed by Oracle 8i but not by 9i.

  1. … 1 more file in changeset.

Applies Lars Pind's patch #206 which fixes some cookie problems.

Applied Tilmann Singer's patch #205 which sets the admin e-mail address as

the "from" field for e-mail mailed to a newly-registered user.

Applied Tom Jackson's patches that make random assigned passwords work.

    • -2
    • +2
    ./acs-subsite/www/register/user-login.tcl
    • -0
    • +8
    ./acs-subsite/www/register/user-new.adp

Applied Jowell Sabino's patch #215 which fixes a problem with image deletion.

removed backup files

    • -19
    • +0
    ./acs-api-browser/www/plsql-subprograms-all-oracle.xql~
    • -19
    • +0
    ./acs-api-browser/www/plsql-subprograms-all-postgresql.xql~