nsf

Clone Tools
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Address CID 88770

- Remove occurrences of deprecated Tcl Call Tcl_AppendResult() in overall code

- improve variable for logging from "debugLevel" to "logSeverity" (print logging messages which have a severity larger equal the then given value; so; "nsf::configure debugLevel 0" will print everything, and "nsf::configure debugLevel 3" will print just error messages and omit warnings etc.) - this is not a change in sematics, but removes some confusion in the code. therefore the configure name was not changed - Remove 2 occurrences of deprecated Tcl Call Tcl_AppendResult() in nsfStubLib

- don't compute string length twice

Address potential double freeing problem of runtime states: - the ExitHander() should never be called twice on the same interp. Therefore delete in the ExitProc the ExitHandler AND the ThreadExitHandler and in the ThreadExitProc also both.

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

code generator changes: - create enum types instead of enum values for nsf API - use enum types in code

Improve comment wording and cleanup

FreeFunPtrEntry is not needed actually

Fix refcounting

FreeFunPtrEntry(): Add deletion handler for cmddef and enumeration-type hash entries

nsfCmdDefinitions.c: Fix typos

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

Provide for releasing/deleting the hash tables for cmd definitions and enumeration-type converters in ExitHandler

remove various code smells: - add const declarations - prefer boolean tests - don't write "for" loops without a block - don't pass non-initialized value in an array on index [0] - reduce variable scope - prefer single returns statements in functions - dont't use CONST unless defined by Tcl-API

- make effects of namespace-imported classes more local

FilterSearchAgain(): Avoid running into an invalid pointer access, when the physical deletion of "del" conflicts with following the next link in the cmdList in the loop's increment statement (only iff del == cmdList). Re-organized for into a while loop, to avoid redundant code.

GetClassFromObj(): Fix invalid memory access (valgrind)

- make intentions about clientData clear to static checker

- remove commented code from the previous implementation

- move declarations to the begin of a code block - remove debug code

- add pre-8.7 Makefile.in (missed in last commit)

- use consistent comment styles

- NsfProcStubDeleteProc(): Protect against potentially dangling namespace references from within ::nsf::procs::*. The wrapper cmd's namespace of an nsf::proc might already have been deleted when ::nsf::procs::* shuts down finally. This showed up during a Tcl_Exit (NSF's ExitHandler) as an invalid memory access via (dangling) namespace pointers (valgrind).

- let nsf compile under tcl 8.7 (current trunk version of Tcl)

    • -0
    • +362
    /generic/stubs8.7/nsfDecls.h
    • -0
    • +89
    /generic/stubs8.7/nsfIntDecls.h
    • -0
    • +130
    /generic/stubs8.7/nsfStubInit.c
cmd resolver work - fix test, when OS specific cmd resolver is used from a NSF_CSC_CALL_IS_COMPILE frame - improved output from __db_show_obj: put results into one line instead of multiple lines - new debug function __db_get_obj: return into about a tcl_obj in form of a dict (in general, one should not rely on Tcl_Obj internals, especially when upgrading over major Tcl versions, but for testing/understanding behavior etc., such a command is helpful). - extend regression test

Shift some atomic tests into test case

Revive and include test case on Bug 3418547

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

- add test for the global cmd literal sharing - keep experimental code for disassembling methods

    • -0
    • +104
    /tests/cmdresolution.test