• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- don't abbreviate "info" subcommands

- no need for "\" in continuation lines of expression

- use "in" operator instead of lsearch (for readability and performance)

- add outdated function based on non-existing tables (currency_codes)

    • -0
    • +32
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-widget-procs.tcl
    • -0
    • +15
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-widget-procs.xql
- move ad_user_class_query and ad_user_class_query_count_only from

packages/acs-tcl/tcl/admin-procs.{tcl,xql} to acs-outdated/tcl/

since these functions are non-functional (based on non-existing

tables)

- move related code from acs-admin/www/users/one.{tcl,xql} to acs-outdated/www/

    • -241
    • +1
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
    • -61
    • +0
    /openacs-4/packages/acs-tcl/tcl/admin-procs.xql
- move ad_user_class_query and ad_user_class_query_count_only from

packages/acs-tcl/tcl/admin-procs.{tcl,xql} to acs-outdated/tcl/

since these functions are non-functional (based on non-existing

tables)

- move related code from acs-admin/www/users/one.{tcl,xql} to acs-outdated/www/

    • -0
    • +241
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-admin-procs.tcl
    • -0
    • +61
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-admin-procs.xql
    • -0
    • +71
    /openacs-4/packages/acs-outdated/www/acs-tcl-users-one.tcl
- use "in" oeprator instead of "lsearch" to improve readability and performance

- added acs-outdated

- initial checkin

    • -0
    • +28
    /openacs-4/packages/acs-outdated/acs-outdated.info
- fix incorrect variable name "package_id" used instead of "subsite_id"

- make variable check explicit

- no need to use "expr" in a condition of a "for" loop

- modernize tcl

- brace expressions

- no need to use expr in condition of for loop

- no need to test for existence when variables have defaults

- not need to check for existence of variables with defaults: email, first_names, limit_to_users_in_group_id authority_id last_name_starts_with

- fix spelling limit_users_in_group_id -> limit_to_users_in_group_id

- "email" and "limit_to_user_id" have defaults, no need to check for existence

- "email" and "last_name" have defaults, no need to check for existence

- use "in" operator instead of lsearch

- simply string comparisons

- use tcl 8.5 extended index format for "lindex" and "lrange"

- bumped version number

- update search engine links default value

    • -16
    • +16
    /openacs-4/packages/search/search.info
- make exists_and_not_null explicit

- modernize tcl

- don't abbreviate subcommands

- follow usual indenting convention

- don't abbreviate subcommands

  1. … 8 more files in changeset.
- modernize tcl

- break overlong lines

    • -2
    • +2
    /openacs-4/packages/forums/lib/forums/new.tcl
  1. … 5 more files in changeset.
- don't abbreviate subcommands

- use tcl 8.5 extended index format for "string range"

- modernize tcl

- brace expressions

- modernize tcl

- brace expressions

- break overlong lines

- modernize tcl

    • -10
    • +18
    /openacs-4/packages/search/www/search.tcl
- modernize tcl

    • -5
    • +5
    /openacs-4/packages/news/lib/latest-news.tcl
    • -4
    • +4
    /openacs-4/packages/news/tcl/news-procs.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/index.tcl
    • -4
    • +4
    /openacs-4/packages/news/www/item-create-3.tcl
    • -3
    • +3
    /openacs-4/packages/news/www/preview.tcl