• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
reduce usage of deprecated procs

modernize tcl

use proper boolean in .adp files

modernize Tcl

reduce usage of deprecated procs

replace depreacted proc site_nodes_sync

remove traces of deprecated proc

Stop using deprecated proc site_map_unmount_application

stop using deprecated procs site_map_unmount_application and site_node_id

stop using deprecated procs (site_node_delete_package_instance, site_node_id)

    • -4
    • +5
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
simplify code

whitespace cleanup

replace depreacted proc

Mark procs as deprecated, which were previously just documented as

deprecated and document recommended versions via @see. These procs

should be moved to *deprecated*.tcl after a while to give people

a chance to react (maybe in 5.11 or 5.12).

site_node::conn_url -> ad_conn

site_nodes_sync -> site_node::init_cache

site_node_id -> site_node::get_node_id -url

site_map_unmount_application -> site_node::unmount

site_node_delete_package_instance -> site_node::delete

Fix typo

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

make prepared statement parser more robust against sql casts

moderniize tcl

improve documentation

modernize tcl

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
modermize tcl

modernize tcl

modernize Tcl

Performance: prefer lset over lreplace for modifying list values.

When a list element is modified, lset does it "in place", modifying the

variable itself, while lreplace works with values and returns a second copy

of the list with the modified elements, creating some unnecessary overhead.

On my local tests, this particular operation was around 30% faster.

More details: http://wiki.tcl.tk/1485 and http://wiki.tcl.tk/2556

Fix typo

Fix typos

    • -3
    • +3
    /openacs-4/packages/ams/tcl/ams-procs.tcl
    • -1
    • +1
    /openacs-4/packages/ams/www/doc/index.html
  1. … 136 more files in changeset.
fix typos

prefer XOTcl2 idioms

    • -16
    • +16
    /openacs-4/packages/s5/tcl/s5-procs.tcl
modernize tcl

    • -2
    • +2
    /openacs-4/packages/s5/tcl/s5-procs.tcl
Fix typos

Fix typo (info command -> info commands)

    • -3
    • +3
    /openacs-4/packages/s5/tcl/s5-procs.tcl
    • -6
    • +6
    /openacs-4/packages/tsoap/tcl/SOAP-procs.tcl
Fix get_community_id_from_url call